Repository navigation
Update the accounting software options and switch to a tile layout - #102267
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
ReviewI found no blocking issues. The code looks correct and all CI checks pass, except the independent-approval check. What I verified
Suggestions (non-blocking)
|
Regression checkI found no regressions in the App code. Existing options (QuickBooks Online, Xero, NetSuite, Other and the rest) keep the same stored values, the same Collect or Control choice, and the same Getting Started task. The web test results follow in the next comment. What I checked
Needs internal confirmation (not verifiable from App)
Not covered by the web test
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.mp4iOS: mWeb Safarimsafari.mp4MacOS: Chrome / Safariweb.mov |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.95-0 🚀
|
Help site review: no changes neededThis PR doesn't require any help site changes, so I didn't create a docs PR. No article under What I checked
@samarroy84, no help site PR was needed for this change, so there's nothing to mark |
|
Deploy Blocker #102469 was identified to be related to this PR. |
|
Deploy Blocker #102475 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|







Explanation of Change
Onboarding accounting step now shows options as tiles, driven by
ONBOARDING_ACCOUNTING_MAPPING.onboarding.accounting.none.Fixed Issues
$ #100691
PROPOSAL: #100691 (comment)
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web1.mov
web2.mov