You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-07] Android & iOS - Onboarding - Accounting tiles show 1 column after rotating to portrait #102475
Version Number: 9.4.95-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102267 Email or phone of affected tester (no customers):dnjosjdojionjso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Other
Action Performed:
Precondition:
Use larger font size.
Launch Expensify app.
Log in with new Gmail account.
Select Manage my team's expenses.
Proceed to "Do you use any accounting software?" step.
Rotate device to landscape and back to portrait.
Expected Result:
Accounting tiles will show 2 columns after rotating from landscape to portrait.
Actual Result:
Accounting tiles show 1 column after rotating from landscape to portrait.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause (medium confidence): On phones, each tile uses flexBasis: '45%', maxWidth: '48.5%' inside a wrapping flex row with a 12px gap. Yoga caches a percentage flexBasis. After a landscape → portrait rotation, the cached landscape basis gets capped at 48.5% of the portrait row. Two tiles plus the gap then exceed 100% of the row, so every tile wraps onto its own line.
Recommendation: Roll forward with a small fix instead of reverting. The bug is cosmetic, and a revert would also remove the new accounting options.
Preferred fix: Chunk accountingOptionKeys into rows of 2 (narrow) or 3 (wide). Render each row as a non-wrapping flexRow with gap3, give tiles flex: 1, and pad a short last row with empty spacers.
Style-only fix: Replace flexBasis/maxWidth with a percentage width that leaves room for the gap (about 48% narrow, about 31% wide). Yoga recalculates width on every layout.
Investigation details
The style choice at BaseOnboardingAccounting.tsx:177-181 doesn't change on rotation. isSmallScreenWidth is true in both orientations on phones (useResponsiveLayout/index.ts:41). There's no JS column math or onLayout involved, so the problem is in layout, not React state.
Yoga recalculates the flex basis only when its cached value is undefined (yoga/algorithm/CalculateLayout.cpp). The cache is cleared only when markDirtyAndPropagate() runs, not on ordinary prop updates.
Math on a ~412dp phone: the portrait row is about 372dp. The cached landscape basis gets capped to 48.5% × 372 ≈ 180.4dp, and 180.4 + 12 + 180.4 = 372.8dp is more than 372, so the tiles wrap. On a fresh portrait layout the 45% basis (about 167dp) fits, and flexGrow fills the row.
Why larger font size matters (unverified): the App's react-native+0.86.0+037+fix-stale-font-scale.patch calls markDirtyAndPropagate() when the font scale is non-default. That likely resets the cached basis during the landscape pass, and nothing resets it on the way back to portrait.
The layout is also fragile in general: 2 × 48.5% + 12px is more than 100% whenever the row is narrower than 400dp.
I couldn't reproduce this live because it needs native device rotation. These findings come from reading the code.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Android & iOS - Onboarding - Accounting tiles show 1 column after rotating to portrait[/-][+][Due for payment 2026-10-07] Android & iOS - Onboarding - Accounting tiles show 1 column after rotating to portrait[/+]on Sep 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Sep 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1a3e17ca59edec2d2928bd52783e8bf7402f99a346c144ef5ee14ab296e8f27c
melvin-bot commentedon Sep 28, 2026
@roryabraham recently merged #102267, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Sep 28, 2026
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Sep 28, 2026
@roryabraham @mkhutornyi you have been assigned to this deploy blocker because you reviewed the offending PR: #102267
melvin-bot commentedon Sep 28, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Sep 28, 2026
Deploy Blocker Analysis
Causing PR: Update the accounting software options and switch to a tile layout (author
samarroy84, merged 2026-09-26). It added the two-column tile grid on phones, so this is a new-feature regression, not a prod issue.Root cause (medium confidence): On phones, each tile uses
flexBasis: '45%', maxWidth: '48.5%'inside a wrapping flex row with a 12px gap. Yoga caches a percentageflexBasis. After a landscape → portrait rotation, the cached landscape basis gets capped at 48.5% of the portrait row. Two tiles plus the gap then exceed 100% of the row, so every tile wraps onto its own line.Recommendation: Roll forward with a small fix instead of reverting. The bug is cosmetic, and a revert would also remove the new accounting options.
accountingOptionKeysinto rows of 2 (narrow) or 3 (wide). Render each row as a non-wrappingflexRowwithgap3, give tilesflex: 1, and pad a short last row with empty spacers.flexBasis/maxWidthwith a percentagewidththat leaves room for the gap (about 48% narrow, about 31% wide). Yoga recalculateswidthon every layout.Investigation details
BaseOnboardingAccounting.tsx:177-181doesn't change on rotation.isSmallScreenWidthis true in both orientations on phones (useResponsiveLayout/index.ts:41). There's no JS column math oronLayoutinvolved, so the problem is in layout, not React state.yoga/algorithm/CalculateLayout.cpp). The cache is cleared only whenmarkDirtyAndPropagate()runs, not on ordinary prop updates.flexGrowfills the row.react-native+0.86.0+037+fix-stale-font-scale.patchcallsmarkDirtyAndPropagate()when the font scale is non-default. That likely resets the cached basis during the landscape pass, and nothing resets it on the way back to portrait.2 × 48.5% + 12pxis more than 100% whenever the row is narrower than 400dp.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.2 remaining items
mountiny commentedon Sep 29, 2026
@mkhutornyi Thanks for raising the PR, I dont think this has to be a blocker but lets fix it asap
IuliiaHerets commentedon Sep 29, 2026
@mountiny issue is not repro by original tester on samsung galaxy s25fe / Android 16 using ad-hoc build
e30421c7effeec6d6f32099ecc660ae5.mp4
[-]Android & iOS - Onboarding - Accounting tiles show 1 column after rotating to portrait[/-][+][Due for payment 2026-10-07] Android & iOS - Onboarding - Accounting tiles show 1 column after rotating to portrait[/+]melvin-bot commentedon Sep 30, 2026
@mkhutornyi
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
mountiny commentedon Oct 1, 2026
No payment this was a follow up