You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-23] [$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals) #102976
Search bulk actions and the report selection toolbar each mount their own one-button DecisionModal alerts. These modals should use the global useDecisionModal instead. Each change is mechanical. Most of the work is in the large useSearchBulkActions hook and its tests.
"Offline". State lives in useSearchBulkActions.ts:614 and is set at about 14 sites. Keep the deferModalPresentationAfterPopoverDismiss wrapper at L1494.
"Download failed". The prompt reads emptyReportsCount, which is only reset at L1188, so the prompt can be stale. Pass an explicit prompt at each call site: downloadFailedEmptyReportDescription with a count, or downloadFailedDescription.
"Download failed" from onExportFailed. This also fixes a bug. On wide layouts the toolbar unmounts after a CSV export starts (useSelectedTransactionsActions.ts:446), so the inline modal never appears when the export fails.
In useSearchBulkActions: the visibility state (L614, 615, 620, 628), the close handlers (L3239-3245, L3260-3262), and the related return fields.
In SelectionToolbar: the offlineModalVisible and isDownloadErrorModalVisible state (L95-96). Leave the ProcessMoneyReportHoldMenu block in this file to Batch 3.
Tests to update
These tests assert on hook visibility state. Switch them to mocking useDecisionModal, the way useExportActionsTest.ts:51-54 does.
All five alerts now open through useDecisionModal(), and SearchBulkActionsButton.tsx no longer imports DecisionModal.
Each "Download failed" trigger now passes its own prompt, so the stale empty-report text can't appear.
The bulk-pay offline alert still uses the deferModalPresentationAfterPopoverDismiss wrapper.
The SelectionToolbar CSV-export failure alert no longer depends on the toolbar staying mounted, so it shows on wide layouts.
Checks: Typecheck passed. The five affected Jest suites passed (114 tests), including a new test for the empty-report prompt. ESLint found no new errors. I did not run the full Jest suite or the Storybook smoke test.
Not verified in the app: The test browser session was blank, so I couldn't click through the alerts. Please test on all platforms, especially iOS, where some alerts open while a popover is still closing.
I couldn't push to your fork, so the branch is on upstream. The PR has a comment with the commands to move it to your fork.
changed the title [-][Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/-][+][$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/+]on Oct 14, 2026
changed the title [-][$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/-][+][Due for payment 2026-10-23] [$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/+]on Oct 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-23. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon Oct 8, 2026
@roryabraham, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!
ZhenjaHorbach commentedon Oct 9, 2026
@MelvinBot
Create the PR to migrate all modals from the issue description
MelvinBot commentedon Oct 9, 2026
🤖 Draft PR created: Use useDecisionModal for Search bulk actions and SelectionToolbar alerts
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.
All five alerts now open through
useDecisionModal(), andSearchBulkActionsButton.tsxno longer importsDecisionModal.deferModalPresentationAfterPopoverDismisswrapper.SelectionToolbarCSV-export failure alert no longer depends on the toolbar staying mounted, so it shows on wide layouts.Checks: Typecheck passed. The five affected Jest suites passed (114 tests), including a new test for the empty-report prompt. ESLint found no new errors. I did not run the full Jest suite or the Storybook smoke test.
Not verified in the app: The test browser session was blank, so I couldn't click through the alerts. Please test on all platforms, especially iOS, where some alerts open while a popover is still closing.
I couldn't push to your fork, so the branch is on upstream. The PR has a comment with the commands to move it to your fork.
melvin-bot commentedon Oct 12, 2026
@roryabraham, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ZhenjaHorbach commentedon Oct 13, 2026
Not overdue
Try to complete reviewing the PR today
[-][Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/-][+][$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/+]melvin-bot commentedon Oct 14, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022110312069421524962
[-][$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/-][+][Due for payment 2026-10-23] [$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals)[/+]melvin-bot commentedon Oct 16, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-23. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 19, 2026
@ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ZhenjaHorbach commentedon Oct 20, 2026
@roryabraham
Let's close this!