Skip to content

Members - Not here page is shown briefly after editing member's display name #103853

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.8-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100727
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Invite a non-existing user.
  4. Click on the invited member.
  5. Click Profile > Display name.
  6. Enter name and save it.

Expected Result:

RHP will close without showing not here page.

Actual Result:

Not here page is shown briefly after editing member's display name.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7285203_1791887575116.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7285203

Issue OwnerCurrent Issue Owner: @gijoe0295

Activity

  1. applause-bot commented on Oct 13, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/ecde7b75fa76d8818f08c3f20fb3d0840042224db3b86dc44057a3665694af7e

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 13, 2026
  3. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #100727

  4. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @arosiclair @gijoe0295 you have been assigned to this deploy blocker because you reviewed the offending PR: #100727

  5. github-actions commented on Oct 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @allgandalf you have been assigned to this deploy blocker because you authored the offending PR: #100727

  7. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 13, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Allow workspace admins to set a member's display name (high confidence). This is a frontend bug in a new feature, so the fix belongs in Expensify/App.

    Root cause: The new display name page hides itself once the member has a name. Saving sets that name right away, before the server responds. The page then shows Not Found while the panel is still closing.

    Recommended fix (preferred over a revert): Skip the "already has a name" check after the admin saves on this page.

    const [hasSubmitted, setHasSubmitted] = useState(false);
    // in onSubmit, before calling updatePolicyMemberDisplayName(...)
    setHasSubmitted(true);
    // guard
    shouldBeBlocked={!isLoadingMemberPersonalDetails && !hasSubmitted && (hasDisplayNameSet || !isPolicyMember)}

    Revert the PR only if this fix can't land before the deploy. The PR is a full feature of 31 files, and the save itself works.

    Investigation details
    1. The page blocks itself when the member already has a first or last name: WorkspaceMemberDisplayNamePage.tsx:44-55.
    2. onSubmit calls updatePolicyMemberDisplayName(...) and then Navigation.goBack(): WorkspaceMemberDisplayNamePage.tsx:74-87.
    3. That action writes the new firstName and lastName to personal details right away, before the server responds: Member.ts:1475-1483.
    4. hasDisplayNameSet turns true, so shouldBeBlocked turns true. The screen stays focused until the back transition ends, so the wrapper shows Not Found: AccessOrNotFoundWrapper.tsx:225-226.

    This explains why the bug happens only for members with no name, such as a newly invited user, and only on staging, where the feature is new.

    Alternative considered: Skip the check while pendingFields.displayName is set. This is weaker. A fast server response clears that field and could bring the flash back while the screen is still mounted.

    Not verified in a browser. These findings come from reading the code. After the fix, confirm:

    • The panel closes with no flash.
    • Opening the route directly for a member who already has a name still shows Not Found.
    • Opening the route for a user who isn't a member still shows Not Found.

    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  9. flaviadefaria commented on Oct 13, 2026

    @flaviadefaria
    Contributor

    @allgandalf @arosiclair, again, let's fix this, but also not a deploy blocker.

  10. allgandalf commented on Oct 13, 2026

    @allgandalf
    Contributor

    Fix is up: #103868

  11. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 13, 2026
  12. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @gijoe0295

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions