You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Members - Not here page is shown briefly after editing member's display name #103853
Version Number: 9.5.8-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100727 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Members.
Invite a non-existing user.
Click on the invited member.
Click Profile > Display name.
Enter name and save it.
Expected Result:
RHP will close without showing not here page.
Actual Result:
Not here page is shown briefly after editing member's display name.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The new display name page hides itself once the member has a name. Saving sets that name right away, before the server responds. The page then shows Not Found while the panel is still closing.
Recommended fix (preferred over a revert): Skip the "already has a name" check after the admin saves on this page.
const[hasSubmitted,setHasSubmitted]=useState(false);// in onSubmit, before calling updatePolicyMemberDisplayName(...)setHasSubmitted(true);// guardshouldBeBlocked={!isLoadingMemberPersonalDetails&&!hasSubmitted&&(hasDisplayNameSet||!isPolicyMember)}
Revert the PR only if this fix can't land before the deploy. The PR is a full feature of 31 files, and the save itself works.
That action writes the new firstName and lastName to personal details right away, before the server responds: Member.ts:1475-1483.
hasDisplayNameSet turns true, so shouldBeBlocked turns true. The screen stays focused until the back transition ends, so the wrapper shows Not Found: AccessOrNotFoundWrapper.tsx:225-226.
This explains why the bug happens only for members with no name, such as a newly invited user, and only on staging, where the feature is new.
Alternative considered: Skip the check while pendingFields.displayName is set. This is weaker. A fast server response clears that field and could bring the flash back while the screen is still mounted.
Not verified in a browser. These findings come from reading the code. After the fix, confirm:
The panel closes with no flash.
Opening the route directly for a member who already has a name still shows Not Found.
Opening the route for a user who isn't a member still shows Not Found.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 13, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ecde7b75fa76d8818f08c3f20fb3d0840042224db3b86dc44057a3665694af7e
melvin-bot commentedon Oct 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100727
melvin-bot commentedon Oct 13, 2026
@arosiclair @gijoe0295 you have been assigned to this deploy blocker because you reviewed the offending PR: #100727
github-actions commentedon Oct 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 13, 2026
@allgandalf you have been assigned to this deploy blocker because you authored the offending PR: #100727
melvin-bot commentedon Oct 13, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 13, 2026
Deploy Blocker Analysis
Causing PR: Allow workspace admins to set a member's display name (high confidence). This is a frontend bug in a new feature, so the fix belongs in
Expensify/App.Root cause: The new display name page hides itself once the member has a name. Saving sets that name right away, before the server responds. The page then shows Not Found while the panel is still closing.
Recommended fix (preferred over a revert): Skip the "already has a name" check after the admin saves on this page.
Revert the PR only if this fix can't land before the deploy. The PR is a full feature of 31 files, and the save itself works.
Investigation details
WorkspaceMemberDisplayNamePage.tsx:44-55.onSubmitcallsupdatePolicyMemberDisplayName(...)and thenNavigation.goBack():WorkspaceMemberDisplayNamePage.tsx:74-87.firstNameandlastNameto personal details right away, before the server responds:Member.ts:1475-1483.hasDisplayNameSetturns true, soshouldBeBlockedturns true. The screen stays focused until the back transition ends, so the wrapper shows Not Found:AccessOrNotFoundWrapper.tsx:225-226.This explains why the bug happens only for members with no name, such as a newly invited user, and only on staging, where the feature is new.
Alternative considered: Skip the check while
pendingFields.displayNameis set. This is weaker. A fast server response clears that field and could bring the flash back while the screen is still mounted.Not verified in a browser. These findings come from reading the code. After the fix, confirm:
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.flaviadefaria commentedon Oct 13, 2026
@allgandalf @arosiclair, again, let's fix this, but also not a deploy blocker.
allgandalf commentedon Oct 13, 2026
Fix is up: #103868
melvin-bot commentedon Oct 16, 2026
@gijoe0295
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]