Repository navigation
Fix Not here flash, Display name hover and whisper disappearing after a reaction - #103868
Conversation
|
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
jest failure is flaky i think lets rerun |
|
Will review in 2 hours |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Screen.Recording.2026-10-13.at.23.50.18.mov
Screen.Recording.2026-10-14.at.11.45.31.movAndroid: mWeb Chrome- Not here flash, Display name hover:Screen.Recording.2026-10-13.at.23.26.30.mov
Screen.Recording.2026-10-14.at.11.48.24.moviOS: HybridApp
Screen.Recording.2026-10-14.at.00.10.19.mov
Screen.Recording.2026-10-14.at.11.41.10.moviOS: mWeb Safari- Not here flash, Display name hover:Screen.Recording.2026-10-13.at.23.24.39.mov
Screen.Recording.2026-10-14.at.11.49.50.movMacOS: Chrome / Safari
Screen.Recording.2026-10-13.at.23.03.01.mov
Screen.Recording.2026-10-14.at.11.50.22.mov |
|
@MelvinBot review the changes for accessibility issues and addressed its findings |
Accessibility reviewI found no accessibility issues in this PR, so there is nothing to change.
What I checked
This was a code review only. I did not run a screen reader. |
|
@arosiclair all yours |
|
@gijoe0295 fixed another issue #103933 can you test |
|
@allgandalf all tests passed. Videos updated |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.10-0 🚀
|
|
No help site update is needed. This PR only fixes three bugs in the member Display name flow: the Not here flash after saving, the hover width on the Display name row, and the display name message disappearing after a reaction. None of these fixes adds a feature or makes any help article sentence wrong. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.12-0 🚀
|
|
No help site update is needed. This PR only fixes three bugs in the member Display name flow: the Not here flash after saving, the hover width on the Display name row, and the display name message disappearing after a reaction. None of these fixes adds a feature or makes any help article sentence wrong. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Saving a member's display name sets the name right away, and the page blocks itself for any member who already has one, so Not here showed for a moment while the page was closing. The page now skips that check once it has saved.
The Display name row on Profile was padded 20px on both sides, so its hover stopped short of the edges. It now covers the full width like See chat history.
After a reaction the backend sends the display name whisper back with an empty message, so it was treated as deleted and hidden until the chat was reopened. It is now skipped in
isDeletedAction, since its text comes fromoriginalMessage.Fixed Issues
$ #103853
$ #103856
$ #103933
PROPOSAL:
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Not here page, before
before.mp4
Not here page, after
after.mp4
Display name hover, before
Display name hover, after
Reacting to the display name message, before
react-before.mp4
Reacting to the display name message, after
react-after.mp4