Skip to content

Members - Hover effect on Display name is cut off on left and right #103856

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.8-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100727
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Invite a non-existing user.
  4. Click on the invited member.
  5. Click Profile.
  6. Hover over Display name.
  7. Hover over See chat history.

Expected Result:

Hover effect on Display name field will extend throughout the RHP width.

Actual Result:

Hover effect on Display name is cut off on left and right.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7285204_1791887651107.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7285204

Issue OwnerCurrent Issue Owner: @gijoe0295

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 13, 2026
  2. applause-bot commented on Oct 13, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/dc85e281287d322ccedb469e5fe8670c2a145ae90579532355857e7b8c4db5a8

  3. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #100727

  4. github-actions commented on Oct 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @arosiclair @gijoe0295 you have been assigned to this deploy blocker because you reviewed the offending PR: #100727

  6. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @allgandalf you have been assigned to this deploy blocker because you authored the offending PR: #100727

  7. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 13, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Cause: Allow workspace admins to set a member's display name added the clickable Display name row inside the avatar section wrapper, which has 20px side padding. The row's hover background can't reach past that padding, so it stops 20px short on each side.

    Recommendation: Demote or roll forward with a one-line fix. Don't revert. The bug is cosmetic, and the PR touches 31 files for a feature that isn't in production yet.

    Fix: In src/pages/ProfilePage.tsx:296-299:

    • Change the wrapper View style from [styles.w100, styles.detailsPageSectionContainer] to [styles.alignSelfStretch, styles.mhn5].
    • Remove style={[styles.ph0]} from the MenuItemWithTopDescription.

    The -20px margins cancel the wrapper's padding. The menu item's default padding keeps the text lined up with the Email row.

    Investigation details
    • The Display name row (ProfilePage.tsx:295-308) is new in that PR. It copies the read-only Email, Status, and Pronouns rows, including styles.ph0.
    • The row sits inside avatarSectionWrapper, opened at ProfilePage.tsx:241. That style has paddingHorizontal: 20 (src/styles/index.ts:3212-3217).
    • The gap is invisible on read-only rows. Display name is the first clickable row in this wrapper. It's only clickable (interactive={!hasDisplayNameSet}) when the member has no name, which is why the bug shows up with an invited, non-existing user.
    • "See chat history" (ProfilePage.tsx:352-365) sits outside the wrapper, so its hover spans the full width.
    • Both w100 and detailsPageSectionContainer (alignSelf: 'flex-start') must go. With width: 100% plus negative margins, the row would only shift left.
    • Alternative: move the row out of the wrapper, as WorkspaceMemberDetailsPage.tsx:396-425 does. That would put Display name below Pronouns and local time, which needs a design call.
    • Impact: hover highlight only. Clicking still opens the display-name page. Only admins viewing a member with no name set will see it.

    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. flaviadefaria commented on Oct 13, 2026

    @flaviadefaria
    Contributor

    @allgandalf @arosiclair, let's fix this, but it's definitely not a deploy blocker.

  10. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 13, 2026
  11. allgandalf commented on Oct 14, 2026

    @allgandalf
    Contributor

    Fix is up: #103868

  12. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @gijoe0295

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions