Skip to content

Category - Create button has to be tapped twice in landscape mode if keyboard is opened. #104151

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.10-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103310
Email or phone of affected tester (no customers): ibellicotest+3215@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Money Requests

Action Performed:

Prerequisite: Have AnchoredFieldDropdowns beta enabled on troubleshoot.
Prerequisite 2: Account has a workspace with "Categories" enabled.

  1. Open the Expensify app.
  2. Tap on FAB > "Create Expense" > Manual
  3. Tap on "Category" field.
  4. Turn to landscape mode.
  5. If keyboard is not opened, tap on search input to display it.
  6. Tap on "+" button on the top right corner to open "Add Category" tab.
  7. Note that keyboard is dismissed, but user is not redirected to "Add Category"

Expected Result:

Tapping on "+" button while on "Category" dropdown, should automatically redirect to "Add Category" tab.

Actual Result:

"+" button on "Category" dropdown, has to be tapped twice to open "Add Category" tab if user is in landscape mode while keyboard is displayed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7287456_1792087260447.Anchor.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7287456

Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2026
  2. applause-bot commented on Oct 15, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d574c01ecf989cfe1baec814e5ebb6ceedeef0b78f6ed378776d9457d86716de

  3. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103310

  4. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    @puneetlath @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #103310

  5. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    @DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #103310

  6. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Oct 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Oct 15, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Add create button on category dropdown added the "+" button, so this bug could not appear before it. That PR's code does not swallow the tap, though. The cause is a modal default that the anchored category dropdown has inherited since [CFI] Open the Category list in a container anchored to its row.

    Recommendation: Demote this issue, or roll forward with a one-line fix. Do not revert. The issue affects only users with the AnchoredFieldDropdowns beta, on Android in landscape with the keyboard open. A second tap works, and no data is lost.

    Fix: Add shouldWrapModalChildrenInScrollViewIfBottomDockedInLandscapeMode={false} to <PopoverWithMeasuredContent> in CategoryPickerModal.tsx:143-160. Similar search-and-list pickers already set this, for example FilterPopupButton.tsx:156 and EmojiPicker.tsx:284.

    Mechanism
    1. On native, the picker always renders as a bottom-docked modal.
    2. BaseModal defaults shouldWrapModalChildrenInScrollViewIfBottomDockedInLandscapeMode to true (BaseModal.tsx:91). In landscape, it wraps the modal content in a plain <ScrollView> (BaseModal.tsx:316, BaseModal.tsx:429).
    3. That ScrollView does not set keyboardShouldPersistTaps, so React Native uses its default, 'never'. While the keyboard is open, the first tap outside a text input only dismisses the keyboard. The second tap reaches the "+" button (CategoryPickerModal.tsx:184-187).
    4. The wrapper exists only in landscape, which is why portrait works.

    Not verified on a device: Tapping a category row in landscape with the keyboard open probably also needs two taps. If it does, that part has been in production behind the beta since #102665.

    When testing the fix on Android landscape, confirm that:

    • The header, search input, and list still fit within the modal height.
    • The "+" button and a category row each respond to a single tap while the keyboard is open.

    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  9. puneetlath commented on Oct 15, 2026

    @puneetlath
    Contributor

    Demoting as a blocker, but let's fix @DylanDylann.

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 15, 2026
  11. DylanDylann commented on Oct 16, 2026

    @DylanDylann
    Contributor

    will be fixed by #103552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions