Skip to content

Add create button on category dropdown - #103310

Merged
puneetlath merged 13 commits into
Expensify:mainfrom
DylanDylann:dylann/103217-category-popover-add-button
Oct 14, 2026
Merged

puneetlath merged 13 commits into
Expensify:mainfrom
DylanDylann:dylann/103217-category-popover-add-button

Conversation

@DylanDylann

@DylanDylann DylanDylann commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Add a create button to the category dropdown to allow creating a new category

Fixed Issues

$ #103217
PROPOSAL:

Tests

QA Steps

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

QA Steps

Precondition:

  • Enable anchoredFieldDropdowns
  1. Launch app
  2. Tap create expense - Category
  3. Note plus icon is shown on the top right
  4. Click on the + button to create a new category
  5. The new category is created correctly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
Screen.Recording.2026-10-08.at.17.26.00.mov
iOS: HybridApp
Screen.Recording.2026-10-08.at.17.40.48.mov
iOS: mWeb Safari
Screen.Recording.2026-10-08.at.17.26.53.mov
MacOS: Chrome / Safari
Screen.Recording.2026-10-08.at.17.24.56.mov

@DylanDylann
DylanDylann requested review from a team as code owners October 7, 2026 10:32
@melvin-bot
melvin-bot Bot requested review from garrettmknight and ikevin127 and removed request for a team and garrettmknight October 7, 2026 10:32
@melvin-bot

melvin-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 7, 2026 10:32
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
src/ROUTES.ts 32.23% <100.00%> (+0.05%) ⬆️
.../components/CategoryPicker/CategoryPickerModal.tsx 98.24% <100.00%> (+0.20%) ⬆️
...RequestConfirmationList/sections/CategoryField.tsx 97.61% <100.00%> (+0.08%) ⬆️
...onfirmationList/sections/CategoryFieldDropdown.tsx 94.11% <100.00%> (+94.11%) ⬆️
...ConfirmationList/sections/ExpenseFieldDropdown.tsx 100.00% <100.00%> (ø)
src/libs/PolicyUtils/index.ts 88.19% <100.00%> (+0.02%) ⬆️
...iou/request/step/DynamicIOURequestStepCategory.tsx 0.00% <0.00%> (ø)
... and 72 files with indirect coverage changes

@ikevin127

ikevin127 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native 🔄
iOS: Native 🔄
MacOS: Chrome / Safari 🔄

Comment thread src/ROUTES.ts Resolved
Comment thread tests/unit/PolicyUtilsTest.ts Resolved

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes: dropped (7) inline comments, 2 of them 🟠. The main one: on the share-an-image flow, the new + button opens a Not Found page.

Please tag me once the comments are addressed, also keep an eye out for design team's input on the below.


@Expensify/design Might want to take a look at the UI positioning of the ➕ button before moving forward here as it seems a bit off, here's pics from Web (wide), Android and iOS native:

Web Android iOS
Image Image Image

@shawnborton

Copy link
Copy Markdown
Contributor

That does seem off - here are the specs:

CleanShot 2026-10-08 at 9 48 39 AM@2x

@shawnborton

Copy link
Copy Markdown
Contributor

(Although ignore that gap of 10 - that can be just using flex to put that all the way on the right.)

@DylanDylann

Copy link
Copy Markdown
Contributor Author

@ikevin127 back to you

@ikevin127

Copy link
Copy Markdown
Contributor

@DylanDylann Thanks for addressing the previous comments, tests well:

Screenshot_20261008-143552_New Expensify Dev

Ready after these 2 items:

  1. Go back to .path (or pass routeReportID) in DynamicIOURequestStepCategory.tsx:113 (see comment).
  2. Merge main to clear the conflicts.

The two 🟢 items are optional - won't block on them.

@ikevin127

Copy link
Copy Markdown
Contributor

Based on Figma, we end up having 20px of padding above, and 16px of padding below. Right now we have the opposite.

✅ Confirmed. Awaiting for @DylanDylann to apply the fix before merging this one.

@DylanDylann

Copy link
Copy Markdown
Contributor Author

@shawnborton @ikevin127 Fixed

Screen.Recording.2026-10-13.at.11.51.45.mov

@DylanDylann

Copy link
Copy Markdown
Contributor Author

The failing type check seems unrelated

@melvin-bot
melvin-bot Bot requested a review from puneetlath October 13, 2026 05:08
@puneetlath

Copy link
Copy Markdown
Contributor

@shawnborton does it look correct to you now?

@DylanDylann you have conflicts.

@shawnborton

Copy link
Copy Markdown
Contributor

Yup, looks good 👍

@DylanDylann

DylanDylann commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Just added a back button to the header as confirmed on Slack

Screenshots/Videos

Android: HybridApp Screenshot 2026-10-14 at 17 43 48
Android: mWeb Chrome Screenshot 2026-10-14 at 17 41 28
iOS: HybridApp Screenshot 2026-10-14 at 17 42 07
iOS: mWeb Safari Screenshot 2026-10-14 at 17 41 16
MacOS: Chrome / Safari Screenshot 2026-10-14 at 17 41 09

@puneetlath
puneetlath merged commit 96adeeb into Expensify:main Oct 14, 2026
34 of 35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed: the new add-category button only appears in the category dropdown, and that dropdown is gated behind the anchoredFieldDropdowns beta.

Details
  • The dropdown opens only when isBetaEnabled(CONST.BETAS.ANCHORED_FIELD_DROPDOWNS) is true (CategoryField.tsx:113-118). Users without the beta still get the full-page category selector.
  • The full-page selector's change is a refactor. It moves the existing canCreateCategoryInSitu check into PolicyUtils and does not change behavior.

Revisit the help site when the anchoredFieldDropdowns beta is removed.


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #104151 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed: the new add-category button only appears in the category dropdown, which is still gated behind the anchoredFieldDropdowns beta on main (CategoryField.tsx:113-118).

The rest of the PR moves an existing check into PolicyUtils and doesn't change what users see. Revisit the help site when the beta is removed.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants