Repository navigation
Add create button on category dropdown - #103310
puneetlath merged 13 commits into
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: Native 🔄iOS: Native 🔄MacOS: Chrome / Safari 🔄 |
ikevin127
left a comment
There was a problem hiding this comment.
Requesting changes: dropped (7) inline comments, 2 of them 🟠. The main one: on the share-an-image flow, the new + button opens a Not Found page.
Please tag me once the comments are addressed, also keep an eye out for design team's input on the below.
@Expensify/design Might want to take a look at the UI positioning of the ➕ button before moving forward here as it seems a bit off, here's pics from Web (wide), Android and iOS native:
| Web | Android | iOS |
|---|---|---|
![]() |
![]() |
![]() |
|
(Although ignore that gap of |
|
@ikevin127 back to you |
|
@DylanDylann Thanks for addressing the previous comments, tests well:
Ready after these 2 items:
The two 🟢 items are optional - won't block on them. |
…y-popover-add-button
✅ Confirmed. Awaiting for @DylanDylann to apply the fix before merging this one. |
|
@shawnborton @ikevin127 Fixed Screen.Recording.2026-10-13.at.11.51.45.mov |
|
The failing type check seems unrelated |
|
@shawnborton does it look correct to you now? @DylanDylann you have conflicts. |
|
Yup, looks good 👍 |
|
Just added a back button to the header as confirmed on Slack Screenshots/Videos |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.10-0 🚀
|
|
No help site update is needed: the new add-category button only appears in the category dropdown, and that dropdown is gated behind the Details
Revisit the help site when the |
|
Deploy Blocker #104151 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.12-0 🚀
|
|
No help site update is needed: the new add-category button only appears in the category dropdown, which is still gated behind the The rest of the PR moves an existing check into |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |










Explanation of Change
Add a create button to the category dropdown to allow creating a new category
Fixed Issues
$ #103217
PROPOSAL:
Tests
QA Steps
Offline tests
QA Steps
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: HybridApp
Android: mWeb Chrome
Screen.Recording.2026-10-08.at.17.26.00.mov
iOS: HybridApp
Screen.Recording.2026-10-08.at.17.40.48.mov
iOS: mWeb Safari
Screen.Recording.2026-10-08.at.17.26.53.mov
MacOS: Chrome / Safari
Screen.Recording.2026-10-08.at.17.24.56.mov