Skip to content

iOS - Bottom tab bar changes theme quicker than the rest of the app #104259

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101339
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Launch Expensify app.
  2. Enable/disable dark mode.

Expected Result:

Bottom tab bar will change theme together with the rest of the app.

Actual Result:

Bottom tab bar changes theme quicker than the rest of the app.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

To be added by Applause Leads

Bug7288099_1792153955862.ScreenRecording_10-16-2026_20-30-58_1.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7288099

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2026
  2. applause-bot commented on Oct 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/93b96b6795bfed65622e006f6f55efd5d33b9e009d49260d4ac3a3ff88a329d6

  3. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #101339

  4. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @grgia @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #101339

  5. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @sumo-slonik you have been assigned to this deploy blocker because you authored the offending PR: #101339

  6. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Oct 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Oct 16, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    Causing PR: Add liquid glass bottom tab bar to iOS, Android and mWeb. The auto-assignment is correct. Confidence: high.

    Recommendation: Roll forward with a small fix. Don't revert. The PR is large (90+ files and several library patches) and already has a CP follow-up. The bug is cosmetic: about 300ms of theme mismatch when the user switches dark mode. If nobody can ship the fix quickly, demoting this blocker is reasonable.

    Proposal

    What is the root cause of that problem?

    The app reads the theme from two sources that update at different times:

    1. App content waits 300ms. ThemeProvider passes the theme through useDebouncedState (ThemeProvider.tsx:19), so everything that uses useTheme() changes about 300ms after the switch.
    2. The navigation theme changes right away. NavigationRoot builds its base theme from useThemePreference(), which isn't delayed (NavigationRoot.tsx:140, L194).

    This mismatch was harmless until #101339. That PR moved the tab bar to createNativeBottomTabNavigator (TabNavigator.native.tsx:11). The native tab bar sets colorScheme={dark ? 'dark' : 'light'} from the navigation theme's dark flag. iOS applies that through overrideUserInterfaceStyle and repaints the liquid-glass bar right away. The old JS tab bar used the delayed useTheme() colors, so it changed together with the rest of the app.

    What changes do you think we should make in order to solve the problem?

    In NavigationRoot, choose the base navigation theme from the delayed theme that's already in scope (L141) instead of themePreference. Use theme.colorScheme (types.ts:154) to pick DarkTheme or DefaultTheme. Then drop themePreference from the useMemo dependencies (L210). The native bar then changes theme at the same time as the app.

    What alternative solutions did you explore? (Optional)

    Investigation details
    • None of the other 28 App PRs on Deploy Checklist: New Expensify 2026-10-16 touch the theme, the tab bar, appearance, or iOS files.
    • [CP Staging] Fix liquid glass bottom tab bar issues only patches Android duplicate tabs and touches on the hidden bar. It shipped in 9.5.13-1 and doesn't touch theming.
    • The tab bar icons and labels still use the delayed theme. So the bar's background changes about 300ms before its own icons and the page content, which matches the video.
    • The issue lists "Mac / Chrome" as the device, but this cause applies only to the native iOS bar. Wide desktop layouts and the mWeb bar use JS theming. The iOS: App checkbox and the title fit the cause, so the device field is probably a reporting mistake. Android's native bar may show the same bug, but I didn't verify that.
    • I didn't test this in the app.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/104259) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions