You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iOS - Bottom tab bar changes theme quicker than the rest of the app #104259
Version Number: 9.5.13-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#101339 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Launch Expensify app.
Enable/disable dark mode.
Expected Result:
Bottom tab bar will change theme together with the rest of the app.
Actual Result:
Bottom tab bar changes theme quicker than the rest of the app.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Roll forward with a small fix. Don't revert. The PR is large (90+ files and several library patches) and already has a CP follow-up. The bug is cosmetic: about 300ms of theme mismatch when the user switches dark mode. If nobody can ship the fix quickly, demoting this blocker is reasonable.
Proposal
What is the root cause of that problem?
The app reads the theme from two sources that update at different times:
App content waits 300ms. ThemeProvider passes the theme through useDebouncedState (ThemeProvider.tsx:19), so everything that uses useTheme() changes about 300ms after the switch.
The navigation theme changes right away. NavigationRoot builds its base theme from useThemePreference(), which isn't delayed (NavigationRoot.tsx:140, L194).
This mismatch was harmless until #101339. That PR moved the tab bar to createNativeBottomTabNavigator (TabNavigator.native.tsx:11). The native tab bar sets colorScheme={dark ? 'dark' : 'light'} from the navigation theme's dark flag. iOS applies that through overrideUserInterfaceStyle and repaints the liquid-glass bar right away. The old JS tab bar used the delayed useTheme() colors, so it changed together with the rest of the app.
What changes do you think we should make in order to solve the problem?
In NavigationRoot, choose the base navigation theme from the delayed theme that's already in scope (L141) instead of themePreference. Use theme.colorScheme (types.ts:154) to pick DarkTheme or DefaultTheme. Then drop themePreference from the useMemo dependencies (L210). The native bar then changes theme at the same time as the app.
What alternative solutions did you explore? (Optional)
Remove the debounce in ThemeProvider. This change is broader, so it carries more risk.
The tab bar icons and labels still use the delayed theme. So the bar's background changes about 300ms before its own icons and the page content, which matches the video.
The issue lists "Mac / Chrome" as the device, but this cause applies only to the native iOS bar. Wide desktop layouts and the mWeb bar use JS theming. The iOS: App checkbox and the title fit the cause, so the device field is probably a reporting mistake. Android's native bar may show the same bug, but I didn't verify that.
I didn't test this in the app.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/104259) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon Oct 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/93b96b6795bfed65622e006f6f55efd5d33b9e009d49260d4ac3a3ff88a329d6
melvin-bot commentedon Oct 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #101339
melvin-bot commentedon Oct 16, 2026
@grgia @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #101339
melvin-bot commentedon Oct 16, 2026
@sumo-slonik you have been assigned to this deploy blocker because you authored the offending PR: #101339
melvin-bot commentedon Oct 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 16, 2026
Deploy Blocker Investigation
Causing PR: Add liquid glass bottom tab bar to iOS, Android and mWeb. The auto-assignment is correct. Confidence: high.
Recommendation: Roll forward with a small fix. Don't revert. The PR is large (90+ files and several library patches) and already has a CP follow-up. The bug is cosmetic: about 300ms of theme mismatch when the user switches dark mode. If nobody can ship the fix quickly, demoting this blocker is reasonable.
Proposal
What is the root cause of that problem?
The app reads the theme from two sources that update at different times:
ThemeProviderpasses the theme throughuseDebouncedState(ThemeProvider.tsx:19), so everything that usesuseTheme()changes about 300ms after the switch.NavigationRootbuilds its base theme fromuseThemePreference(), which isn't delayed (NavigationRoot.tsx:140, L194).This mismatch was harmless until #101339. That PR moved the tab bar to
createNativeBottomTabNavigator(TabNavigator.native.tsx:11). The native tab bar setscolorScheme={dark ? 'dark' : 'light'}from the navigation theme'sdarkflag. iOS applies that throughoverrideUserInterfaceStyleand repaints the liquid-glass bar right away. The old JS tab bar used the delayeduseTheme()colors, so it changed together with the rest of the app.What changes do you think we should make in order to solve the problem?
In
NavigationRoot, choose the base navigation theme from the delayedthemethat's already in scope (L141) instead ofthemePreference. Usetheme.colorScheme(types.ts:154) to pickDarkThemeorDefaultTheme. Then dropthemePreferencefrom theuseMemodependencies (L210). The native bar then changes theme at the same time as the app.What alternative solutions did you explore? (Optional)
ThemeProvider. This change is broader, so it carries more risk.Investigation details
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/104259)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run