Repository navigation
[CP Staging] Fix liquid glass bottom tab bar issues - #104238
Conversation
|
|
|
@codex please review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-16.at.16.54.16.movScreen.Recording.2026-10-16.at.17.15.46.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@ZhenjaHorbach @daledah One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
…licate-inbox-tab [CP Staging] Fix liquid glass bottom tab bar issues (cherry picked from commit 5656cea) (cherry-picked to staging by grgia)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.5.13-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.5.14-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.14-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixing deploy blockers from #101339:
On Android, the native tab bar showed Inbox twice after submitting an expense. The pre-insert under the RHP gives the focused tab route a new key, and Android never removes the old native tab. A new bottom-tabs patch identifies native tabs by route name, so the tab stays and only its content remounts under the new key. Adds unit tests.
A react-native-screens patch (by @ZhenjaHorbach scales the hidden bar to zero, so its stale bounds stop swallowing taps on the chat composer's emoji and + buttons.
Fixed Issues
$ #104230
$ #104233
$ #104226
PROPOSAL: N/A
Tests
Duplicated Inbox tab:
Prerequisite: Account has a workspace.
Duplicated Workspaces tab:
Emoji picker and + button:
Error dismiss button:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
duplicated tabs:
Screen.Recording.2026-10-16.at.16.36.12.mov
emoji picker and + button:
Screen.Recording.2026-10-16.at.17.00.17.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari