You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Opening the intent=submit link not create submit workspace & land on Home #105574
Version Number: 9.5.27-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104916 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Android 17 / Pixel 7A/ Chrome App Component: Other
Action Performed:
Open Hybrid app
Create a new account
Finish Onboarding flow using Something else option
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Not a regression. I recommend you remove DeployBlockerCash and ask QA to retest. The tester clicked the link inside the running app. The intent=submit feature doesn't support that, by design.
A NewDot link clicked in chat navigates inside the app. The app doesn't reload. See Link.ts:406-416.
The intent is read only when the app starts. The hook's own comment says: "Links opened while the app is already running reach neither, so they are not supported." See useOnboardingDeeplinkIntent.ts:46-58.
With no intent detected, OnboardingGuard sends an onboarded user who opens /onboarding to Home. See OnboardingGuard.ts:273-278.
Recommended next step: Retest by opening the link fresh:
Web: paste https://staging.new.expensify.com/onboarding?intent=submit into a new browser tab.
Native: force-close the app, then open the link so it arrives as a cold launch.
If you want links clicked inside a running app to work, track that as a separate feature request.
Investigation details
Even when the hook sees the intent, hasAppliedIntent lives at module scope. The intent therefore applies at most once per app process. See ApplySubmitOnboardingIntent.tsx:16-18.
The original feature PR tests the link in three ways: as a direct web URL, as a magic link with exitTo, and as a native link after a force-close. Its Android steps target the standalone build, not HybridApp. The tester's steps (HybridApp, click the link in self-DM while the app is running) match none of these.
I did not run the app to reproduce this. The conclusion comes from the code and the PR test steps.
Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.
This isn't a regression from this PR. The link was tapped inside the app, and the intent=submit link doesn't work that way, with or without this PR.
The intent is only read when the app is opened with the link. The hook says so: "Links opened while the app is already running reach neither, so they are not supported" (useOnboardingDeeplinkIntent.ts#L49-L51).
A link tapped in a chat navigates inside the running app (Link.ts#L406-L416), so no intent is read, and an onboarded user who opens /onboarding is sent to Home (OnboardingGuard.ts#L273-L278).
I checked it on staging 9.5.27-0 with a new account (Something else, no workspace):
Link tapped in the self-DM: Home, no workspace, same as the report. Locally with this PR's changes reverted, the result is the same.
Link opened in the browser's address bar: the Submit workspace is created and you land on Spend > Expenses with the side panel closed.
Step 12 was tested by opening the link in the address bar, as in the MacOS video in the PR. I've updated step 12 and the QA steps in the PR to say that. To retest, paste https://staging.new.expensify.com/onboarding?intent=submit into the browser's address bar while signed in. On native, the link only applies when it opens the app from fully closed, as in the test steps of #98887.
Activity
melvin-bot commentedon Nov 1, 2026
@neil-marcellini recently merged #104916, but they are OOO right now, so I'll auto-assign someone else.
applause-bot commentedon Nov 1, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a534400b3ae86c7f207be0666a8ef6efea22a58538ab92b597a9e8d558665a61
melvin-bot commentedon Nov 1, 2026
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 1, 2026
@neil-marcellini @rojiphil you have been assigned to this deploy blocker because you reviewed the offending PR: #104916
melvin-bot commentedon Nov 1, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 1, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 1, 2026
Deploy Blocker Analysis
Not a regression. I recommend you remove
DeployBlockerCashand ask QA to retest. The tester clicked the link inside the running app. Theintent=submitfeature doesn't support that, by design.Causing PR: None (high confidence).
AuthScreens,Link.ts, or initial-URL handling.Why the user lands on Home:
OnboardingGuardsends an onboarded user who opens/onboardingto Home. See OnboardingGuard.ts:273-278.Recommended next step: Retest by opening the link fresh:
https://staging.new.expensify.com/onboarding?intent=submitinto a new browser tab.If you want links clicked inside a running app to work, track that as a separate feature request.
Investigation details
hasAppliedIntentlives at module scope. The intent therefore applies at most once per app process. See ApplySubmitOnboardingIntent.tsx:16-18.SubmitIntentDeeplinkHandlermounts once in AuthScreens.tsx:180. It returnsnullwhen no intent is present. See SubmitIntentDeeplinkHandler/index.tsx:15-17.exitTo, and as a native link after a force-close. Its Android steps target the standalone build, not HybridApp. The tester's steps (HybridApp, click the link in self-DM while the app is running) match none of these.Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.view run
laveshfonix commentedon Nov 1, 2026
This isn't a regression from this PR. The link was tapped inside the app, and the
intent=submitlink doesn't work that way, with or without this PR./onboardingis sent to Home (OnboardingGuard.ts#L273-L278).mainjust before this PR was merged.I checked it on staging 9.5.27-0 with a new account (Something else, no workspace):
Step 12 was tested by opening the link in the address bar, as in the MacOS video in the PR. I've updated step 12 and the QA steps in the PR to say that. To retest, paste
https://staging.new.expensify.com/onboarding?intent=submitinto the browser's address bar while signed in. On native, the link only applies when it opens the app from fully closed, as in the test steps of #98887.cc @MonilBhavsar @rojiphil
IuliiaHerets commentedon Nov 2, 2026
Pass in Web when copying and pasting the link into the browser.
Android: the link does not open the app when trying to cold start
az_recorder_20261102_153046.mp4
ScreenRecording_11-02-2026.15-42-32_1.MP4
IuliiaHerets commentedon Nov 2, 2026
The onboarding modal reappears on the Android app after a cold start. The same on the iOS app
ScreenRecording_11-02-2026.17-21-02_1.MP4
screen-20261102-171758-1793632662525.mp4
IuliiaHerets commentedon Nov 2, 2026
mWeb opens when navigating via a link
screen-20261102-175358-1793634825480.mp4
neil-marcellini commentedon Nov 2, 2026
Ok so the above proves that this also occurs on production. I don't think there's any real problem here.