Skip to content

Opening the intent=submit link not create submit workspace & land on Home #105574

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.27-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104916
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Android 17 / Pixel 7A/ Chrome
App Component: Other

Action Performed:

  1. Open Hybrid app
  2. Create a new account
  3. Finish Onboarding flow using Something else option
  4. Open Self-DM and send the link https://staging.new.expensify.com/onboarding?intent=submit
  5. Click on the sent link

Expected Result:

Verify a Submit workspace is created, you land on Spend > Expenses and the side panel doesn't open

Actual Result:

No Submit workspace is created, and you land on Home

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7301497_1793469379874.Submit_Ws.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7301497

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 1, 2026
  2. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    @neil-marcellini recently merged #104916, but they are OOO right now, so I'll auto-assign someone else.

  3. applause-bot commented on Nov 1, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/a534400b3ae86c7f207be0666a8ef6efea22a58538ab92b597a9e8d558665a61

  4. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    @neil-marcellini @rojiphil you have been assigned to this deploy blocker because you reviewed the offending PR: #104916

  6. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 1, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 1, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Not a regression. I recommend you remove DeployBlockerCash and ask QA to retest. The tester clicked the link inside the running app. The intent=submit feature doesn't support that, by design.

    Causing PR: None (high confidence).

    Why the user lands on Home:

    1. A NewDot link clicked in chat navigates inside the app. The app doesn't reload. See Link.ts:406-416.
    2. The intent is read only when the app starts. The hook's own comment says: "Links opened while the app is already running reach neither, so they are not supported." See useOnboardingDeeplinkIntent.ts:46-58.
    3. With no intent detected, OnboardingGuard sends an onboarded user who opens /onboarding to Home. See OnboardingGuard.ts:273-278.

    Recommended next step: Retest by opening the link fresh:

    • Web: paste https://staging.new.expensify.com/onboarding?intent=submit into a new browser tab.
    • Native: force-close the app, then open the link so it arrives as a cold launch.

    If you want links clicked inside a running app to work, track that as a separate feature request.

    Investigation details
    • Even when the hook sees the intent, hasAppliedIntent lives at module scope. The intent therefore applies at most once per app process. See ApplySubmitOnboardingIntent.tsx:16-18.
    • SubmitIntentDeeplinkHandler mounts once in AuthScreens.tsx:180. It returns null when no intent is present. See SubmitIntentDeeplinkHandler/index.tsx:15-17.
    • The original feature PR tests the link in three ways: as a direct web URL, as a magic link with exitTo, and as a native link after a force-close. Its Android steps target the standalone build, not HybridApp. The tester's steps (HybridApp, click the link in self-DM while the app is running) match none of these.
    • I did not run the app to reproduce this. The conclusion comes from the code and the PR test steps.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  9. laveshfonix commented on Nov 1, 2026

    @laveshfonix
    Contributor

    This isn't a regression from this PR. The link was tapped inside the app, and the intent=submit link doesn't work that way, with or without this PR.

    I checked it on staging 9.5.27-0 with a new account (Something else, no workspace):

    • Link tapped in the self-DM: Home, no workspace, same as the report. Locally with this PR's changes reverted, the result is the same.
    • Link opened in the browser's address bar: the Submit workspace is created and you land on Spend > Expenses with the side panel closed.
    Image Image

    Step 12 was tested by opening the link in the address bar, as in the MacOS video in the PR. I've updated step 12 and the QA steps in the PR to say that. To retest, paste https://staging.new.expensify.com/onboarding?intent=submit into the browser's address bar while signed in. On native, the link only applies when it opens the app from fully closed, as in the test steps of #98887.

    cc @MonilBhavsar @rojiphil

  10. IuliiaHerets commented on Nov 2, 2026

    @IuliiaHerets

    Pass in Web when copying and pasting the link into the browser.

    Android: the link does not open the app when trying to cold start

    az_recorder_20261102_153046.mp4
    ScreenRecording_11-02-2026.15-42-32_1.MP4
  11. IuliiaHerets commented on Nov 2, 2026

    @IuliiaHerets

    The onboarding modal reappears on the Android app after a cold start. The same on the iOS app

    ScreenRecording_11-02-2026.17-21-02_1.MP4
    screen-20261102-171758-1793632662525.mp4
  12. IuliiaHerets commented on Nov 2, 2026

    @IuliiaHerets

    mWeb opens when navigating via a link

    screen-20261102-175358-1793634825480.mp4
  13. neil-marcellini commented on Nov 2, 2026

    @neil-marcellini
    Contributor

    Ok so the above proves that this also occurs on production. I don't think there's any real problem here.

    Android: the link does not open the app when trying to cold start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions