Repository navigation
fix: keep the side panel closed after onboarding for every intent - #104916
neil-marcellini merged 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
@laveshfonix The issue OP states that panel should stay closed for every intent. Why then would we want to open the side panel as per step 13 in PR OP? |
|
@rojiphil Step 13 isn't an onboarding exit. The If you'd prefer the side panel closed for those two as well, it's a small change. Happy to make it if you and @neil-marcellini want that. |
@neil-marcellini what do you think? |
|
@laveshfonix @rojiphil Yes I think we should keep the side panel closed for that too. I think we want the same experience for new Employer users and existing Employer users that accept the modal. |
|
@neil-marcellini Sounds good. I'll update the PR so the side panel stays closed for both the Submit plan welcome modal and the intent=submit link, since they use the same flow. I'll also merge main to resolve the conflict, and push the update today. |
…-panel-all-intents # Conflicts: # src/hooks/useAutoCreateSubmitWorkspace.ts
…intent=submit link
|
Updated:
@rojiphil ready for another look. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp104916-android-hybrid-001.mp4Android: mWeb Chrome104916-mweb-chrome-001.mp4104916-mweb-chrome-002.mp4iOS: HybridApp104916-ios-hybrid-001.mp4iOS: mWeb Safari104916-mweb-safari-001.mp4MacOS: Chrome / Safari104916-web-chrome-001.mp4104916-web-chrome-002.mp4104916-web-chrome-003.mp4104916-web-chrome-004.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Thanks @laveshfonix for the PR.
@neil-marcellini Changes LGTM and works well too.
All yours now. Thanks.
neil-marcellini
left a comment
There was a problem hiding this comment.
Thanks for the updates, good to go from me.
|
(Neil's AI agent) The failing Knip check is not caused by this PR, so it's safe to merge with it failing. Why it failed: The job was a rerun on Oct 30 of a run created on Oct 27. A rerun reuses the original merge commit, so the PR side ran knip on Why it's unrelated: This PR doesn't touch either file. Merging main into the branch and pushing would make the check pass, but it isn't needed. |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@neil-marcellini looks like this was merged without a test passing. These checks had not passed on da1d1dd when it was merged:
Please add a note explaining why this was done and remove the |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.27-0 🚀
|
|
No help site update needed. No help article says the side panel or the Concierge chat opens after onboarding, and the Submit flows still land on Spend > Expenses, which matches the existing Submit Workspace article. |
|
Deploy Blocker #105574 was identified to be related to this PR. |
|
Removing the emergency label because of what I noted here. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
After onboarding, some exits opened the side panel automatically, so users were onboarded in two places at once: Getting started on Home, and a chat in the side panel.
handleRHPVariantNavigationopened it for Track users (trackExpensesWithConcierge) on wide screens, and for the retiredrhpHomePage,rhpAdminsRoomandrhpConciergeDmarms. On small screens, Track users were sent to the Concierge DM instead.navigateToSubmitWorkspaceAfterOnboardingopened it for Employer users, when auto-joining a Submit workspace, and for already-onboarded users who accept the Submit plan welcome modal or open theintent=submitlink.This PR stops these flows from opening the side panel:
useAutoCreateTrackWorkspacenow runs infinally, so a failedCompleteGuidedSetuprequest also gets it.inboxAdminsBespoke/homePageNoRHParms are unchanged.intent=submitlink: still land on Spend > Expenses, with the side panel closed, so new and existing Employer users get the same experience.rhpAdminsRoomis still stored, so admins who open the side panel later see #admins.Fixed Issues
$ #104027
PROPOSAL: #104027 (comment)
Tests
https://dev.new.expensify.com:8082/onboarding?intent=submitinto the browser's address bar. Don't tap it inside a chat: links opened while the app is running don't apply the intent (Add a one-click deeplink that signs the user in and creates a Submit workspace #98887)I ran steps 1-3 and 5-6 on all platforms, and the other steps and the offline test on MacOS Chrome.
Notes:
Opening the
intent=submitlink while logged out and signing up as a new user goes through onboarding and lands on Home, becauseLink.tsreplays the parked/onboardinglink. This is the same on main.Joining through the "Join my company workspace" step needs a private-domain account, so it's covered by the updated
WorkspaceOnboardingUI tests. The retired arms can't be assigned to new accounts, soRHPVariantTest.test.tscovers them. The Submit plan welcome modal is covered byuseAutoCreateSubmitWorkspace.test.ts.Ask to join or Skip with a retired arm at a micro company size can still reach
workspaces/undefined/overview, with the side panel closed. That's unchanged and left as the agreed follow-up.The console errors I saw aren't from this change.
RESETnot handled on sign-out also happens on main. The others, a wasm fetch and a nested-button warning on page load and React unknown-prop warnings at sign-in, appear before any onboarding code runs.Verify that no errors appear in the JS console
Offline tests
QA Steps
Same as tests, pasting
https://staging.new.expensify.com/onboarding?intent=submitinto the browser's address bar for step 12PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Not applicable: this PR changes no UI elements, copy, assets, markdown, Storybook stories or generic components.
Screenshots/Videos
Android: Native
6-android-native.mp4
Android: mWeb Chrome
5-android-mweb-chrome.mp4
iOS: Native
4-ios-native.mp4
iOS: mWeb Safari
3-ios-mweb-safari.mp4
MacOS: Chrome / Safari
1-mac-chrome-track-employer-manageteam.mp4
2-mac-chrome-invited-employee.mp4
7-mac-chrome-intent-submit.mov