You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-25] Merchant field cannot be saved when it is empty when rule can be created without merchant #105817
Version Number: 9.5.31-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104155 Email or phone of affected tester (no customers):jnosidjodsjojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Rules.
Click Add rule > Apply expense defaults.
Click Category under "If any expense matches", select any category and save it.
Enter any info under "Then apply the following defaults:" and create the rule.
→ Expense defaults rule can be created without matching expense.
Click Add rule > Apply expense defaults.
Click Merchant under "If any expense matches", select any merchant and save it.
Click Merchant again.
Clear the merchant field and save it.
Expected Result:
Merchant field can be saved when it is empty because matching merchant is no longer a requirement when creating expense default rules.
Actual Result:
Merchant field cannot be saved when it is empty when matching merchant is no longer a requirement when creating expense default rules.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Merchant field cannot be saved when it is empty when rule can be created without merchant[/-][+][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+]on Nov 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-11. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/-][+][Due for payment 2026-11-25] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+]on Nov 18, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.40-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-25. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 3, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d0a3b13fe99efc08d807df2ab766c0a92391f5e128e7ae123eaddbae99aeed9a
melvin-bot commentedon Nov 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104155
melvin-bot commentedon Nov 3, 2026
@luacmartins @JS00001 @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #104155
melvin-bot commentedon Nov 3, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #104155
melvin-bot commentedon Nov 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
7 remaining items
[-]Merchant field cannot be saved when it is empty when rule can be created without merchant[/-][+][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+]melvin-bot commentedon Nov 4, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-11. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Let the merchant be cleared once a rule can match on something else
jponikarchuk commentedon Nov 17, 2026
Deploy Blocker #107137 was identified to be related to the PR #105893 that attempted to fix this issue.
[-][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/-][+][Due for payment 2026-11-25] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+]melvin-bot commentedon Nov 18, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.40-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-25. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]