Skip to content

[Due for payment 2026-11-25] Merchant field cannot be saved when it is empty when rule can be created without merchant #105817

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.31-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104155
Email or phone of affected tester (no customers): jnosidjodsjojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Rules.
  3. Click Add rule > Apply expense defaults.
  4. Click Category under "If any expense matches", select any category and save it.
  5. Enter any info under "Then apply the following defaults:" and create the rule.
    → Expense defaults rule can be created without matching expense.
  6. Click Add rule > Apply expense defaults.
  7. Click Merchant under "If any expense matches", select any merchant and save it.
  8. Click Merchant again.
  9. Clear the merchant field and save it.

Expected Result:

Merchant field can be saved when it is empty because matching merchant is no longer a requirement when creating expense default rules.

Actual Result:

Merchant field cannot be saved when it is empty when matching merchant is no longer a requirement when creating expense default rules.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7304052_1793738631014.10.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7304052

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 3, 2026
  2. applause-bot commented on Nov 3, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d0a3b13fe99efc08d807df2ab766c0a92391f5e128e7ae123eaddbae99aeed9a

  3. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104155

  4. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    @luacmartins @JS00001 @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #104155

  5. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #104155

  6. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 7 remaining items

  9. added and removed
    ReviewingHas a PR in review
    on Nov 4, 2026
  10. changed the title [-]Merchant field cannot be saved when it is empty when rule can be created without merchant[/-] [+][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+] on Nov 4, 2026
  11. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @Krishna2323 / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-11. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  12. added
    ReviewingHas a PR in review
    and removed on Nov 5, 2026
  13. jponikarchuk commented on Nov 17, 2026

    @jponikarchuk

    Deploy Blocker #107137 was identified to be related to the PR #105893 that attempted to fix this issue.

  14. changed the title [-][Due for payment 2026-11-11] Merchant field cannot be saved when it is empty when rule can be created without merchant[/-] [+][Due for payment 2026-11-25] Merchant field cannot be saved when it is empty when rule can be created without merchant[/+] on Nov 18, 2026
  15. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    @Krishna2323 / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.40-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-25. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions