Skip to content

[Due for payment 2026-11-16] Account - Emoji is highlighted when hovered, but there is no status text and its end time #106217

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.33-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105891
Email or phone of affected tester (no customers): nsjiodoisnjiodsjnio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable flatNav beta.
  1. Go to staging.new.expensify.com
  2. Go to Account > Profile > Status.
  3. Create a status with emoji, text and end time.
  4. Hover over the emoji on Account row.

Expected Result:

Status text and its end time will be shown when hovered over emoji.

Actual Result:

Emoji is highlighted when hovered, but there is no status text and its end time.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7306785_1793968961708.6.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7306785

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 6, 2026
  2. applause-bot commented on Nov 6, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/534c7c24b04d0f3fa100556afcabcb27876c8aa41a09eedd2d3a3fd7330a4355

  3. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105891

  4. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    @mountiny @Krishna2323 you have been assigned to this deploy blocker because you reviewed the offending PR: #105891

  5. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    @sumo-slonik you have been assigned to this deploy blocker because you authored the offending PR: #105891

  6. github-actions commented on Nov 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Nov 6, 2026

    @MelvinBot
    Contributor

    Proposal

    Deploy-blocker finding: Flat navigation bar on wide behind the flatNav beta introduced this regression. Recommend fix-forward; keep the blocker until verified. Code/history confidence is high; browser behavior was not tested in this investigation.

    What is the root cause of that problem?

    The new Account status chip puts Hoverable directly inside Tooltip. The tooltip injects mouse handlers into its child, but Hoverable does not forward those handlers. Its own hover styling still works, explaining why the emoji highlights while neither the status text nor end time appears.

    Code and release evidence
    • The broken nesting was introduced in FlatNavAccountStatus.tsx:40–61.
    • BaseTooltip:100–124 installs the tooltip hover trigger. ActiveHoverable:17–18 does not accept the injected mouse handlers, while its own handlers still update the highlight.
    • The PR merged November 5 at 23:13 UTC and deployed to staging 9.5.33-0 before the report. The affected component is unchanged between that merge and staging. The staging deploy checklist includes the PR and this blocker.
    • Missing saved status data, date formatting, or tooltip positioning are not needed to explain the failure: the opening trigger is disconnected before tooltip content or positioning matters.

    What changes do you think we should make in order to solve the problem?

    Use a plain View as the tooltip's immediate child, retaining Hoverable inside it for highlighting. An isolated, one-file repair already exists: the status-tooltip fix commit, currently in the open follow-up PR. Extract that repair into a focused blocker fix rather than merging the follow-up's unrelated sidebar changes.

    Fix evidence, validation, and prevention
    • Corrected composition:40–64 allows tooltip mouse handlers to reach a host View while preserving the chip highlight.
    • Before clearing the blocker, verify on wide web with flatNav: emoji + text + future expiry displays text and end time on hover; moving away dismisses it; no-expiry/no-status cases and Account navigation remain correct. Confirm beta-off behavior is unchanged.
    • Add a hover-triggered tooltip regression test. Existing coverage:162–175 checks the chip/emoji, not tooltip interaction.
    • Suggested AI review rule: flag an App Hoverable used directly as a Tooltip child; require a host View target or a verified handler-forwarding composition. This is a mechanically detectable pattern, not a proposed standards change already applied.

    What alternative solutions did you explore? (Optional)

    Reverting the introducing PR is the fallback if the focused repair cannot be validated promptly. Fix-forward is preferable because the repair is isolated and avoids reverting the broader beta navigation implementation. No backend change is indicated.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/106217) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 6, 2026
  10. changed the title [-]Account - Emoji is highlighted when hovered, but there is no status text and its end time[/-] [+][Due for payment 2026-11-16] Account - Emoji is highlighted when hovered, but there is no status text and its end time[/+] on Nov 9, 2026
  11. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @Krishna2323

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-16. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  12. Krishna2323 commented on Nov 10, 2026

    @Krishna2323
    Contributor

    The PR is now in production, so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions