Repository navigation
[Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta - #105892
Conversation
…r colors and regular weight, behind the flatNav beta
…ed, beta read once per LHN list, test that beta off changes nothing
…htBG, hoist the menu item wrapper style, add the hook file header
…text color on hover, like the bar's labels
…over the LHN row backgrounds with the bar
e7eecda to
d2bd5af
Compare
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@Krishna2323 all yours! This is the sidebar part of #105351. It is stacked on R1.1a (#105891), so the diff also shows R1.1a's commits until that one merges. |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2bd5af214
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Feels good to me too. @dannymcclain were you thinking that tapping on the status emoji should navigate you directly to Settings with the status RHP opened up or anything like that? |
|
Oh, the status thing might be part of the other PR, if so, ignore me here! |
… is a plain View since Hoverable drops the mouse handlers Tooltip injects
Oh I hadn't thought of that, but I that's a good idea! So yeah, I'd probably say show the full status in a tooltip when you hover over the little status button (like we do in Inbox and stuff) and then if you click directly on the status button, take you to Account > Status RHP. (Collapsed state would always just take you to Account)
+1. If this is being handled elsewhere we can discuss it there! |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
The merge-base changed after approval.
|
This is off hold now @sumo-slonik @Krishna2323 can you please sync up with main and get the pr ready for a review |
| {!shouldRenderAsHTML && !shouldParseTitle && !!title && ( | ||
| <Text | ||
| style={combinedTitleTextStyle} | ||
| style={[combinedTitleTextStyle, isHovered && hoveredTitleStyle]} |
There was a problem hiding this comment.
The hoveredTitleStyle still applies when the item isn't interactive, but the hover background and icon color don't. So a non-interactive row (e.g. Workspace sidebar with a policy creation error) only changes its title color on hover and looks half hovered.
Monosnap.screencast.2026-11-07.05-07-21.mp4
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb_chrome.mp4 |
mountiny
left a comment
There was a problem hiding this comment.
Thank you for a quick review and breaking this up into two PRs.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR only restyles existing sidebars behind the |
|
No help site update needed — the visual changes remain behind the |
|
@mountiny @joekaufmanexpensify Can we QA this with Expensifail account or just check off? |
|
@mvtglobally hey, the QA steps seem clear to me. Can you let us know what is unclear? You'll need to go to the troubleshooting section to turn on the beta as described |
|
@mountiny QA steps section states "No QA. Everything is behind the flatNav beta, so nothing changes for anyone without the beta." While Test section has more clear steps. I wasn't sure if this is No QA or Testable PR and wanted to clarify |
|
@mvtglobally can you follow the |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
R1.1b, part two of Flat Nav R1.1. #105351 is split in two to keep each review small. Together the two PRs are the full R1.1.
Everything is behind the
flatNavbeta. With the beta on, the sidebars of the Inbox, Workspaces, Domains and Account tabs take the look of the flat navigation bar's rows, as design asked on #105351. The flat nav plan does not list this restyle for R1.1, it was added on design's request. The Spend column stays as it is, because R2.2 removes it:hoveredComponentBG, product300) and a hovered row uses the bar's hover background (highlightBG).How it is wired:
useFlatNavSidebarRowProps()returns a function that gives a row its overrides from its selected state. It reads the beta once per sidebar.getFlatNavSidebarRowProps()is the same logic as a pure function.MenuItemgets an optionalhoveredStyleandhoveredTitleStyle, and the LHN row'sPressablegets optionalselectedStyleandhoveredStyle. Each falls back to the current default when it is not passed.LHNOptionsListand passesshouldUseFlatNavigationBardown to its rows, so the rows do not each read it.Feedback from #105351 covered here: shawnborton asked for the sidebar rows to look almost identical to the main nav: product300 for the selected row, regular weight,
textSupportingfor rows that are not selected. mountiny asked for the restyle in its own PR, a test that the beta off case changes nothing, nouseFlatNavSidebarRowProps()(isFocused)double call, and one beta check per LHN list instead of one per row. The chat rows of the Inbox LHN only take the bar's backgrounds, not the text color, until design confirms they should.With the beta off nothing changes.
getFlatNavSidebarRowPropsreturns{}and every new prop falls back to its old default, so every sidebar renders as onmain. A unit test covers that case for selected and unselected rows.Fixed Issues
$ #105624
$ #106217
PROPOSAL: N/A
Tests
Beta on
Beta off
main: bold labels, the old selected and hover backgrounds.Offline tests
Same as tests while offline. Nothing here makes a request.
QA Steps
No QA. Everything is behind the
flatNavbeta, so nothing changes for anyone without the beta.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
To be added.
Android: mWeb Chrome
To be added.
iOS: Native
To be added.
iOS: mWeb Safari
To be added.
MacOS: Chrome / Safari
To be added.