Skip to content

[Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta - #105892

Merged
mountiny merged 8 commits into
Expensify:mainfrom
software-mansion-labs:feat/flat-nav-r1.1b-sidebars
Nov 7, 2026
Merged

mountiny merged 8 commits into
Expensify:mainfrom
software-mansion-labs:feat/flat-nav-r1.1b-sidebars

Conversation

@sumo-slonik

@sumo-slonik sumo-slonik commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

R1.1b, part two of Flat Nav R1.1. #105351 is split in two to keep each review small. Together the two PRs are the full R1.1.

Everything is behind the flatNav beta. With the beta on, the sidebars of the Inbox, Workspaces, Domains and Account tabs take the look of the flat navigation bar's rows, as design asked on #105351. The flat nav plan does not list this restyle for R1.1, it was added on design's request. The Spend column stays as it is, because R2.2 removes it:

  • The selected row uses the bar's selected background (hoveredComponentBG, product300) and a hovered row uses the bar's hover background (highlightBG).
  • Rows that are not selected use regular weight and the supporting text color, and turn to the default text color on hover, like the bar's labels. The selected row stays bold in the default text color.
  • Chat rows in the Inbox take only the backgrounds for now. Their text weight and color wait for design to confirm they should change too.

How it is wired:

  • useFlatNavSidebarRowProps() returns a function that gives a row its overrides from its selected state. It reads the beta once per sidebar. getFlatNavSidebarRowProps() is the same logic as a pure function.
  • MenuItem gets an optional hoveredStyle and hoveredTitleStyle, and the LHN row's Pressable gets optional selectedStyle and hoveredStyle. Each falls back to the current default when it is not passed.
  • The LHN list reads the beta once in LHNOptionsList and passes shouldUseFlatNavigationBar down to its rows, so the rows do not each read it.

Feedback from #105351 covered here: shawnborton asked for the sidebar rows to look almost identical to the main nav: product300 for the selected row, regular weight, textSupporting for rows that are not selected. mountiny asked for the restyle in its own PR, a test that the beta off case changes nothing, no useFlatNavSidebarRowProps()(isFocused) double call, and one beta check per LHN list instead of one per row. The chat rows of the Inbox LHN only take the bar's backgrounds, not the text color, until design confirms they should.

With the beta off nothing changes. getFlatNavSidebarRowProps returns {} and every new prop falls back to its old default, so every sidebar renders as on main. A unit test covers that case for selected and unselected rows.

Fixed Issues

$ #105624
$ #106217
PROPOSAL: N/A

Tests

Beta on

  1. Open the app on a wide web window. In Test Tools, open Beta overrides and switch flatNav on.
  2. Open Account. Verify the selected row (e.g. Profile) has the same background as the selected row of the left bar and a bold label, and every other row has a regular weight label in the supporting (grey) color.
  3. Hover a row that is not selected and verify it gets the left bar's hover background and its label turns to the default text color.
  4. Repeat steps 2 and 3 in Workspaces (inside a workspace) and Domains (inside a domain, if you have one).
  5. Open Inbox. Verify the open chat's row has the left bar's selected background and a hovered row has the left bar's hover background, and that the avatar's background follows the row.

Beta off

  1. Switch flatNav off in Beta overrides.
  2. Verify the sidebars of Inbox, Spend, Workspaces, Domains and Account look exactly as on main: bold labels, the old selected and hover backgrounds.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests while offline. Nothing here makes a request.

QA Steps

No QA. Everything is behind the flatNav beta, so nothing changes for anyone without the beta.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

To be added.

Android: mWeb Chrome

To be added.

iOS: Native

To be added.

iOS: mWeb Safari

To be added.

MacOS: Chrome / Safari

To be added.

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/LHNOptionsList/LHNOptionsList.tsx 78.94% <100.00%> (+0.56%) ⬆️
...HNOptionsList/OptionRowLHN/OptionRow/Pressable.tsx 91.17% <100.00%> (+0.13%) ⬆️
...nents/LHNOptionsList/OptionRowLHN/OptionRowLHN.tsx 100.00% <100.00%> (ø)
...HNOptionsList/OptionRowLHN/OptionRowLHNContent.tsx 92.85% <ø> (ø)
.../LHNOptionsList/OptionRowLHN/useOptionRowChrome.ts 100.00% <100.00%> (ø)
...igation/FlatNavigationBar/FlatNavAccountStatus.tsx 100.00% <100.00%> (ø)
...ion/FlatNavigationBar/useFlatNavSidebarRowProps.ts 100.00% <100.00%> (ø)
src/pages/settings/InitialSettingsPage.tsx 85.71% <100.00%> (+0.29%) ⬆️
src/pages/settings/SettingsMenuItem.tsx 82.50% <100.00%> (+2.50%) ⬆️
src/pages/workspace/WorkspaceInitialPage.tsx 84.39% <100.00%> (-0.71%) ⬇️
... and 2 more
... and 17 files with indirect coverage changes

@sumo-slonik
sumo-slonik force-pushed the feat/flat-nav-r1.1b-sidebars branch from e7eecda to d2bd5af Compare November 4, 2026 13:26
@sumo-slonik sumo-slonik changed the title [Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta [HOLD #105891] [Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta Nov 4, 2026
@sumo-slonik
sumo-slonik marked this pull request as ready for review November 5, 2026 09:26
@sumo-slonik
sumo-slonik requested review from a team as code owners November 5, 2026 09:26
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and removed request for a team November 5, 2026 09:26
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 5, 2026 09:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T10:00:36.219467Z d2bd5af Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sumo-slonik

Copy link
Copy Markdown
Contributor Author

@Krishna2323 all yours! This is the sidebar part of #105351. It is stacked on R1.1a (#105891), so the diff also shows R1.1a's commits until that one merges.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2bd5af214

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@shawnborton

Copy link
Copy Markdown
Contributor

Feels good to me too. @dannymcclain were you thinking that tapping on the status emoji should navigate you directly to Settings with the status RHP opened up or anything like that?

@shawnborton

Copy link
Copy Markdown
Contributor

Oh, the status thing might be part of the other PR, if so, ignore me here!

@shawnborton

Copy link
Copy Markdown
Contributor

Nav menu colors look good to me though:
CleanShot 2026-11-05 at 12 04 03 PM@2x

… is a plain View since Hoverable drops the mouse handlers Tooltip injects
@dannymcclain

Copy link
Copy Markdown
Contributor

@dannymcclain were you thinking that tapping on the status emoji should navigate you directly to Settings with the status RHP opened up or anything like that?

Oh I hadn't thought of that, but I that's a good idea! So yeah, I'd probably say show the full status in a tooltip when you hover over the little status button (like we do in Inbox and stuff) and then if you click directly on the status button, take you to Account > Status RHP. (Collapsed state would always just take you to Account)

Oh, the status thing might be part of the other PR, if so, ignore me here!

+1. If this is being handled elsewhere we can discuss it there!

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@sumo-slonik
sumo-slonik dismissed joekaufmanexpensify’s stale review November 5, 2026 23:14

The merge-base changed after approval.

@mountiny mountiny changed the title [HOLD #105891] [Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta [Flat Nav R1.1b] Tab sidebars take the flat navigation bar's look behind the flatNav beta Nov 5, 2026
@mountiny

mountiny commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This is off hold now @sumo-slonik @Krishna2323 can you please sync up with main and get the pr ready for a review

{!shouldRenderAsHTML && !shouldParseTitle && !!title && (
<Text
style={combinedTitleTextStyle}
style={[combinedTitleTextStyle, isHovered && hoveredTitleStyle]}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hoveredTitleStyle still applies when the item isn't interactive, but the hover background and icon color don't. So a non-interactive row (e.g. Workspace sidebar with a policy creation error) only changes its title color on hover and looks half hovered.

Monosnap.screencast.2026-11-07.05-07-21.mp4

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from mountiny November 6, 2026 23:48

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick review and breaking this up into two PRs.

@mountiny
mountiny merged commit 75ad1ff into Expensify:main Nov 7, 2026
39 of 43 checks passed
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only restyles existing sidebars behind the flatNav beta and fixes an existing status tooltip, without adding new functionality or screens.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — the visual changes remain behind the flatNav beta, and the tooltip fix restores expected behavior without changing any documented workflow.


view run

@mvtglobally

Copy link
Copy Markdown

@mountiny @joekaufmanexpensify Can we QA this with Expensifail account or just check off?
And can you please clarify QA steps if we are able to QA

@mountiny

mountiny commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

@mvtglobally hey, the QA steps seem clear to me. Can you let us know what is unclear? You'll need to go to the troubleshooting section to turn on the beta as described

@mvtglobally

Copy link
Copy Markdown

@mountiny QA steps section states

"No QA. Everything is behind the flatNav beta, so nothing changes for anyone without the beta."

While Test section has more clear steps. I wasn't sure if this is No QA or Testable PR and wanted to clarify

@mountiny

mountiny commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

@mvtglobally can you follow the Test section please? that should have been linked in QA steps. Sorry for the confusion 🙇

@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants