You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iPhone Duo - Subscription - Scroll bar overlaps with page content #106386
Version Number: 9.5.34-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104988 Email or phone of affected tester (no customers):jnosidjodsjojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone Duo / iOS 27.2 App Component: User Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Causing PR: unconfirmed. Recommendation: do not revert based on automated attribution alone.
The deploy-blocker-investigator found that chore: update macos runners to xcode 27 changes build tooling—not subscription layout. Its Xcode upgrade could affect native rendering, but no controlled before/after reproduction establishes causation.
Supporting evidence
The affected comparison modal and shared ScrollView are byte-identical between staging and production. The issue’s “new feature” description therefore needs clarification.
The shared ScrollView already contains a workaround for intermittent iOS transition-related scrollbar misplacement. An existing inset/transition problem exposed by this device is another plausible explanation.
DeployBlockerCash has already been removed. No labels or code were changed during this investigation.
Recommended resolution
Reproduce repeatedly on the same Duo, recording orientation/device posture and whether cold launch versus reopening changes the result. Then compare compatible native builds before and after the toolchain upgrade while holding JavaScript and device state constant.
Until that comparison establishes the trigger, neither a toolchain revert nor a speculative scrollbar-padding fix is justified. Attribution to the toolchain PR remains low confidence.
Please re-state the problem that we are trying to solve in this issue.
On an iPhone Duo (iOS 27.2), navigating to Account -> Subscription -> Explore all plans (ComparePlansModal) and scrolling down causes the vertical scroll bar indicator to overlap with the plan comparison card content instead of sitting in the outer right margin of the modal.
What is the root cause of that problem?
There are two interacting causes in src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx and src/components/ScrollView.tsx:
ScrollView.tsx hardcodes scrollIndicatorInsets={scrollIndicatorInsets ?? {right: Number.MIN_VALUE}} without accounting for horizontal safe-area / foldable split-screen insets or tight inner horizontal padding (src/components/ScrollView.tsx:28-39):
{right: Number.MIN_VALUE} pins the iOS native UIScrollView vertical scroll indicator flush against the right edge of the ScrollView frame (0pt inset).
ComparePlansModal.tsx sizes its modal container and inner horizontal padding purely from isSmallScreenWidth (src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:31-76):
On an iPhone Duo (or when the viewport is in narrow/folded/split width where isSmallScreenWidth is true, or in CENTERED_SMALL where two SubscriptionPlanCard columns sit side by side in styles.flexRow), the <ScrollView> stretches edge-to-edge inside the modal container while renderPlans() places the SubscriptionPlanCard border right up against the ph4 (16px) / workspaceSection boundary.
Because ComparePlansModal only applies safeAreaPaddingBottomStyle from <SafeAreaConsumer> to innerContainerStyle (line 62) and does not apply horizontal safe-area insets or reserve right indicator clearance on <ScrollView>, iOS 27.2 draws the native UIScrollView scroll bar (scrollIndicatorInsets={{right: Number.MIN_VALUE}}) directly over the right border/content of the SubscriptionPlanCard.
What changes do you think we should make in order to solve the problem?
In src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:54-76, include horizontal safe area padding (paddingLeft / paddingRight from SafeAreaConsumer or useSafeAreaPaddings) on the modal content container, or pass an explicit scrollIndicatorInsets={{right: 1}} with matching right container padding / margin on <ScrollView> so the iOS scroll indicator is positioned outside the SubscriptionPlanCard border and never overlaps the card content.
What alternative solutions did you explore? (Optional)
Increasing styles.ph4 globally was ruled out because it would shrink card widths across unrelated screens; scoping the horizontal safe-area / indicator inset adjustment to ComparePlansModal keeps the fix isolated.
Activity
applause-bot commentedon Nov 9, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2085e5cd8ab4c3b23c555bf798c2d7e4f26bffb7431199558af344c10aa1fb91
https://platform.applause.com/services/links/v1/external/263eaccc44d0533c2832a044d629b198aac4d2032dbd3092eb3235f2e82d4c1a
melvin-bot commentedon Nov 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104988
melvin-bot commentedon Nov 9, 2026
@lakchote you have been assigned to this deploy blocker because you reviewed the offending PR: #104988
melvin-bot commentedon Nov 9, 2026
@war-in you have been assigned to this deploy blocker because you authored the offending PR: #104988
melvin-bot commentedon Nov 9, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Nov 9, 2026
We couldn’t reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.
MelvinBot commentedon Nov 9, 2026
Investigation result
Causing PR: unconfirmed. Recommendation: do not revert based on automated attribution alone.
The
deploy-blocker-investigatorfound that chore: update macos runners to xcode 27 changes build tooling—not subscription layout. Its Xcode upgrade could affect native rendering, but no controlled before/after reproduction establishes causation.Supporting evidence
DeployBlockerCashhas already been removed. No labels or code were changed during this investigation.Recommended resolution
Reproduce repeatedly on the same Duo, recording orientation/device posture and whether cold launch versus reopening changes the result. Then compare compatible native builds before and after the toolchain upgrade while holding JavaScript and device state constant.
Until that comparison establishes the trigger, neither a toolchain revert nor a speculative scrollbar-padding fix is justified. Attribution to the toolchain PR remains low confidence.
view run
cocvn157 commentedon Nov 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On an iPhone Duo (iOS 27.2), navigating to Account -> Subscription -> Explore all plans (
ComparePlansModal) and scrolling down causes the vertical scroll bar indicator to overlap with the plan comparison card content instead of sitting in the outer right margin of the modal.What is the root cause of that problem?
There are two interacting causes in
src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsxandsrc/components/ScrollView.tsx:ScrollView.tsxhardcodesscrollIndicatorInsets={scrollIndicatorInsets ?? {right: Number.MIN_VALUE}}without accounting for horizontal safe-area / foldable split-screen insets or tight inner horizontal padding (src/components/ScrollView.tsx:28-39):{right: Number.MIN_VALUE}pins the iOS nativeUIScrollViewvertical scroll indicator flush against the right edge of theScrollViewframe (0ptinset).ComparePlansModal.tsxsizes its modal container and inner horizontal padding purely fromisSmallScreenWidth(src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:31-76):isSmallScreenWidthistrue, or inCENTERED_SMALLwhere twoSubscriptionPlanCardcolumns sit side by side instyles.flexRow), the<ScrollView>stretches edge-to-edge inside the modal container whilerenderPlans()places theSubscriptionPlanCardborder right up against theph4(16px) /workspaceSectionboundary.ComparePlansModalonly appliessafeAreaPaddingBottomStylefrom<SafeAreaConsumer>toinnerContainerStyle(line 62) and does not apply horizontal safe-area insets or reserve right indicator clearance on<ScrollView>, iOS 27.2 draws the nativeUIScrollViewscroll bar (scrollIndicatorInsets={{right: Number.MIN_VALUE}}) directly over the right border/content of theSubscriptionPlanCard.What changes do you think we should make in order to solve the problem?
ComparePlansModal.tsx:src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:54-76, include horizontal safe area padding (paddingLeft/paddingRightfromSafeAreaConsumeroruseSafeAreaPaddings) on the modal content container, or pass an explicitscrollIndicatorInsets={{right: 1}}with matching right container padding / margin on<ScrollView>so the iOS scroll indicator is positioned outside theSubscriptionPlanCardborder and never overlaps the card content.What alternative solutions did you explore? (Optional)
styles.ph4globally was ruled out because it would shrink card widths across unrelated screens; scoping the horizontal safe-area / indicator inset adjustment toComparePlansModalkeeps the fix isolated.lakchote commentedon Nov 16, 2026
Not overdue.
lakchote commentedon Nov 17, 2026
@war-in can you take a look? Melvin linked this to your PR #104988, and there's a proposal above waiting for review.
lakchote commentedon Nov 18, 2026
Not overdue. #104730 added iPhone Duo support and war-in is going through these now, so I'm moving this to Weekly.