Skip to content

iPhone Duo - Subscription - Scroll bar overlaps with page content #106386

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.34-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104988
Email or phone of affected tester (no customers): jnosidjodsjojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone Duo / iOS 27.2
App Component: User Settings

Action Performed:

Precondition:

  • Have at least one workspace.
  1. Launch Expensify app.
  2. Go to Account > Subscription.
  3. Tap Explore all plans.
  4. Scroll down the page.

Expected Result:

Scroll bar will not overlap with page content.

Actual Result:

Scroll bar overlaps with page content.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image
Bug7309149_1794237195817.ScreenRecording_11-09-2026_23-06-34_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7309149

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 9, 2026
  2. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104988

  3. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @lakchote you have been assigned to this deploy blocker because you reviewed the offending PR: #104988

  4. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @war-in you have been assigned to this deploy blocker because you authored the offending PR: #104988

  5. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. lanitochka17 commented on Nov 9, 2026

    @lanitochka17

    We couldn’t reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.

  8. MelvinBot commented on Nov 9, 2026

    @MelvinBot
    Contributor

    Investigation result

    Causing PR: unconfirmed. Recommendation: do not revert based on automated attribution alone.

    The deploy-blocker-investigator found that chore: update macos runners to xcode 27 changes build tooling—not subscription layout. Its Xcode upgrade could affect native rendering, but no controlled before/after reproduction establishes causation.

    Supporting evidence

    • The affected comparison modal and shared ScrollView are byte-identical between staging and production. The issue’s “new feature” description therefore needs clarification.
    • The shared ScrollView already contains a workaround for intermittent iOS transition-related scrollbar misplacement. An existing inset/transition problem exposed by this device is another plausible explanation.
    • QA could not reproduce it a second time. Native iOS behavior remains unverified; web testing would not establish an SDK-dependent UIKit regression.
    • DeployBlockerCash has already been removed. No labels or code were changed during this investigation.

    Recommended resolution

    Reproduce repeatedly on the same Duo, recording orientation/device posture and whether cold launch versus reopening changes the result. Then compare compatible native builds before and after the toolchain upgrade while holding JavaScript and device state constant.

    Until that comparison establishes the trigger, neither a toolchain revert nor a speculative scrollbar-padding fix is justified. Attribution to the toolchain PR remains low confidence.


    view run

  9. added and removed on Nov 9, 2026
  10. cocvn157 commented on Nov 15, 2026

    @cocvn157

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On an iPhone Duo (iOS 27.2), navigating to Account -> Subscription -> Explore all plans (ComparePlansModal) and scrolling down causes the vertical scroll bar indicator to overlap with the plan comparison card content instead of sitting in the outer right margin of the modal.

    What is the root cause of that problem?

    There are two interacting causes in src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx and src/components/ScrollView.tsx:

    1. ScrollView.tsx hardcodes scrollIndicatorInsets={scrollIndicatorInsets ?? {right: Number.MIN_VALUE}} without accounting for horizontal safe-area / foldable split-screen insets or tight inner horizontal padding (src/components/ScrollView.tsx:28-39):

      <RNScrollView
          ref={ref}
          contentContainerStyle={contentContainerStyle}
          scrollIndicatorInsets={scrollIndicatorInsets ?? {right: Number.MIN_VALUE}}
          {...props}
      >
          {children}
      </RNScrollView>

      {right: Number.MIN_VALUE} pins the iOS native UIScrollView vertical scroll indicator flush against the right edge of the ScrollView frame (0pt inset).

    2. ComparePlansModal.tsx sizes its modal container and inner horizontal padding purely from isSmallScreenWidth (src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:31-76):

      const renderPlans = () => (
          <View style={isSmallScreenWidth ? [styles.ph4, styles.pb8] : [styles.ph8, styles.pb8]}>
              ...
              <View style={isSmallScreenWidth ? styles.flexColumn : [styles.flexRow, styles.gap3]}>
                  <SubscriptionPlanCard ... />
                  <SubscriptionPlanCard ... />
              </View>
          </View>
      );
      • On an iPhone Duo (or when the viewport is in narrow/folded/split width where isSmallScreenWidth is true, or in CENTERED_SMALL where two SubscriptionPlanCard columns sit side by side in styles.flexRow), the <ScrollView> stretches edge-to-edge inside the modal container while renderPlans() places the SubscriptionPlanCard border right up against the ph4 (16px) / workspaceSection boundary.
      • Because ComparePlansModal only applies safeAreaPaddingBottomStyle from <SafeAreaConsumer> to innerContainerStyle (line 62) and does not apply horizontal safe-area insets or reserve right indicator clearance on <ScrollView>, iOS 27.2 draws the native UIScrollView scroll bar (scrollIndicatorInsets={{right: Number.MIN_VALUE}}) directly over the right border/content of the SubscriptionPlanCard.

    What changes do you think we should make in order to solve the problem?

    1. Apply proper scroll indicator insets / horizontal safe-area padding in ComparePlansModal.tsx:
      • In src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx:54-76, include horizontal safe area padding (paddingLeft / paddingRight from SafeAreaConsumer or useSafeAreaPaddings) on the modal content container, or pass an explicit scrollIndicatorInsets={{right: 1}} with matching right container padding / margin on <ScrollView> so the iOS scroll indicator is positioned outside the SubscriptionPlanCard border and never overlaps the card content.

    What alternative solutions did you explore? (Optional)

    • Increasing styles.ph4 globally was ruled out because it would shrink card widths across unrelated screens; scoping the horizontal safe-area / indicator inset adjustment to ComparePlansModal keeps the fix isolated.
  11. lakchote commented on Nov 16, 2026

    @lakchote
    Contributor

    Not overdue.

  12. lakchote commented on Nov 17, 2026

    @lakchote
    Contributor

    @war-in can you take a look? Melvin linked this to your PR #104988, and there's a proposal above waiting for review.

  13. lakchote commented on Nov 18, 2026

    @lakchote
    Contributor

    Not overdue. #104730 added iPhone Duo support and war-in is going through these now, so I'm moving this to Weekly.

  14. added and removed on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions