Repository navigation
fix: add iPhone Duo support - #104730
fix: add iPhone Duo support#104730mountiny merged 39 commits into
Conversation
|
@codex review |
1 similar comment
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
ReviewI found no blocking issues. There are two things to fix or verify on an iOS device, plus one small behavior change. 1. The tab bar shape is misread on mount. It flashes as a column on every iPhone. 2. Removing the global 3. Minor behavior change: iOS centered modals in landscape. The
The dim itself still covers the full window, and Android already behaved this way. This is probably fine, but please confirm it's intended. Checked and OK
|
|
My review above already covers the latest commit ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7d7aef67a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@MelvinBot review |
Review (
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06798f29e0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR fixes device-specific navigation layout and safe-area handling without adding a new workflow or changing the steps users follow. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
On the folded iPhone Duo, iOS puts the tab bar in a column in the right safe area. The app root no longer pads the horizontal safe area; each root screen pads itself (
HorizontalSafeAreainscreenLayoutWrapper), and on iOS the tab host spans the window so the bar sits in the inset. Also fixes FAB position, landscape keyboard dismiss and scroll indicator offset.Fixed Issues
$ #102090
PROPOSAL:
Tests
On the iPhone Duo simulator (folded), open the app on the Workspaces tab
Verify that the tab bar is a column of icons in the right inset below the status bar, and the content uses the full width left of it
Verify that the camera and
+floating buttons sit inside the content, not over the tab barUnfold the device (open posture) and verify the same layout in landscape: tab column in the right inset, content not under it
On the iPhone Duo simulator (folded), open a chat and tap its header to open the Details RHP
Scroll the page
Verify that the scroll indicator is at the right edge of the content, not ~84pt to the left of it
Go to Account settings (avatar) and verify the same for its scroll indicator
On an iPhone with a notch, rotate to landscape and open a chat
Focus the composer so the keyboard shows, then tap the side safe area left of the content
Verify that the keyboard is dismissed
Hide the keyboard and tap a tab bar item in the inset; verify that the tab changes
On Android (3-button navigation), rotate to landscape and verify content is not covered by the navigation bar or camera cutout
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari