You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-25] iPhone Duo - Form page shows narrow width in portrait mode #107221
Version Number: 9.5.41-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104730 Email or phone of affected tester (no customers):joinsdjosjdojosijdiosnj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone Duo / iOS 27.2 App Component: User Settings
Action Performed:
Launch Expensify app.
Go to Account > Display name.
Expected Result:
Form page will not show narrow width in portrait mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Causing PR:fix: add iPhone Duo support. High confidence from code and release evidence; not independently reproduced on iOS.
What is the root cause of that problem?
The new safe-area handling adds horizontal padding inside form scroll views without expanding their fixed width. This effectively subtracts the horizontal safe-area insets twice, making the fields narrower.
useHorizontalSafeAreaBleed.ts:47–75 adds negative outer margins and compensating inner padding, but preserves that explicit width. Negative margins therefore move the view rather than expand it.
The condition checks horizontal insets and narrow layout—not orientation—so portrait is affected when the Duo reports side insets.
A premerge review independently identified this exact sizing conflict and named Display name as an affected screen. That review was also based on static analysis, not device testing.
What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward: make the active bleed style override the inherited fixed width with width: 'auto', allowing the scroll view to expand into its negative margins. This shared correction also covers affected callers outside forms.
This correction remains proposed, not tested. Before removing DeployBlockerCash, verify folded-Duo portrait Display name, rotation/unfolding, ordinary iPhone landscape, sticky-submit forms, and zero-inset layouts.
Remove w100 only from forms: narrower scope, but leaves other fixed-width callers exposed.
Revert the PR: a fallback if the targeted correction cannot be validated promptly; it also removes broader Duo navigation and safe-area improvements.
Page-specific or backend defect: less consistent with a geometric regression in shared layout code and the premerge finding naming this page.
Suggested AI code-review safeguard
Flag shared layout transformations that combine negative horizontal margins with compensating padding while preserving callers’ explicit widths. Search for marginLeft, marginRight, paddingLeft, and paddingRight, then trace callers supplying styles.w100 or width.
The offending transformation provides a concrete example. Finalize the rule after validating the proposed correction.
Next Steps for Contributor+ team: To accept:@MelvinBot implement with a link to this proposal to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]iPhone Duo - Form page shows narrow width in portrait mode[/-][+][Due for payment 2026-11-25] iPhone Duo - Form page shows narrow width in portrait mode[/+]on Nov 18, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.41-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-25. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2940c67d6550860904795bb18d4bd43dc9cc1500ece9f0c7e8445ddba11a75ed
expensify-chore-bot commentedon Nov 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104730
expensify-chore-bot commentedon Nov 18, 2026
@mountiny @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #104730
expensify-chore-bot commentedon Nov 18, 2026
@war-in you have been assigned to this deploy blocker because you authored the offending PR: #104730
expensify-chore-bot commentedon Nov 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jponikarchuk commentedon Nov 18, 2026
We couldn't reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.
MelvinBot commentedon Nov 18, 2026
Proposal
Causing PR: fix: add iPhone Duo support. High confidence from code and release evidence; not independently reproduced on iOS.
What is the root cause of that problem?
The new safe-area handling adds horizontal padding inside form scroll views without expanding their fixed width. This effectively subtracts the horizontal safe-area insets twice, making the fields narrower.
Code and release evidence
styles.w100.What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward: make the active bleed style override the inherited fixed width with
width: 'auto', allowing the scroll view to expand into its negative margins. This shared correction also covers affected callers outside forms.This correction remains proposed, not tested. Before removing
DeployBlockerCash, verify folded-Duo portrait Display name, rotation/unfolding, ordinary iPhone landscape, sticky-submit forms, and zero-inset layouts.No UI testing was performed. Web testing alone cannot establish this native behavior: the web safe-area wrapper is a no-op.
What alternative solutions did you explore?
w100only from forms: narrower scope, but leaves other fixed-width callers exposed.Suggested AI code-review safeguard
Flag shared layout transformations that combine negative horizontal margins with compensating padding while preserving callers’ explicit widths. Search for
marginLeft,marginRight,paddingLeft, andpaddingRight, then trace callers supplyingstyles.w100orwidth.The offending transformation provides a concrete example. Finalize the rule after validating the proposed correction.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implementwith a link to this proposal to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
[-]iPhone Duo - Form page shows narrow width in portrait mode[/-][+][Due for payment 2026-11-25] iPhone Duo - Form page shows narrow width in portrait mode[/+]melvin-bot commentedon Nov 18, 2026
@truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.41-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-25. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]