Skip to content

[Due for payment 2026-11-25] iPhone Duo - Form page shows narrow width in portrait mode #107221

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.41-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104730
Email or phone of affected tester (no customers): joinsdjosjdojosijdiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone Duo / iOS 27.2
App Component: User Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to Account > Display name.

Expected Result:

Form page will not show narrow width in portrait mode.

Actual Result:

Form page shows narrow width in portrait mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7317314_1794974261137.ScreenRecording_11-18-2026_11-56-15_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7317314

Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. applause-bot commented on Nov 18, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/2940c67d6550860904795bb18d4bd43dc9cc1500ece9f0c7e8445ddba11a75ed

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 18, 2026
  3. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104730

  4. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    @mountiny @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #104730

  5. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    @war-in you have been assigned to this deploy blocker because you authored the offending PR: #104730

  6. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 18, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. jponikarchuk commented on Nov 18, 2026

    @jponikarchuk

    We couldn't reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.

  9. MelvinBot commented on Nov 18, 2026

    @MelvinBot
    Contributor

    Proposal

    Causing PR: fix: add iPhone Duo support. High confidence from code and release evidence; not independently reproduced on iOS.

    What is the root cause of that problem?

    The new safe-area handling adds horizontal padding inside form scroll views without expanding their fixed width. This effectively subtracts the horizontal safe-area insets twice, making the fields narrower.

    Code and release evidence
    • FormWrapper.tsx:274–305 gives both form scroll-view branches styles.w100.
    • useHorizontalSafeAreaBleed.ts:47–75 adds negative outer margins and compensating inner padding, but preserves that explicit width. Negative margins therefore move the view rather than expand it.
    • The condition checks horizontal insets and narrow layout—not orientation—so portrait is affected when the Duo reports side insets.
    • A premerge review independently identified this exact sizing conflict and named Display name as an affected screen. That review was also based on static analysis, not device testing.
    • The PR appears in the 9.5.41 staging checklist, and its deployment confirmation places it in the reported staging version, 9.5.41-0.

    What changes do you think we should make in order to solve the problem?

    Prefer a targeted roll-forward: make the active bleed style override the inherited fixed width with width: 'auto', allowing the scroll view to expand into its negative margins. This shared correction also covers affected callers outside forms.

    This correction remains proposed, not tested. Before removing DeployBlockerCash, verify folded-Duo portrait Display name, rotation/unfolding, ordinary iPhone landscape, sticky-submit forms, and zero-inset layouts.

    No UI testing was performed. Web testing alone cannot establish this native behavior: the web safe-area wrapper is a no-op.

    What alternative solutions did you explore?

    • Remove w100 only from forms: narrower scope, but leaves other fixed-width callers exposed.
    • Revert the PR: a fallback if the targeted correction cannot be validated promptly; it also removes broader Duo navigation and safe-area improvements.
    • Page-specific or backend defect: less consistent with a geometric regression in shared layout code and the premerge finding naming this page.
    Suggested AI code-review safeguard

    Flag shared layout transformations that combine negative horizontal margins with compensating padding while preserving callers’ explicit widths. Search for marginLeft, marginRight, paddingLeft, and paddingRight, then trace callers supplying styles.w100 or width.

    The offending transformation provides a concrete example. Finalize the rule after validating the proposed correction.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement with a link to this proposal to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 18, 2026
  11. changed the title [-]iPhone Duo - Form page shows narrow width in portrait mode[/-] [+][Due for payment 2026-11-25] iPhone Duo - Form page shows narrow width in portrait mode[/+] on Nov 18, 2026
  12. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.41-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-25. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions