You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-28] iPhone Duo - Spend - Blank space is shown at the footer in selection mode #107223
Version Number: 9.5.41-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: - Email or phone of affected tester (no customers):joinsdjosjdojosijdiosnj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone Duo / iOS 27.2 App Component: Search
Action Performed:
Launch Expensify app.
Go to workspace chat.
Create an expense.
Go to Spend > Expenses.
Long tap on the expense and select it.
Expected Result:
No blank space will be shown at the footer.
Actual Result:
Blank space is shown at the footer in selection mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The bottom-offset assumption predates this PR; the likely regression is introducing vertical-tab support without updating its spacing consumers.
Verification limit: Not independently reproduced. QA could not reproduce it a second time, and web testing cannot establish native UIKit behavior. The recording’s actual insets and gap height remain unverified.
What changes do you think we should make in order to solve the problem?
Recommend rolling forward: make shared iOS bottom coverage account for vertical tabs, removing only the horizontal-tab reservation while preserving legitimate safe-area spacing.
Validate selection-mode footers, list-end spacing, offline indicators, and floating buttons on the affected device, including orientation changes.
What alternative solutions did you explore? (Optional)
Reverting the Duo-support PR would also remove its intended navigation fixes. A targeted spacing correction is preferable, subject to native-device confirmation.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/107223) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]iPhone Duo - Spend - Blank space is shown at the footer in selection mode[/-][+][Due for payment 2026-11-28] iPhone Duo - Spend - Blank space is shown at the footer in selection mode[/+]on Nov 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.51-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/244bc81c6d8a40eff9bf2d0d4765745a48ce8fb5f61901abfe46c2fb4e98abc6
expensify-chore-bot commentedon Nov 18, 2026
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.expensify-chore-bot commentedon Nov 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jponikarchuk commentedon Nov 18, 2026
We couldn't reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.
MelvinBot commentedon Nov 18, 2026
Proposal
Likely causing PR: fix: add iPhone Duo support — medium confidence. It is included in the 9.5.41-0 staging release.
What is the root cause of that problem?
The expense footer reserves space for a horizontal bottom tab bar even when Duo displays the tabs vertically. That leaves phantom bottom padding.
Supporting evidence
The bottom-offset assumption predates this PR; the likely regression is introducing vertical-tab support without updating its spacing consumers.
Verification limit: Not independently reproduced. QA could not reproduce it a second time, and web testing cannot establish native UIKit behavior. The recording’s actual insets and gap height remain unverified.
What changes do you think we should make in order to solve the problem?
Recommend rolling forward: make shared iOS bottom coverage account for vertical tabs, removing only the horizontal-tab reservation while preserving legitimate safe-area spacing.
Validate selection-mode footers, list-end spacing, offline indicators, and floating buttons on the affected device, including orientation changes.
What alternative solutions did you explore? (Optional)
Reverting the Duo-support PR would also remove its intended navigation fixes. A targeted spacing correction is preferable, subject to native-device confirmation.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/107223)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Nov 18, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon Nov 18, 2026
This is on iphone due, not gonna block on it
fix: drop the bottom tab bar space when the iPhone Duo tab bar is ver…
[-]iPhone Duo - Spend - Blank space is shown at the footer in selection mode[/-][+][Due for payment 2026-11-28] iPhone Duo - Spend - Blank space is shown at the footer in selection mode[/+]melvin-bot commentedon Nov 21, 2026
@truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.51-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]