Repository navigation
fix: iPhone Duo vertical tab bar selection and Spend selection footer spacing - #107240
Conversation
On a foldable iPhone UIKit draws the tab bar items in a floating bar beside UITabBar and moves the liquid glass selection views into it. RNScreens patch 007 only searched self.tabBar, so on Account the selection stayed on Home, and views it hid at launch stayed hidden after UIKit moved them, which left the Home icon blank and no later tab highlighted. The patch now searches the whole tab bar controller view, skipping the tab content. Fixes Expensify#107219 Fixes Expensify#107220
…tical The covered height always reserved the bottom UITabBar row, so with the bar laid out as a side column the Spend selection footer sat above a blank band. A vertical bar covers only the home indicator inset. Fixes Expensify#107223
|
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed commit The widened selection traversal and vertical-aware footer spacing appear consistent with the intended fixes. CI tests, typecheck, lint, and patch validation passed. Validation limitation: Static review only. Web cannot verify these UIKit-specific changes; the documented Duo and regular-iPhone checks remain necessary, especially Account cold-launch restoration and selection highlighting after switching tabs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba00109de6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-11-18.at.23.17.56.movScreen.Recording.2026-11-18.at.23.18.57.movScreen.Recording.2026-11-18.at.23.19.23.movScreen.Recording.2026-11-18.at.23.20.04.movScreen.Recording.2026-11-18.at.23.26.26.movScreen.Recording.2026-11-18.at.23.27.10.moviOS: mWeb SafariMacOS: Chrome / Safari |
mountiny
left a comment
There was a problem hiding this comment.
Thanks, looks good to me
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR fixes tab highlighting, icon visibility, and footer spacing on iPhone Duo without adding a workflow or making existing article instructions incorrect. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀
|
|
Could you please double check if this Deploy Blocker issue #107516 is not introduced by #107240. Unable to check as Ad-hoc builds are crashes. |
|
@jponikarchuk I wouldn't say that this PR could cause #107516 because it only modifies iOS code and the blocker is present on both android and iOS |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
On the iPhone Duo, UIKit draws the tab bar items in a floating bar beside
UITabBar, so RNScreens patch 007 never hid or re-showed the selection there: Home stayed selected on Account, its icon went blank after relaunch, and later tabs lost their highlight. The patch now searches the whole tab bar controller view, skipping the selected tab's content view.useTabBarCoveredHeightalso stops reserving a bottom bar row when the bar is vertical, which removes the blank space under the Spend selection footer.Fixed Issues
$ #107219
$ #107220
$ #107223
$ #107270
PROPOSAL: N/A
Tests
Use an iPhone Duo (iOS 27.1+, folded so the cover panel shows the vertical tab bar on the right).
Offline tests
N/A, layout only.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari