Repository navigation
fix: iPhone Duo vertical tab bar selection and Spend selection footer spacing #107240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 2 commits into
Expensify:main
from
software-mansion-labs:war-in/duo-followup-fixes
Nov 18, 2026
+25
−11
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 10 additions & 2 deletions
12
src/components/Navigation/TabBarBottomContent/useTabBarCoveredHeight/index.ios.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| import useResponsiveLayout from '@hooks/useResponsiveLayout'; | ||
| import useSafeAreaInsets from '@hooks/useSafeAreaInsets'; | ||
|
|
||
| import useIsTabBarVertical from '@libs/Navigation/AppNavigator/Navigators/NativeTabNavigator/useIsTabBarVertical'; | ||
| import {getFloatingButtonsBottom} from '@libs/Navigation/AppNavigator/Navigators/NativeTabNavigator/useNativeTabBarOptions'; | ||
|
|
||
| /** The translucent UITabBar and the home indicator inset under it cover the bottom of a narrow tab root screen. */ | ||
| /** | ||
| * The translucent UITabBar and the home indicator inset under it cover the bottom of a narrow tab root screen. A tab bar | ||
| * laid out as a column sits beside the content, so only the home indicator inset covers it then. | ||
| */ | ||
| function useTabBarCoveredHeight(): number { | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const {bottom: bottomInset} = useSafeAreaInsets(); | ||
| const isTabBarVertical = useIsTabBarVertical(); | ||
|
|
||
| return shouldUseNarrowLayout ? getFloatingButtonsBottom(bottomInset) : 0; | ||
| if (!shouldUseNarrowLayout) { | ||
| return 0; | ||
| } | ||
| return isTabBarVertical ? bottomInset : getFloatingButtonsBottom(bottomInset); | ||
| } | ||
|
|
||
| export default useTabBarCoveredHeight; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.