Skip to content

iPhone Duo - Manual expense creation page is cut off when split on left screen #106392

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.34-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104988
Email or phone of affected tester (no customers): jnosidjodsjojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone Duo / iOS 27.2
App Component: Money Requests

Action Performed:

  1. Launch Expensify app unfolded in landscape mode and split it on left screen.
  2. Open FAB > Create expense > Manual.

Expected Result:

Manual expense creation page will be shown without cut off.

Actual Result:

Manual expense creation page is cut off when split on left screen.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image
Bug7309173_1794239568557.ScreenRecording_11-09-2026_23-48-41_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7309173

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 9, 2026
  2. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104988

  3. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @lakchote you have been assigned to this deploy blocker because you reviewed the offending PR: #104988

  4. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @war-in you have been assigned to this deploy blocker because you authored the offending PR: #104988

  5. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. lanitochka17 commented on Nov 9, 2026

    @lanitochka17

    We couldn’t reproduce this issue a second time because it is device-specific, and the iPhone Duo is the only one in the team.

  8. MelvinBot commented on Nov 9, 2026

    @MelvinBot
    Contributor

    Investigation result

    The causing PR is not confirmed. Do not revert “chore: update macos runners to xcode 27” on current evidence.

    The issue’s DeployBlockerCash label has already been removed, and it was linked under existing iPhone Duo layout tracking.

    Findings

    • The suspected PR shipped in staging 9.5.34-0, matching the reported version.
    • It changes only build infrastructure—not expense-layout components. Production selects Xcode 26.6, while staging selects Xcode 27.1. A toolchain-related native sizing regression is plausible, but unverified.
    • The screenshot shows clipped manual-expense confirmation fields. The shared confirmation layout and native dimension handling are unchanged between production and staging.
    • Similar Duo clipping predates this PR. The open “fix: add iPhone Duo support” is relevant, but has not been verified against this exact expense flow.

    Recommended next step

    Obtain a same-device production/staging comparison, preserving the split ratio and launch/rotation sequence. If staging alone fails, compare otherwise-identical native builds using the old and new toolchains, recording view bounds and safe-area dimensions.

    Confidence in PR attribution: low. No independent runtime reproduction was performed; web testing cannot establish the reported iOS-native split-screen behavior. No code or issue metadata was changed.


    view run

  9. added and removed on Nov 9, 2026
  10. cocvn157 commented on Nov 15, 2026

    @cocvn157

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On an unfolded iPhone Duo (iOS 27.2) in landscape mode split onto the left screen, opening FAB -> Create expense -> Manual renders the manual expense creation page cut off vertically/horizontally when split on the left screen.

    What is the root cause of that problem?

    There are two interacting causes in the manual expense creation and confirmation layout on iPhone Duo split-screen:

    1. isInLandscapeMode (src/libs/isInLandscapeMode/index.native.ts:1-13) and NumberWithSymbolForm.tsx (src/components/NumberWithSymbolForm.tsx:660-731) misclassify the split-screen pane geometry:

      • In src/libs/isInLandscapeMode/index.native.ts:10-12:
        export default function isInLandscapeMode(windowWidth: number, windowHeight: number): boolean {
            return !isTabletDevice && windowWidth > windowHeight;
        }
        When the Expensify app is unfolded in landscape mode and split onto the left screen on an iPhone Duo, the split pane has a compact horizontal width (windowWidth <= windowHeight) or a constrained vertical height while NumberWithSymbolForm.tsx (lines 660-731) and useShouldFooterBeInsideList.ts (src/hooks/useShouldFooterBeInsideList.ts:10-14) only switch to their compact/landscape layout when isInLandscapeMode (!isTabletDevice && windowWidth > windowHeight) is true.
      • In src/components/NumberWithSymbolForm.tsx:733-840 (non-landscape branch), NumberWithSymbolForm stacks the full-height amount container (styles.flex1), currency/flip buttons, <BigNumberPad />, and the Next button footer vertically inside <View style={[styles.w100, styles.justifyContentEnd, styles.pageWrapper, styles.pt0]}> outside the inner flex1 shrinkable region, while MoneyRequestAmountForm.tsx:287 wraps <MoneyRequestAmountInput> in an outer <ScrollView contentContainerStyle={styles.flexGrow1}> that nests a second <ScrollView> inside NumberWithSymbolForm.tsx:734 (style={!shouldWrapInputInContainer && styles.flexGrow0}).
    2. ConfirmationListLayout.tsx (src/components/MoneyRequestConfirmationList/ConfirmationListLayout.tsx:92-133) and StepScreenWrapper.tsx (src/pages/iou/request/step/StepScreenWrapper.tsx:75-82) pin the footer and RHP width without adapting to constrained split-pane height/insets:

      • In ConfirmationListLayout.tsx:92-128, shouldFooterBeInsideList = useShouldFooterBeInsideList() (isInLandscapeMode && isKeyboardActive) stays false when split on the left screen, keeping <ConfirmationFooterContent /> fixed outside the scrollable SelectionListWithSections while the RHP / split-pane width and vertical height clip the fields and CTA.

    What changes do you think we should make in order to solve the problem?

    1. Allow the manual expense creation and confirmation screens to scroll and adapt properly in constrained split-screen viewports on iPhone Duo:
      • In src/components/NumberWithSymbolForm.tsx:733-840 and src/pages/iou/MoneyRequestAmountForm.tsx:287, avoid double-nesting non-growing <ScrollView> containers when shouldWrapInputInContainer is true (or enable the compact/scrollable layout when the available viewport height is constrained in split-screen mode, e.g. isExtraSmallScreenHeight / split-pane dimensions) so the amount display, <BigNumberPad />, and Next footer never overflow or get cut off vertically/horizontally when split on the left screen.
      • In src/components/MoneyRequestConfirmationList/ConfirmationListLayout.tsx:92-128 (and src/hooks/useShouldFooterBeInsideList.ts), also move the footer inside the scrollable list (or ensure SelectionListWithSections shrinks above footerContent with proper safe-area insets) when the split-screen viewport height is constrained.

    What alternative solutions did you explore? (Optional)

    • Hiding <BigNumberPad /> in split-screen mode was rejected because touch-screen users still rely on the on-screen keypad when entering manual expense amounts without a hardware keyboard.
  11. lakchote commented on Nov 16, 2026

    @lakchote
    Contributor

    Not overdue.

  12. lakchote commented on Nov 17, 2026

    @lakchote
    Contributor

    @war-in can you take a look? Melvin linked this to your PR #104988, and there's a proposal above waiting for review.

  13. lakchote commented on Nov 18, 2026

    @lakchote
    Contributor

    Not overdue. #104730 added iPhone Duo support and war-in is going through these now, so I'm moving this to Weekly.

  14. added and removed on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions