Skip to content

[$175] Day is not mentioned first in Dutch on Sub page #106463

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.35-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105867
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Macbook Pro 2023 / Tahoe 26.4.1
App Component: User Settings

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account with a subscription
  3. Change Language to Dutch and check the next subscription payment

Expected Result:

Subscription and verify the subscription end date reads in German order, for example 20. Juni 2026.

Actual Result:

Sub. date reads the month first (In this case December)

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7309608_1794276261096.PR_105867_web.mp4
Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7309608

Upwork Automation - Do Not Edit

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2026
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 10, 2026
  3. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @TaduJR (External)

  4. changed the title [-]Day is not mentioned first in Dutch on Sub page[/-] [+][$175] Day is not mentioned first in Dutch on Sub page[/+] on Nov 10, 2026
  5. melvin-bot commented on Nov 10, 2026

    @melvin-bot
  6. MelvinBot commented on Nov 10, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The next-payment date previously used a fixed month-first format, translating the month name without changing its position.

    This is already addressed in merged Localize readable long dates and the next billing date. The fix is present in the inspected code; whether it reached the reported build remains unverified.

    The report also mixes languages: Dutch should read “1 december 2026” for the next payment in December, not use the German example “20. Juni 2026.”

    What changes do you think we should make in order to solve the problem?

    No additional implementation is currently warranted. Retest with a subscription-enabled account on a build confirmed to contain the existing fix. If that passes, mark this issue as already addressed.

    Code evidence and alternative explanations

    Confidence: High that the inspected code contains the targeted fix; deployed behavior remains unverified.

    Related tracking: Fix localization: dates not being localized correctly and Display formats hardcode US date and time conventions.

    Web verification evidence

    🤖 Web test steps verification results: ⚠️ partial

    Signed-in access and selecting Nederlands succeeded. The account had no Subscription entry, so next-payment formatting could not be verified. No purchase or payment data was added.

    Dutch Account settings without a Subscription entry
    Step Status
    Access signed-in AppAuthenticated Home and Profile were accessible.
    ✅
    Change language to NederlandsRead-back confirmed Nederlands and Dutch labels; Deutsch was not selected.
    Preferences showing Nederlands selected
    ✅
    Verify Dutch next-payment dateBlocked: Subscription was absent from the account menu; date ordering remains unverified.
    Dutch Account settings without a Subscription entry
    ❌

    Next Steps for Contributor+ team: Retest the existing fix before requesting another implementation.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin’s proposal.


    view run

  7. kevinjosh10 commented on Nov 10, 2026

    @kevinjosh10

    Proposal

    What is the root cause of that problem?

    There are two distinct parts to this issue:

    1. Staging Build Version / Missing Merge Window:

      • In src/pages/settings/Subscription/CardSection/utils.ts (getNextBillingDate), the date formatting previously used:
        format(nextBillingDate, CONST.DATE.MONTH_DAY_YEAR_FORMAT, {locale: dateFnsLocale});
        which strictly enforced month-first ordering (CONST.DATE.MONTH_DAY_YEAR_FORMAT).
      • PR #105869 (Localize readable long dates and the next billing date) migrated getNextBillingDate to use:
        DateUtils.formatToLongDate(nextBillingDate, dateFnsLocale);
        which uses Intl.DateTimeFormat(dateFnsLocale?.code ?? 'en-US', {year: 'numeric', month: 'long', day: 'numeric', timeZone: 'UTC'}). For Dutch (nl), Intl.DateTimeFormat formats the date as 1 december 2026 (day first).
      • However, the QA test was performed on version 9.5.35-1. Commit history shows tag 9.5.35-1 was built prior to PR Localize readable long dates and the next billing date #105869 being merged into staging.
    2. Unlocalized Date Formatting in DynamicWorkspaceOverviewPlanTypePage.tsx:

      • In src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx:107-109:
        const autoRenewalDate = privateSubscription?.endDate
            ? format(parseISO(privateSubscription.endDate), CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT, {locale: dateFnsLocale})
            : CardSectionUtils.getNextBillingDate(dateFnsLocale);
        When an active subscription has an endDate, it still uses format(..., CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT, {locale: dateFnsLocale}). MONTH_DAY_YEAR_ORDINAL_FORMAT is hardcoded as MMMM do, yyyy, forcing month-first formatting across all languages including Dutch and German.

    What changes do you think we should make in order to solve the problem?

    1. In src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx:
      • Replace the hardcoded format(..., CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT, ...) with DateUtils.formatToLongDate(parseISO(privateSubscription.endDate), dateFnsLocale) so that subscription renewal dates always follow the localized component ordering for Dutch, German, Spanish, etc.
    2. In src/pages/settings/Subscription/CardSection/utils.ts:
    3. Verify on build containing PR Localize readable long dates and the next billing date #105869 that 1 december 2026 is correctly displayed on Settings > Subscription in Dutch (nl).

    What alternative solutions did you explore? (Optional)

    None needed; using DateUtils.formatToLongDate ensures consistent Intl.DateTimeFormat localized date ordering everywhere subscription dates are shown.

    Tests

    1. Go to Settings > Preferences > Language and select Nederlands.
    2. Go to Settings > Subscription.
    3. Verify that the next payment date reads in Dutch order with the day first (e.g. 1 december 2026).
    4. Go to Workspace Settings > Workflows / Overview > Plan type.
    5. Verify the renewal date is displayed with the day first in Dutch.

    Contributor details

    Your Expensify account email: lkevinjosh10@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0131dae36abcf59374

  8. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  9. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  10. jmquero92 commented on Nov 10, 2026

    @jmquero92

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Settings > Subscription page (and Workspace > Plan Type page), when the application language is set to Dutch (Nederlands), the subscription payment and renewal dates are displayed with the month first (e.g. december 1, 2026) instead of adhering to the Dutch date format with the day first (e.g. 1 december 2026).

    What is the root cause of that problem?

    There are two core factors contributing to this behavior:

    1. Staging Build Deployment Timing:

      • In src/pages/settings/Subscription/CardSection/utils.ts (getNextBillingDate), date formatting previously relied on format(nextBillingDate, CONST.DATE.MONTH_DAY_YEAR_FORMAT, {locale: dateFnsLocale}), which strictly enforced US month-first ordering (CONST.DATE.MONTH_DAY_YEAR_FORMAT).
      • PR #105869 migrated getNextBillingDate to delegate to DateUtils.formatToLongDate(nextBillingDate, dateFnsLocale). In DateUtils.formatToLongDate, memoizedCreateLongDateFormatter(dateFnsLocale?.code ?? 'en-US') uses Intl.DateTimeFormat with {year: 'numeric', month: 'long', day: 'numeric', timeZone: 'UTC'}, which formats Dutch (nl) dates correctly as 1 december 2026.
      • The reported staging version 9.5.35-1 was built before PR Localize readable long dates and the next billing date #105869 landed in the release branch.
    2. Hardcoded Month-First Formatting in DynamicWorkspaceOverviewPlanTypePage.tsx:

      • In src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx:107-109:
        const autoRenewalDate = privateSubscription?.endDate
            ? format(parseISO(privateSubscription.endDate), CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT, {locale: dateFnsLocale})
            : CardSectionUtils.getNextBillingDate(dateFnsLocale);
        When an active subscription has an endDate, it formats the renewal date with CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT ('MMMM do, yyyy'). This hardcodes month-first ordering regardless of dateFnsLocale, reproducing the exact same bug on the workspace plan type screen for Dutch, German, etc.

    What changes do you think we should make in order to solve the problem?

    1. In src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx:

      • Update autoRenewalDate calculation to use locale-aware long date formatting:
        const autoRenewalDate = privateSubscription?.endDate
            ? DateUtils.formatToLongDate(parseISO(privateSubscription.endDate), dateFnsLocale)
            : CardSectionUtils.getNextBillingDate(dateFnsLocale);
      • This ensures consistent localized day-first ordering for Dutch (1 december 2026), German, Spanish, etc., while preserving US conventions where appropriate.
    2. In src/pages/settings/Subscription/CardSection/utils.ts:

    What alternative solutions did you explore? (Optional)

    Creating custom date-fns format strings per locale, but delegating to DateUtils.formatToLongDate is the standardized, memoized pattern across the app using Intl.DateTimeFormat.

    Tests

    1. Go to Settings > Preferences > Language and select Nederlands.
    2. Go to Settings > Subscription.
    3. Verify the next payment date in the subtitle displays day-first (e.g. 1 december 2026 rather than december 1, 2026).
    4. Go to Workspace Settings > Overview / Plan Type with an active subscription.
    5. Verify the renewal date also displays day-first in Dutch.
    6. Switch language back to English and verify dates display in standard US format (December 1, 2026).

    Contributor details

    Your Expensify account email: jmquero92@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01ca8ad8ce36b9eceb

  11. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    ⚠️ Unable to store contributor details

    Details
    Auth SetContributorDetails returned an error
    401 Contributor details already exist
    
  12. TassioSales commented on Nov 10, 2026

    @TassioSales

    Contributor details
    Your Expensify account email: tassiolucian.ljs@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0179cdc82689f205c7

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Subscription page, when the app language is set to Dutch (nl), the subscription renewal / end date displays the month first instead of the day first (e.g. displaying month before day rather than "20 december 2026").

    What is the root cause of that problem?

    In the subscription details components (src/pages/settings/Subscription/), the subscription renewal date is formatted using a hardcoded date format (such as CONST.DATE.MONTH_DAY_YEAR_FORMAT / 'MMMM d, yyyy') or DateUtils.formatToReadableString without applying locale-aware date ordering for Dutch (nl), where standard convention requires day-first formatting (d MMMM yyyy).

    What changes do you think we should make in order to solve the problem?

    1. In src/libs/DateUtils.ts, ensure subscription date formatting utilizes date-fns/format with locale support or uses a localized date formatter (e.g. formatToLongDate(date, preferredLocale)):
      • For Dutch (nl), use day-first pattern ('d MMMM yyyy').
      • For English (en), preserve month-first pattern ('MMMM d, yyyy').
    2. In src/pages/settings/Subscription/SubscriptionDetails.tsx and related subscription size/pricing cards, pass preferredLocale into the date formatting helper so the renewal date dynamically formats according to the selected user language.

    What alternative solutions did you explore? (Optional)

    • Hardcoding a one-off string replacement in the subscription card: Rejected because date formatting should follow Expensify's centralized i18n date utility architecture.

    What automated tests can you add to prevent this from re-occurring?

    In tests/unit/DateUtilsTest.ts:

    • Add a unit test verifying that formatting a date with locale 'nl' places the day first (e.g. '20 december 2026') and with locale 'en' formats with month first (e.g. 'December 20, 2026').
  13. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  14. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    @TaduJR 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  15. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    @TaduJR Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions