Repository navigation
Localize long dates read from UTC values - #105867
Conversation
Add DateUtils.formatToLongDateInUTC, which reads the value as UTC and formats it with a cached Intl.DateTimeFormat, and use it for the subscription, payment history, overdue invoice, violation and QuickBooks token expiry dates. Other languages get their own component order; English output is unchanged.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Looks good from a product perspective. |
twisterdotcom
left a comment
There was a problem hiding this comment.
Looks good from a product perspective.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb Safaripr105867-home-card.mp4MacOS: Chrome / Safaripr105867-home-card.mp4 |
|
@shubham1206agra conflicts :( |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.35-0 🚀
|
|
No help site update needed — this PR fixes date formatting to match the selected language, restoring expected behavior without adding a workflow or making existing article instructions incorrect. |
|
No FullStory changes needed — this PR only fixes localized date formatting in existing UI, without adding screens, interactions, user properties, or newly exposed sensitive content. |
|
This PR failing because of the issue #106463 |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Long dates read from UTC values were built with
formatWithUTCTimeZone(date, CONST.DATE.MONTH_DAY_YEAR_FORMAT), where the constant is the hand-written date-fns patternMMMM d, yyyy. The pattern fixes the US component order, so other languages showed their own month name in an English shape, for exampleJuni 20, 2026in German.This adds
DateUtils.formatToLongDateInUTC, which reads the value as UTC the same way and formats it with a cachedIntl.DateTimeFormatin the app's selected language:Places updated:
The other users of
MONTH_DAY_YEAR_FORMAT(schedule call pages, the onboarding help dropdown, receipts and the next billing date) format through different helpers and are localized in their own PRs. The constant stays until they have all landed.This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order. Each one caches its own
Intl.DateTimeFormatnext to the function it changes; a follow-up will merge those into one shared helper.Fixed Issues
$ #98088
PROPOSAL:
Tests
20. Juni 2026.June 20, 2026, the same as before.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-11-05.at.2.36.53.PM.mov