Skip to content

[Due for payment 2026-11-18] Payment issue for E/App PR#105055 #106579

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #105055
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/684558.
Contributor+ member who reviewed the PR - @ZhenjaHorbach.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Nov 11, 2026

    @melvin-bot
    Author

    @ZhenjaHorbach The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  3. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  4. ZhenjaHorbach commented on Nov 18, 2026

    @ZhenjaHorbach
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue: NA

    It's a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Sign in as a user with no account manager and open the Concierge chat. Verify the header shows Talk to a human and no Book a call.
    2. Press Talk to a human. Verify a support ticket opens.
    3. Repeat as a user with an assigned account manager who has a calendar link. Verify the same button appears and Book a call does not.
    4. Open the 1:1 DM with that account manager. Verify Book a call still appears there and Talk to a human does not.
    5. Open any other chat. Verify Talk to a human does not appear.
    6. Open the Concierge side panel. Verify the button shows full width and works the same way.
    7. For a small-company onboarding account, check the Concierge header on wide and narrow layouts. Verify Talk to a human and Register for webinar appear without the trial button. Verify the trial button still appears in another eligible onboarding chat.

    Do we agree 👍 or 👎

  5. ZhenjaHorbach commented on Nov 18, 2026

    @ZhenjaHorbach
    Contributor

    We had 2 deploy blockers
    #106472
    #106511

    But we closed this without any changes, and this is not a regression

    So I hope there should be a default price

  6. mallenexpensify commented on Nov 19, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Ready. Job price: $175 (standard, first review 2026-10-30).

    • ZhenjaHorbach (C+): 100%, via NewDot

    Two deploy blockers cleared. jasperhuangg ruled 106472 is not a regression. 106511 closed with no change.

    Next: press Caps+Y, then pay.

    Evidence
    • C+ checklist, 7 steps: comment
    • ZhenjaHorbach's blocker reply: comment.
    • PR 105055: by ishpaul777, merged 2026-11-09, production 2026-11-11, approved by ZhenjaHorbach and jasperhuangg. No revert.
    • Test videos: C+ 5/5. TestRail case: none.

    PAYPREP v1

  7. mallenexpensify commented on Nov 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $175 via NewDot

    @ZhenjaHorbach thx for addressing the deploy blockers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions