Repository navigation
[Payment due @ZhenjaHorbach] Add Talk to a human to the Concierge DM header - #105055
jasperhuangg merged 9 commits into
Conversation
Replaces Book a call in the Concierge chat for every user, and keeps it in 1:1 DMs with the assigned support contact and inside support tickets. The button requests a new support ticket and is disabled while offline.
|
@MelvinBot review |
ReviewThe logic looks correct. I found no bugs. Talk to a human shows only in the Concierge chat. Book a call still shows in the 1:1 DM with the assigned contact and in support tickets. The new tests cover showing, hiding, pressing, and offline. CI passes except the checklist jobs. Please address these before you mark the PR ready:
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cc @Expensify/design for a design review, we added a new Talk to a human on concierge DM header |
|
@ishpaul777 |
I'm not against removing the icons for the webinar and free trial buttons. At the very least all the icons should be on the same side, no? |
yes
agree +1 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-04.at.12.28.58.movAndroid: mWeb ChromeScreen.Recording.2026-11-04.at.12.25.26.moviOS: HybridAppScreen.Recording.2026-11-04.at.12.28.58.moviOS: mWeb SafariScreen.Recording.2026-11-04.at.12.25.26.movMacOS: Chrome / SafariScreen.Recording.2026-11-04.at.12.19.44.mov |
|
The three buttons feel like a lot. I would love to consolidate like we used to - maybe the button is a dropdown button that says "Support" and the two options are talk to a human or register for a webinar? Otherwise this feels pretty crowded on mobile, I feel like we can simplify things. Agree about at least aligning the icon styles though! |
…-to-human-concierge-header # Conflicts: # src/pages/inbox/HeaderView.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c16c0c559f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,33 @@ | |||
| import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; | |||
There was a problem hiding this comment.
Add the required new-file header
This newly added 33-line source module contains hooks, action wiring, and UI behavior but begins directly with imports. CONSISTENCY-13 requires non-trivial new files under src/ to start with a short module description, so add a header comment explaining that this button opens a support ticket from Concierge.
AGENTS.md reference: AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
| onPress={callFunctionIfActionIsAllowed(openSupportTicketOrConcierge)} | ||
| isDisabled={isOffline} |
There was a problem hiding this comment.
Reuse the offline-disabled button wrapper
This component reimplements the exact useNetwork() plus isDisabled={isOffline} behavior already provided by ButtonDisabledWhenOffline in src/components/Button/composed/ButtonDisabledWhenOffline.tsx. Keeping both implementations can drift and violates CONSISTENCY-3, so render the composed button here and remove the local network subscription.
AGENTS.md reference: AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
| partnerManager: getBookCallVisibility(partnerManagerAccountID, bookCallDetails?.partnerManagerCalendarLink), | ||
| guide: getBookCallVisibility(isGuideEligibleForBooking ? guideAccountID : undefined, accountGuideDetails?.calendarLink), | ||
| }; | ||
| // Show the "Book a call" button in the 1:1 DM with the assigned support person |
There was a problem hiding this comment.
Explain why Book a call is DM-only
This modified comment only restates what shouldShowBookCallInDM and its conditions already say. CONSISTENCY-14 requires comments to capture the reason rather than repeat behavior, so remove it or explain the product reason Book a call remains in assigned-contact DMs while Concierge uses Talk to a human.
AGENTS.md reference: AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
| await Onyx.set(ONYXKEYS.CONCIERGE_REPORT_ID, report.reportID); | ||
| }); | ||
|
|
||
| renderHeader(report.reportID); |
There was a problem hiding this comment.
Add When phases to the visibility tests
This newly added case moves from its Given setup directly to Then, with no // When around renderHeader(...). Add the required phase marker here and to the other added visibility cases so every test records Given/When/Then as required by the repository testing standard.
AGENTS.md reference: AGENTS.md:L86-L90
Useful? React with 👍 / 👎.
This is looking better, but @Expensify/design I still feel like the icons in the webinar and trial buttons aren't really doing a lot. I kinda think it'd be better to just drop them and update the trial button to say
This definitely looks better, but I am a little bit concerned about tucking the talk to a human button behind a click because it was framed as being quite important. @Expensify/design maybe we should bring that to slack before committing? |
|
I'm down with that suggestion @dannymcclain ! And yes, we can discuss that idea in Slack. cc @danielrvidal tldr; is that the "Talk to a human" button makes it so that we have three buttons in the header now, which feels quite heavy: The idea is to consolidate the support options into one Support dropdown button: |
|
But overall changes look good! |
|
Looks like we have no existing logic to find the open support tickets, it always open a new ticket also from Help > Talk to human also |
|
Yea, we'll be adding logic to point people to existing chats if they have an open one but that will come later. |
|
Let's merge then! |
|
🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
sweet! I believe if @danielrvidal checks off on this then we'll be good from a product review perspective |
|
@jasperhuangg can you let me know what you are awaiting sign off for? I don't see an updated question for me. I think if you think it's ready let's push it to staging for testing please! |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.5.35-0 🚀
|
|
Created Update FullStory for the new Concierge human support entry point, labeled Recommended one custom element using the button’s existing stable identifier—no additional App code needed. No new events, user properties, masking, or page-view tracking are warranted. |
|
Help site update needed: the navigation article incorrectly lists Book a call in Concierge, which now shows Talk to a human. Created a minimal draft help site PR, labeled @ishpaul777, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #106472 was identified to be related to this PR. |
|
Deploy Blocker #106511 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #106579 |






Explanation of Change
The Concierge DM header showed Book a call when the user had an account manager, partner manager or guide, and nothing otherwise. This replaces it with Talk to a human for every user, and keeps Book a call in 1:1 DMs with the assigned contact and inside support tickets.
Pressing the button requests a new support ticket with no existing report ID, through the shared
useOpenSupportTickethook from #104572. That keeps the no-rep error and the Concierge fallback identical to the Help page row. The button is disabled offline, like that row.The Concierge DM no longer shows the trial button, leaving Talk to a human and Register for webinar as separate actions. Other onboarding chats retain the trial button.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/684558
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos