Skip to content

[Payment due @ZhenjaHorbach] Add Talk to a human to the Concierge DM header - #105055

Merged
jasperhuangg merged 9 commits into
Expensify:mainfrom
ishpaul777:ishpaul/684558-talk-to-human-concierge-header
Nov 9, 2026
Merged

jasperhuangg merged 9 commits into
Expensify:mainfrom
ishpaul777:ishpaul/684558-talk-to-human-concierge-header

Conversation

@ishpaul777

@ishpaul777 ishpaul777 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Concierge DM header showed Book a call when the user had an account manager, partner manager or guide, and nothing otherwise. This replaces it with Talk to a human for every user, and keeps Book a call in 1:1 DMs with the assigned contact and inside support tickets.

Pressing the button requests a new support ticket with no existing report ID, through the shared useOpenSupportTicket hook from #104572. That keeps the no-rep error and the Concierge fallback identical to the Help page row. The button is disabled offline, like that row.

The Concierge DM no longer shows the trial button, leaving Talk to a human and Register for webinar as separate actions. Other onboarding chats retain the trial button.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/684558

Tests

  1. Sign in as a user with no account manager and open the Concierge chat. Verify the header shows Talk to a human and no Book a call.
  2. Press Talk to a human. Verify a support ticket opens.
  3. Repeat as a user with an assigned account manager who has a calendar link. Verify the same button appears and Book a call does not.
  4. Open the 1:1 DM with that account manager. Verify Book a call still appears there and Talk to a human does not.
  5. Open any other chat. Verify Talk to a human does not appear.
  6. Open the Concierge side panel. Verify the button shows full width and works the same way.
  7. For a small-company onboarding account, check the Concierge header on wide and narrow layouts. Verify Talk to a human and Register for webinar appear without the trial button. Verify the trial button still appears in another eligible onboarding chat.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline in the Concierge chat. Verify Talk to a human is disabled and pressing it does nothing.
  2. Come back online. Verify it works again.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshot 2026-10-30 at 8 59 17 PM Screenshot 2026-10-30 at 9 01 22 PM

Replaces Book a call in the Concierge chat for every user, and keeps it in
1:1 DMs with the assigned support contact and inside support tickets. The
button requests a new support ticket and is disabled while offline.
@ishpaul777

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@ishpaul777 ishpaul777 changed the title [HOLD #104572] Add Talk to a human to the Concierge DM header Add Talk to a human to the Concierge DM header Oct 29, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor

Review

The logic looks correct. I found no bugs. Talk to a human shows only in the Concierge chat. Book a call still shows in the 1:1 DM with the assigned contact and in support tickets. The new tests cover showing, hiding, pressing, and offline. CI passes except the checklist jobs.

Please address these before you mark the PR ready:

  1. Check the Concierge header layout for onboarding users. The Concierge chat is often the onboarding chat. For micro or small companies and trial users, the header already shows the webinar dropdown and the Free trial badge. Before this PR, most of these users had no call button there. Now, on narrow screens, they get a full-width Talk to a human row above the dropdown and badge row (HeaderView.tsx:530-543). On wide screens, all three sit side by side (HeaderView.tsx:495-502). Please add screenshots of this case and confirm with design that it looks right.
  2. Nit: use ButtonDisabledWhenOffline. TalkToHumanButton.tsx:14-23 calls useNetwork and sets isDisabled={isOffline} by hand. ButtonDisabledWhenOffline already does this.
  3. Update the PR description. [Payment due] Open a support ticket straight from the Talk to a human link is merged, and the diff no longer includes its commits. Remove the "Stacked on…" and "draft until then" note.

@ishpaul777
ishpaul777 marked this pull request as ready for review October 29, 2026 01:00
@ishpaul777
ishpaul777 requested review from a team as code owners October 29, 2026 01:00
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team October 29, 2026 01:00
@melvin-bot

melvin-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T17:52:19.774681Z 385e26c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team October 29, 2026 01:00
@ishpaul777

ishpaul777 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

cc @Expensify/design for a design review, we added a new Talk to a human on concierge DM header

@ishpaul777
ishpaul777 requested a review from a team October 29, 2026 01:10
@dubielzyk-expensify

dubielzyk-expensify commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

I guess since this is just a replace, that looks good to me.

I wonder if we should remove some of the icons in the buttons here cause it looks a bit hectic. Especially for the webinar, that gets cut off on mobile:

CleanShot 2026-10-29 at 1 45 49 PM@2x CleanShot 2026-10-29 at 1 46 01 PM@2x

I guess we should keep it for talk to a human since it changes to the avatar, but I think the star icon also feels a bit off to me now after some time for the trial button.

cc @Expensify/design for thoughts

@ZhenjaHorbach

ZhenjaHorbach commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

@ishpaul777
Do you need help with the review? 😁

@dannymcclain

Copy link
Copy Markdown
Contributor

I wonder if we should remove some of the icons in the buttons here cause it looks a bit hectic. Especially for the webinar, that gets cut off on mobile:
I guess we should keep it for talk to a human since it changes to the avatar, but I think the star icon also feels a bit off to me now after some time for the trial button.

I'm not against removing the icons for the webinar and free trial buttons. At the very least all the icons should be on the same side, no?

@ishpaul777

Copy link
Copy Markdown
Contributor Author

@ishpaul777 Do you need help with the review? 😁

yes

At the very least all the icons should be on the same side, no?

agree +1

@ZhenjaHorbach

ZhenjaHorbach commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-04.at.12.28.58.mov
Android: mWeb Chrome
Screen.Recording.2026-11-04.at.12.25.26.mov
iOS: HybridApp
Screen.Recording.2026-11-04.at.12.28.58.mov
iOS: mWeb Safari
Screen.Recording.2026-11-04.at.12.25.26.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-04.at.12.19.44.mov

@jasperhuangg
jasperhuangg self-requested a review October 29, 2026 16:37
@shawnborton

Copy link
Copy Markdown
Contributor

The three buttons feel like a lot. I would love to consolidate like we used to - maybe the button is a dropdown button that says "Support" and the two options are talk to a human or register for a webinar? Otherwise this feels pretty crowded on mobile, I feel like we can simplify things.

Agree about at least aligning the icon styles though!

@ishpaul777

ishpaul777 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

Agree about at least aligning the icon styles though!

Updated PR description with new screenshots

maybe the button is a dropdown button that says "Support" and the two options are talk to a human or register for a webinar?

let me know if we want to do this as well

Screenshot 2026-10-30 at 12 51 20 AM support-preview-narrow

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c16c0c559f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,33 @@
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required new-file header

This newly added 33-line source module contains hooks, action wiring, and UI behavior but begins directly with imports. CONSISTENCY-13 requires non-trivial new files under src/ to start with a short module description, so add a header comment explaining that this button opens a support ticket from Concierge.

AGENTS.md reference: AGENTS.md:L7-L10

Useful? React with 👍 / 👎.

Comment thread src/components/TalkToHumanButton.tsx Outdated
Comment on lines +22 to +23
onPress={callFunctionIfActionIsAllowed(openSupportTicketOrConcierge)}
isDisabled={isOffline}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reuse the offline-disabled button wrapper

This component reimplements the exact useNetwork() plus isDisabled={isOffline} behavior already provided by ButtonDisabledWhenOffline in src/components/Button/composed/ButtonDisabledWhenOffline.tsx. Keeping both implementations can drift and violates CONSISTENCY-3, so render the composed button here and remove the local network subscription.

AGENTS.md reference: AGENTS.md:L7-L10

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Comment thread src/pages/inbox/HeaderView.tsx Outdated
partnerManager: getBookCallVisibility(partnerManagerAccountID, bookCallDetails?.partnerManagerCalendarLink),
guide: getBookCallVisibility(isGuideEligibleForBooking ? guideAccountID : undefined, accountGuideDetails?.calendarLink),
};
// Show the "Book a call" button in the 1:1 DM with the assigned support person

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Explain why Book a call is DM-only

This modified comment only restates what shouldShowBookCallInDM and its conditions already say. CONSISTENCY-14 requires comments to capture the reason rather than repeat behavior, so remove it or explain the product reason Book a call remains in assigned-contact DMs while Concierge uses Talk to a human.

AGENTS.md reference: AGENTS.md:L7-L10

Useful? React with 👍 / 👎.

await Onyx.set(ONYXKEYS.CONCIERGE_REPORT_ID, report.reportID);
});

renderHeader(report.reportID);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add When phases to the visibility tests

This newly added case moves from its Given setup directly to Then, with no // When around renderHeader(...). Add the required phase marker here and to the other added visibility cases so every test records Given/When/Then as required by the repository testing standard.

AGENTS.md reference: AGENTS.md:L86-L90

Useful? React with 👍 / 👎.

@dannymcclain

Copy link
Copy Markdown
Contributor

Updated PR description with new screenshots

This is looking better, but @Expensify/design I still feel like the icons in the webinar and trial buttons aren't really doing a lot. I kinda think it'd be better to just drop them and update the trial button to say Trial: 15 days left.

maybe the button is a dropdown button that says "Support" and the two options are talk to a human or register for a webinar?

let me know if we want to do this as well

This definitely looks better, but I am a little bit concerned about tucking the talk to a human button behind a click because it was framed as being quite important. @Expensify/design maybe we should bring that to slack before committing?

@shawnborton

Copy link
Copy Markdown
Contributor

I'm down with that suggestion @dannymcclain !

And yes, we can discuss that idea in Slack. cc @danielrvidal tldr; is that the "Talk to a human" button makes it so that we have three buttons in the header now, which feels quite heavy:
CleanShot 2026-10-29 at 9 28 25 PM@2x

The idea is to consolidate the support options into one Support dropdown button:
CleanShot 2026-10-29 at 9 28 46 PM@2x

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

But overall changes look good!

@ishpaul777

Copy link
Copy Markdown
Contributor Author

Looks like we have no existing logic to find the open support tickets, it always open a new ticket also from Help > Talk to human also

@danielrvidal

Copy link
Copy Markdown
Contributor

Yea, we'll be adding logic to point people to existing chats if they have an open one but that will come later.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Let's merge then!

@melvin-bot melvin-bot Bot changed the title Add Talk to a human to the Concierge DM header [Payment due @ZhenjaHorbach] Add Talk to a human to the Concierge DM header Nov 5, 2026
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/684558.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@jasperhuangg

Copy link
Copy Markdown
Contributor

sweet! I believe if @danielrvidal checks off on this then we'll be good from a product review perspective

@danielrvidal

Copy link
Copy Markdown
Contributor

@jasperhuangg can you let me know what you are awaiting sign off for? I don't see an updated question for me. I think if you think it's ready let's push it to staging for testing please!

@jasperhuangg
jasperhuangg merged commit b2e2e07 into Expensify:main Nov 9, 2026
39 of 41 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Nov 9, 2026
72 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.5.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Created Update FullStory for the new Concierge human support entry point, labeled Weekly and assigned to flaviadefaria and ishpaul777.

Recommended one custom element using the button’s existing stable identifier—no additional App code needed. No new events, user properties, masking, or page-view tracking are warranted.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site update needed: the navigation article incorrectly lists Book a call in Concierge, which now shows Talk to a human.

Created a minimal draft help site PR, labeled HelpDot and assigned to ishpaul777. Verified the button in the live web UI.

@ishpaul777, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #106472 was identified to be related to this PR.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #106511 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #106579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.