Skip to content

[Due for payment 2026-11-20] Expense - Report field opens empty modal when submitting to employer #106693

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.37-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105939
Email or phone of affected tester (no customers): jsodinjsodjsiojio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account does not have workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Click Submit to my employer.
  5. Click Report field.

Expected Result:

Report field should be disabled if there is no actionable option.

Actual Result:

Report field opens empty modal when submitting to employer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7312140_1794477116439.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7312140

Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 12, 2026
  2. applause-bot commented on Nov 12, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/173cc087572ae1bb9a98a6bf7e92d2ea0d5f7df186064c7d1f22d42f04c9487f

  3. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105939

  4. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    @puneetlath @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #105939

  5. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    @DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #105939

  6. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 12, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 12, 2026

    @MelvinBot
    Contributor

    🤖 Web test steps verification results: ⚠️ partial

    Verified no existing workspace on dev NewDot web. Could not open the self DM through supported selectors, so the expense and Report-field behavior remain unverified.

    Self-chat search at the navigation blocker

    Step Status
    Account has no existing workspaceWorkspaces displayed “No workspaces yet”. No workspaces were deleted.
    ✅
    Open self DMSearch found “Melvin Tester (you)”, but supported click selectors could not resolve the result.
    Self-chat search at the navigation blocker
    ❌
    Create an expenseNot reached because self-DM navigation was blocked.
    ❌
    Click Submit to my employerNot reached.
    ❌
    Determine whether Report is disabled or opens an empty modalRuntime verification was not reached. The deploy-blocker investigator and an independent researcher confirmed the following source-level explanation.

    Root cause: Refactor ReportField logic to simplify report editability condition makes non-EDIT actions bypass the available-report check in ReportField.tsx:118–127. The employer flow uses SUBMIT and creates a draft workspace when none exists (StartExpenseFlows.ts:393–415). The picker cannot create a report against that draft-only workspace, and “None” is restricted to CREATE (useReportPickerActions.ts:279–282, 323–329). Result: an enabled Report field with no actionable choices.

    Recommended change: Roll forward with editability based on actual selectable reports or available Create report/None actions. Preserve existing locks. Add coverage for SUBMIT with only a draft workspace, alongside legitimate CREATE flows with zero existing reports. Do not globally restore the old report-count check; that would disable valid creation actions.

    Alternative considered: Remove anchoredFieldDropdowns flag broadens exposure to the modal presentation, but does not introduce the incorrect editability condition. Reverting it alone would not restore the expected disabled field.

    Deploy recommendation: Keep the blocker until the targeted fix passes regression testing. Revert the primary refactor if a fix cannot be validated promptly; revert cleanliness was not tested. Confidence is strong from source/history, but browser reproduction remains incomplete. No code, labels, or assignments were changed.
    ❌

    view run · no recording available

  9. changed the title [-]Expense - Report field opens empty modal when submitting to employer[/-] [+][Due for payment 2026-11-20] Expense - Report field opens empty modal when submitting to employer[/+] on Nov 13, 2026
  10. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    @ikevin127 / @DylanDylann

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-20. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions