Skip to content

Remove anchoredFieldDropdowns flag - #106084

Merged
puneetlath merged 4 commits into
Expensify:mainfrom
DylanDylann:remove-anchored-field-dropdowns-beta
Nov 11, 2026
Merged

puneetlath merged 4 commits into
Expensify:mainfrom
DylanDylann:remove-anchored-field-dropdowns-beta

Conversation

@DylanDylann

@DylanDylann DylanDylann commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The anchored dropdowns for Category, the tag rows, Tax rate, Attendees and Report on the expense create form were only shown to accounts on the anchoredFieldDropdowns beta. This PR removes that beta so every account gets them:

  • Removes CONST.BETAS.ANCHORED_FIELD_DROPDOWNS.
  • Drops the isBetaEnabled check from the five field rows (AttendeeField, CategoryField, ReportField, TagFields, TaxFields).
  • Removes the usePermissions mocks and the "keeps the full-page selector when the beta is off" unit tests.

Fixed Issues

$ #101573
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Setup

  • A workspace with categories, two or more independent tag lists, taxes and attendee tracking turned on, and at least two open reports.

Wide layout (web/desktop)

  1. Go to Settings > Troubleshoot > Beta overrides and verify anchoredFieldDropdowns is no longer listed.
  2. Go to FAB > Create expense > Manual, enter an amount and choose the workspace.
  3. Click Category. Verify the list opens in a pop-over right below the row, not on a full page. Pick a category and verify the pop-over closes and the row shows it.
  4. Repeat step 3 for each tag row and for Tax rate. Verify each row opens its own pop-over and saves the selection.
  5. Click Attendees. Select two attendees and verify the pop-over stays open and the pills update after each tap.
  6. Type an email that isn't in the list, select the add row, and verify the person is added and the pop-over stays open.
  7. Press Escape. Verify the pop-over closes and focus returns to the Attendees row.
  8. Click Report. Verify New report is at the top of the list, then pick a different report.
  9. Create the expense. Open it and verify every value you picked was saved.
  10. Go to FAB > Create expense > Scan, upload a receipt and choose the workspace. Click Category and verify it opens in a pop-over.

Narrow layout (mWeb/native)
11. Repeat steps 2–3. Verify Category opens in a bottom sheet, and that swiping down or tapping the backdrop closes it.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

@DylanDylann
DylanDylann requested review from a team as code owners November 5, 2026 10:07
@melvin-bot
melvin-bot Bot requested review from ikevin127 and thelullabyy November 5, 2026 10:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T10:23:03.010503Z 1ce4179 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team November 5, 2026 10:07
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@ikevin127 @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team November 5, 2026 10:07
@DylanDylann
DylanDylann requested review from a team and removed request for thelullabyy November 5, 2026 10:07
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 5, 2026 10:07
@trjExpensify
trjExpensify removed the request for review from JmillsExpensify November 5, 2026 10:34
@DylanDylann DylanDylann changed the title Remove anchoredFieldDropdowns flag [HOLD] Remove anchoredFieldDropdowns flag Nov 5, 2026
@trjExpensify trjExpensify changed the title [HOLD] Remove anchoredFieldDropdowns flag [HOLD PR#105596] Remove anchoredFieldDropdowns flag Nov 5, 2026
trjExpensify
trjExpensify previously approved these changes Nov 5, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for it! #105596 <-- let's make sure that gets through to prod first. 👍

@trjExpensify trjExpensify changed the title [HOLD PR#105596] Remove anchoredFieldDropdowns flag Remove anchoredFieldDropdowns flag Nov 9, 2026
@trjExpensify

Copy link
Copy Markdown
Contributor

This can come off hold now. Conflicts to fix!

@ikevin127

ikevin127 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-11-09.at.19.09.44.mov

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes (no code blockers): please fill in the PR description. Explanation, Tests and Screenshots are all empty. These are important especially tests since the PR is missing [NoQA] from title which means QA expects testing steps once this is merged.

cc @DylanDylann

@DylanDylann DylanDylann changed the title Remove anchoredFieldDropdowns flag [No QA] Remove anchoredFieldDropdowns flag Nov 10, 2026

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

@melvin-bot
melvin-bot Bot requested a review from puneetlath November 10, 2026 21:08
puneetlath
puneetlath previously approved these changes Nov 10, 2026

@puneetlath puneetlath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, but can you update the PR template? I think it may be copied from another PR, because it is mentioning unrelated things like CategoryPickerModal and tests/unit/components/ExpenseFieldDropdown.test.tsx.

Also, can you add an "explanation of change".

And also, I don't think it needs to be No QA. We could still QA this by making sure that the fields we expect to be dropdowns are dropdowns.

@DylanDylann

Copy link
Copy Markdown
Contributor Author

@puneetlath Updated, thanks for the reminder

@puneetlath puneetlath changed the title [No QA] Remove anchoredFieldDropdowns flag Remove anchoredFieldDropdowns flag Nov 11, 2026
@puneetlath

Copy link
Copy Markdown
Contributor

Thanks @DylanDylann. Looks like there are conflicts now.

@DylanDylann

Copy link
Copy Markdown
Contributor Author

@puneetlath Done

@puneetlath
puneetlath merged commit 5053924 into Expensify:main Nov 11, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — removing the beta changes how expense-field selectors open, but existing articles remain accurate and no documented steps or capabilities change.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #106702 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.37-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants