Skip to content

[HOLD for payment 2022-12-23] [$2000] [Bug] Keyboard being open/closed changes position of ToS on certain mobile platforms - reported by @gadhiyamanan #11277

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open login page on a fresh install OR after clearing app data
  2. Enter email/phone number.
  3. Open the touch screen keyboard by tapping on the login text input. Notice how the Terms and Licenses don't shift upwards to avoid the keyboard.
  4. Press "Continue" to get to the password form.
  5. Repeat step 3 with the password input. Notice how the Terms and Licenses doesn't shift upwards to avoid the keyboard.

Expected Result:

  • The Terms and Licenses should shift upwards to avoid the keyboard on both the login and password forms.

Actual result:

  • The page becomes scrollable, and you can scroll the login/password input out of view or out of view
  • The Terms and Licenses are not visible

Workaround:

None

Platform:

Where is this issue occurring?

  • iOS Safari
  • iOS Native
  • Android Chrome

Version Number: 1.2.4-0
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

iOS - Both forms are broken
ios.login.broken.mov
ios.password.broken.mov
Mobile Safari - Both forms are broken
mobile.safari.login.broken.mov
mobile.safari.password.broken.mov
Mobile Chrome - Interestingly, it appears to work on the login form, but not the password form
mobile.chrome.password.broken.mov
mobile.chrome.login.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661843853973199

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 26, 2022

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 26, 2022
  3. JmillsExpensify commented on Sep 26, 2022

    @JmillsExpensify
    Contributor

    I'm on iOS, so I'm unable to reproduce. That said, can you clarify exactly what you mean by "instruction goes up?" I'm not following what the issue is here. Thank you!

  4. gadhiyamanan commented on Sep 28, 2022

    @gadhiyamanan
    Contributor

    @JmillsExpensify here instruction means By logging in, you agree to the... , when you click on the phone field there is a large gap between the continue button and the instruction. after typing any word, space will remove

    it's reproduced on android

  5. JmillsExpensify commented on Oct 3, 2022

    @JmillsExpensify
    Contributor

    Ok thanks. Still unable to reproduce since I don't have an android device. That said, I have a suspicion that this is yet another symptom of our keyboard implementation. @roryabraham do you mind confirming if you think my hunch is right? If so, I'll update the issue title, put this issue on hold, and add it to the main tracker.

  6. roryabraham commented on Oct 4, 2022

    @roryabraham
    Contributor

    Okay, I was able to reproduce this, going to update the OP to add some additional details then I agree we should add it to the keyboard tracking issue (cc @tgolen)

  7. JmillsExpensify commented on Oct 4, 2022

    @JmillsExpensify
    Contributor

    Thanks @roryabraham! I'll handle adding to the keyboard tracking issue.

  8. changed the title [-]login page UI not consistent - reported by @gadhiyamanan[/-] [+][Hold #1027e] Keyboard being open/closed changes position of ToS - reported by @gadhiyamanan[/+] on Oct 4, 2022
  9. changed the title [-][Hold #1027e] Keyboard being open/closed changes position of ToS - reported by @gadhiyamanan[/-] [+][Hold #10273] Keyboard being open/closed changes position of ToS - reported by @gadhiyamanan[/+] on Oct 4, 2022
  10. 118 remaining items

  11. changed the title [-][$2000] [Bug] Keyboard being open/closed changes position of ToS on certain mobile platforms - reported by @gadhiyamanan[/-] [+][HOLD for payment 2022-12-23] [$2000] [Bug] Keyboard being open/closed changes position of ToS on certain mobile platforms - reported by @gadhiyamanan[/+] on Dec 16, 2022
  12. melvin-bot commented on Dec 16, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.40-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-23. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Dec 16, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane / @tgolen / @jasperhuangg] The PR that introduced the bug has been identified. Link to the PR: NA, this has been a problem since it was built
    • [@sobitneupane / @tgolen / @jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@sobitneupane / @tgolen / @jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    • [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  14. tgolen commented on Dec 16, 2022

    @tgolen
    Contributor

    I'm checking off most of those as NA since this has been an issue ever since the page was built

  15. JmillsExpensify commented on Dec 19, 2022

    @JmillsExpensify
    Contributor

    Great thank you! I'll circle back on the regression test/payment once I return on Tuesday.

  16. JmillsExpensify commented on Dec 22, 2022

    @JmillsExpensify
    Contributor

    Alright, circling back on this issue for the payment. It's due tomorrow, so let's make sure all is in order before then. @sobitneupane I've just invited you to the Upwork job. Mind accepting?

  17. JmillsExpensify commented on Dec 22, 2022

    @JmillsExpensify
    Contributor

    @gadhiyamanan You're also eligible for the reporting bonus. Please apply to the Upwork job.

  18. gadhiyamanan commented on Dec 22, 2022

    @gadhiyamanan
    Contributor
  19. JmillsExpensify commented on Dec 22, 2022

    @JmillsExpensify
    Contributor

    Thanks offer sent!

    Also I closed the loop on the regression test, so I'm crossing that off above in the BZ checklist.

  20. JmillsExpensify commented on Dec 22, 2022

    @JmillsExpensify
    Contributor

    Summarizing how payments will shape out.

  21. JmillsExpensify commented on Dec 27, 2022

    @JmillsExpensify
    Contributor

    Just realized that I didn't get around to paying this out before the Christmas holiday in the US, so I've just circled back and paid out both Contributors per the payments above. We already have a keyboard regression test is play, so I'm closing out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions