Repository navigation
Fix the position of the TOS on the sign on page to be above the keyboard - #13529
Conversation
|
Just adding myself for review here so I can keep this in my K2 |
…inBottom on the TermsAndLicenses
|
Hey @tgolen! To try to get something with Mobile Safari, I experimented with the The Mobile Safari keyboard incorrectly adds extra space at the bottom of the screen, which doesn't affect the flex of any of the elements above it: I didn't spend too long on this as Shawn mentioned that the design of this page could change very soon. |
|
The good news is that I was able to figure out some of the style issues you were experiencing on iOS Native. Instead of conditionally adding ios.native.mp4Android still works exactly the same as before with this change (I'm assuming because using Screen.Recording.2022-12-13.at.4.29.06.PM.movAnd the behavior on all other touchscreen keyboard platforms is unaffected. |
|
Hey, that's a great find, thank you! I didn't know about that prop. It makes sense that Android wouldn't change because the KAV is a no-op for Android (it's just an empty fragment). I'll get this cleaned up today and ready for review. |
|
@jasperhuangg @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I think that's okay, there's simply too many elements on the screen for it to fit, and the user can always scroll down a bit to view the rest of the text. We run into similar issues on the password form on other platforms, and we've decided that it isn't worth fixing. |
Screenshots/VideosWebScreen.Recording.2022-12-14.at.13.09.23.movMobile Web - ChromeScreen.Recording.2022-12-14.at.13.05.48.movMobile Web - SafariScreen.Recording.2022-12-14.at.13.20.23.movDesktopScreen.Recording.2022-12-14.at.13.27.52.moviOSScreen.Recording.2022-12-14.at.13.25.43.movAndroidScreen.Recording.2022-12-14.at.13.03.59.mov |
|
Lint error looks unrelated to this PR. Merging with main might solve the issue according to https://expensify.slack.com/archives/C01GTK53T8Q/p1670954885116019 |
|
@sobitneupane ahh beat me to it, I had already merged main before 😅 |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all
src/languages/*files - I verified any copy / text that was added to the app is correct English and approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
|
🚀 Deployed to production by @chiragsalian in version: 1.2.40-3 🚀
|


Fixed Issues
$ #11277
Tests
Note: We decided in the GH issue that mobile web platforms simply cannot be supported with the keyboard avoiding behavior. For mobile web platforms, as long as the user can tap outside of the input to make it lose focus, and they can scroll the page to view the content behind the keyboard, then that is OK 👍
Offline tests
Same as above.
Note: For offline mode, there is the "offline indicator" which adds extra items to the vertical height of the page. On the password form, this means that it pushes the TOS behind the keyboard again. This is OK 👍
Offline Screenshots
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
2022-12-13_08-34-15.mp4
Mobile Web - Chrome
2022-12-13_08-33-00.mp4
Mobile Web - Safari
2022-12-13_08-31-37.mp4
Desktop
2022-12-13_08-34-49.mp4
iOS
2022-12-13_08-30-51.mp4
Android
2022-12-13_08-32-23.mp4