Skip to content

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

Description

@OSBotify

Release Version: 1.2.19-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Oct 25, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.19-1 🚀

  2. Julesssss commented on Oct 25, 2022

    @Julesssss
    Contributor

    #12115 is in progress and should be resolved with the next Auth deploy.

  3. OSBotify commented on Oct 25, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.19-2 🚀

  4. mvtglobally commented on Oct 25, 2022

    @mvtglobally

    @chiragsalian We are still working on the regression, but wanted to send an interim summary

    PR #10471 is failing due to #12004
    PR #11611 is failing due to #12122. We can't check it in PROD, to confirm if this is a blocker or no.
    PR #11627 is blocked by #11595
    PR #11839 & #11988 are blocked by #11796 on IOS and Android

  5. OSBotify commented on Oct 25, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.19-2 has been deployed to staging 🎉

  6. dangrous commented on Oct 26, 2022

    @dangrous
    Contributor

    #12132 Is a bug but reproducible on prod so not a blocker, checking off here.

  7. Julesssss commented on Oct 26, 2022

    @Julesssss
    Contributor

    @chiragsalian the Auth fix for #12115 has been merged, but is still awaiting deployment.

  8. Julesssss commented on Oct 26, 2022

    @Julesssss
    Contributor

    @chiragsalian I checked off #12115 which is now resolved

  9. mvtglobally commented on Oct 26, 2022

    @mvtglobally

    @Julesssss Let us know if anything needs re-test. We would love a new build today 😉

  10. mvtglobally commented on Oct 26, 2022

    @mvtglobally

    @chiragsalian @Julesssss Regression is completed

    PR #10471 is failing due to #12004. Prod issue. Checking off
    PR #11611 is failing due to #12122 (comment). Checking off
    PR #11627 is blocked by #11595
    PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android
    PR #11719 is also failing due to #11461. Not a blocker.
    PR #11839 is failing #12138. Repro in PROD.
    PR #11926 (comment) need clarification
    PR #11996 is failing #12139. Its not repro in PROD as behavior is different. Pls double check if this should be a blocker or no

  11. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    Checking off 12122 is its not a blocker as reported in this comment.

  12. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    I checked off #11132

  13. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    I've checked off #11926 since its one pending comment was answered - #11926 (comment)

  14. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    @mvtglobally, can you explain this,

    PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android

    I wasn't sure what the issue was specific to iOS and Android so can you explain or link someplace if I missed it?

  15. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    @mvtglobally, can you explain this,

    PR #11627 is blocked by #11595

    I couldn't find an explanation so I wasn't sure how those two were related. One suggestion @puneetlath mentioned is the steps in #11627 may not work on a controlled domain and maybe try the same on an uncontrolled domain.

  16. mvtglobally commented on Oct 26, 2022

    @mvtglobally

    @chiragsalian

    PR #11627 is blocked by #11595

    We only have Expensifail domain accounts which are part of the BETA. As per PR steps we need to add a new user to the workspace, but we are getting error when trying to add a user. So team is not able to proceed with steps. If we give gMail account, Can it be added to Beta?

  17. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    Checking off #11627 as per comment.

  18. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android

    Checking off #11839 & #11988 & #11719 since it cannot be tested on staging physical devices. Context.

  19. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    PR #11996 is failing #12139. Its not repro in PROD as behavior is different. Pls double check if this should be a blocker or no

    Yup that's not a blocker. #11996 works fine for its expectation so I'm checking it off.

  20. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    I see a single crash on android for 1.2.19-1 for MaintainVisibleContentPositionHelper.java. Its something we seen before and it seems very rare - issue. I'm moving forward with deploy.

  21. chiragsalian commented on Oct 26, 2022

    @chiragsalian
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions