Skip to content

[$1000] [HOLD for C+ Checklist] Dev: Room - Settings - Non members appears in list of room in offline mode #22353

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to Settings > Workspaces
  2. click on new workspace button
  3. add a few members to workspace
  4. go to offline
  5. click on + icon and choose new room option
  6. enter room name , choose workspace and set Visibility public
  7. click on create room button
  8. go to #room
  9. click on header to see details
  10. click on Members
  11. check the members in list

Expected Result:

all members should not show who is member of Workspaces ( after switching to online it's working fine)

Actual Result:

all members which is invited to workspace is added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev: 1.3.37-2
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-06.at.12.50.38.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688628721649699

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f674f9d8627617b
  • Upwork Job ID: 1681233013381730304
  • Last Price Increase: 2023-07-18

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 6, 2023
  2. melvin-bot commented on Jul 6, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 6, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. kushu7 commented on Jul 6, 2023

    @kushu7
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Settings - Non members appears in list of room in offline mode

    What is the root cause of that problem?

    App/src/libs/actions/Report.js

    Lines 1203 to 1204 in 01a18f0

    // The participants include the current user (admin) and the employees. Participants must not be empty.
    const participants = _.unique([currentUserAccountID, ...policyMembers]);

    Problem is here we are adding allPolicy Member here in optimistic data.
    currently we add all member in restricted room only.

    What changes do you think we should make in order to solve the problem?

    We should update optimistic data to include policyMembers only when room visibility is RESTRICTED

    const members = visibility === CONST.REPORT.VISIBILITY.RESTRICTED ? policyMembers : []
    const participants = _.unique([currentUserAccountID, ...members]);

    this way our optimistic data will be in sync with backend response.

    Video
    small.mov

    What alternative solutions did you explore? (Optional)

    None

  5. OSBotify commented on Jul 6, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Jul 6, 2023

    @melvin-bot

    Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. francoisl commented on Jul 6, 2023

    @francoisl
    Contributor

    Slightly confused, I can reproduce the issue in production and dev, but not on staging.

    image

    At first glance, it looks like the code around this hasn't changed on something that was merged recently, but doesn't exist on staging. Going to review and test this proposal now.

  8. 38 remaining items

  9. kushu7 commented on Jul 18, 2023

    @kushu7
    Contributor

    @greg-schroeder I guess this is also eligible for bonus. As it got merged within 1 day.
    Similar case is here #22351 (comment)

  10. Santhosh-Sellavel commented on Jul 20, 2023

    @Santhosh-Sellavel
    Collaborator

    @francoisl I Had already hovered over part checklist here about the PR which caused or missed this case.

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Do we need a discussion for this @francoisl?

    Let me know if you differ from anything else above, thanks!

  11. Santhosh-Sellavel commented on Jul 20, 2023

    @Santhosh-Sellavel
    Collaborator

    Bug:

    Room - Settings - Non-members appears in the list of room in offline mode

    Regression Steps:

    1. Create a Workspace, and invite at least one additional person to it
    2. Go offline
    3. Click on the + floating button > New Room
    4. Enter a room name, choose the new workspace, set the visibility to Public and create the room
    5. Click on the room's header to see the details
    6. Click on the Members list
    7. Make sure you only see yourself in the Members list
    8. Repeat the operation by creating a Private room, make sure you also only see yourself in the members list
    9. Repeat the operation by creating a Restricted room, and make sure you can also see the other workspace members in the room's members list

    👍 or 👎

    cc: @francoisl @greg-schroeder

  12. Santhosh-Sellavel commented on Jul 20, 2023

    @Santhosh-Sellavel
    Collaborator

    @greg-schroeder

    The checklist is done, waiting for a review from @francoisl!

    About the payment, does this qualify for the bonus as we hired an external contributor?

    Let me know the amount in a comment, so I can proceed with a request on ND, thanks!

  13. francoisl commented on Jul 21, 2023

    @francoisl
    Contributor

    The checklist is done, waiting for a review from @francoisl!

    Reviewed, looks good to me.

    About the payment, does this qualify for the bonus as we hired an external contributor?

    Did we hire an external contributor? We used @kushu7's proposal, who's not an external contributor as far as I know. Let me know if I'm missing something.

  14. kushu7 commented on Jul 21, 2023

    @kushu7
    Contributor

    We used @kushu7's proposal, who's not an external contributor as far as I know

    @francoisl I'm external contributor 😅

  15. greg-schroeder commented on Jul 21, 2023

    @greg-schroeder
    Contributor

    I didn't pay the bonus because we just used the proposal and an Expensify engineer actually implemented the code. To me that seemed most logical as the bonus is there to incentivize speed of implementation, which @kushu7 wasn't involved in beyond the initial idea stage.

    Does that make sense?

  16. francoisl commented on Jul 22, 2023

    @francoisl
    Contributor

    We used @kushu7's proposal, who's not an external contributor as far as I know

    @francoisl I'm external contributor 😅

    Huh sorry guys, it's Friday and I can't think straight 😁😵‍💫 For some reason I was thinking we were talking about agency contributors 😑

    Anyway, @greg-schroeder's explanation makes sense to me regarding the bonus.

  17. kushu7 commented on Jul 22, 2023

    @kushu7
    Contributor

    @greg-schroeder got your point. Thanks for explanation.

  18. greg-schroeder commented on Jul 22, 2023

    @greg-schroeder
    Contributor

    Okay filing for regression test. Closing!

  19. Santhosh-Sellavel commented on Jul 29, 2023

    @Santhosh-Sellavel
    Collaborator

    I see a bonus not applicable based on the comment.

    So Requested a $1K Job fee alone. @greg-schroeder cc: @francoisl

  20. JmillsExpensify commented on Jul 29, 2023

    @JmillsExpensify
    Contributor

    @greg-schroeder Can you please summarize the appropriate individual payments for all parties involved in this issue, per this new compliance process in Slack?

  21. greg-schroeder commented on Jul 31, 2023

    @greg-schroeder
    Contributor

    Hi @JmillsExpensify

    C - @kushu7 - $1,000
    C+ - @Santhosh-Sellavel - $1,000
    Reporter - @gadhiyamanan - $250

  22. JmillsExpensify commented on Jul 31, 2023

    @JmillsExpensify
    Contributor

    Reviewed details for @Santhosh-Sellavel. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions