You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] [HOLD for C+ Checklist] Dev: Room - Settings - Non members appears in list of room in offline mode #22353
enter room name , choose workspace and set Visibility public
click on create room button
go to #room
click on header to see details
click on Members
check the members in list
Expected Result:
all members should not show who is member of Workspaces ( after switching to online it's working fine)
Actual Result:
all members which is invited to workspace is added
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev: 1.3.37-2 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Slightly confused, I can reproduce the issue in production and dev, but not on staging.
At first glance, it looks like the code around this hasn't changed on something that was merged recently, but doesn't exist on staging. Going to review and test this proposal now.
@francoisl I Had already hovered over part checklist here about the PR which caused or missed this case.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Do we need a discussion for this @francoisl?
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. Yes
The checklist is done, waiting for a review from @francoisl!
Reviewed, looks good to me.
About the payment, does this qualify for the bonus as we hired an external contributor?
Did we hire an external contributor? We used @kushu7's proposal, who's not an external contributor as far as I know. Let me know if I'm missing something.
I didn't pay the bonus because we just used the proposal and an Expensify engineer actually implemented the code. To me that seemed most logical as the bonus is there to incentivize speed of implementation, which @kushu7 wasn't involved in beyond the initial idea stage.
@greg-schroeder Can you please summarize the appropriate individual payments for all parties involved in this issue, per this new compliance process in Slack?
Reviewed details for @Santhosh-Sellavel. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.
Activity
melvin-bot commentedon Jul 6, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kushu7 commentedon Jul 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Settings - Non members appears in list of room in offline mode
What is the root cause of that problem?
App/src/libs/actions/Report.js
Lines 1203 to 1204 in 01a18f0
Problem is here we are adding allPolicy Member here in optimistic data.
currently we add all member in restricted room only.
What changes do you think we should make in order to solve the problem?
We should update optimistic data to include policyMembers only when room visibility is
RESTRICTEDthis way our optimistic data will be in sync with backend response.
Video
small.mov
What alternative solutions did you explore? (Optional)
None
OSBotify commentedon Jul 6, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 6, 2023
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.francoisl commentedon Jul 6, 2023
Slightly confused, I can reproduce the issue in production and dev, but not on staging.
At first glance, it looks like the code around this hasn't changed on something that was merged recently, but doesn't exist on staging. Going to review and test this proposal now.
38 remaining items
kushu7 commentedon Jul 18, 2023
@greg-schroeder I guess this is also eligible for bonus. As it got merged within 1 day.
Similar case is here #22351 (comment)
Santhosh-Sellavel commentedon Jul 20, 2023
@francoisl I Had already hovered over part checklist here about the PR which caused or missed this case.
Do we need a discussion for this @francoisl?
Let me know if you differ from anything else above, thanks!
Santhosh-Sellavel commentedon Jul 20, 2023
Bug:
Room - Settings - Non-members appears in the list of room in offline mode
Regression Steps:
👍 or 👎
cc: @francoisl @greg-schroeder
Santhosh-Sellavel commentedon Jul 20, 2023
@greg-schroeder
The checklist is done, waiting for a review from @francoisl!
About the payment, does this qualify for the bonus as we hired an external contributor?
Let me know the amount in a comment, so I can proceed with a request on ND, thanks!
francoisl commentedon Jul 21, 2023
Reviewed, looks good to me.
Did we hire an external contributor? We used @kushu7's proposal, who's not an external contributor as far as I know. Let me know if I'm missing something.
kushu7 commentedon Jul 21, 2023
@francoisl I'm external contributor 😅
greg-schroeder commentedon Jul 21, 2023
I didn't pay the bonus because we just used the proposal and an Expensify engineer actually implemented the code. To me that seemed most logical as the bonus is there to incentivize speed of implementation, which @kushu7 wasn't involved in beyond the initial idea stage.
Does that make sense?
francoisl commentedon Jul 22, 2023
Huh sorry guys, it's Friday and I can't think straight 😁😵💫 For some reason I was thinking we were talking about agency contributors 😑
Anyway, @greg-schroeder's explanation makes sense to me regarding the bonus.
kushu7 commentedon Jul 22, 2023
@greg-schroeder got your point. Thanks for explanation.
greg-schroeder commentedon Jul 22, 2023
Okay filing for regression test. Closing!
Santhosh-Sellavel commentedon Jul 29, 2023
I see a bonus not applicable based on the comment.
So Requested a $1K Job fee alone. @greg-schroeder cc: @francoisl
JmillsExpensify commentedon Jul 29, 2023
@greg-schroeder Can you please summarize the appropriate individual payments for all parties involved in this issue, per this new compliance process in Slack?
greg-schroeder commentedon Jul 31, 2023
Hi @JmillsExpensify
C - @kushu7 - $1,000
C+ - @Santhosh-Sellavel - $1,000
Reporter - @gadhiyamanan - $250
JmillsExpensify commentedon Jul 31, 2023
Reviewed details for @Santhosh-Sellavel. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.