Skip to content

Deploy Checklist: New Expensify 2023-07-10 #22598

Closed

Description

@OSBotify

Release Version: 1.3.39-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. francoisl commented on Jul 11, 2023

    @francoisl
    Contributor

    Going to check the following PRs that were CP'ed for the previous checklist and already tested:

    • 22595
    • 22584
    • 22501
  2. OSBotify commented on Jul 11, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.39-5 🚀

  3. mvtglobally commented on Jul 11, 2023

    @mvtglobally

    Can you check this internally #20363 (comment)

  4. self-assigned this
    on Jul 11, 2023
  5. mvtglobally commented on Jul 11, 2023

    @mvtglobally

    @francoisl regression is in progress. we still have about 35% to go

    We are still working on the 20 PR validations across platforms

  6. francoisl commented on Jul 11, 2023

    @francoisl
    Contributor

    👍 Thanks for the update. I took care of that internal QA, and we're working on the 2 open blockers in the meantime.

  7. mvtglobally commented on Jul 11, 2023

    @mvtglobally

    PR #20841 is failing #20841
    PR #21918 is failing #22640

  8. mvtglobally commented on Jul 11, 2023

    @mvtglobally

    @francoisl
    #21364 is PROD QA, are we ok to check it off?
    #21807 (comment) This is unclear on what needs to be tested. Can we get updated QA steps or just validate this internally?

  9. francoisl commented on Jul 11, 2023

    @francoisl
    Contributor

    #21364 is PROD QA, are we ok to check it off?

    Yes let's check it off

    #21807 (comment) This is unclear on what needs to be tested. Can we get updated QA steps or just validate this internally?

    I'll take care of this internally, and ask the author if needed.
    Edit: done internally

  10. mvtglobally commented on Jul 12, 2023

    @mvtglobally

    #20497 is is failing as we are getting Continuous loading spinner after removing the member from workspace on user A & also repro old KI #19994. Pls double check

  11. Julesssss commented on Jul 12, 2023

    @Julesssss
    Contributor

    I checked off #22742 because it is too minor to be a blocker.

  12. mvtglobally commented on Jul 12, 2023

    @mvtglobally

    @Julesssss @francoisl Regression is completed

    Final summary
    #20497 is is failing as we are getting Continuous loading spinner after removing the member from workspace on user A & also repro old KI #19994. Pls double check
    #20512 pending validation on all platform.
    PR #20841 is failing #20841
    PR #21918 is failing #22640
    #21767 (comment)
    #22075 is failing #22747
    #22324 pending validation on all platform.
    #22369 is failing #22682

  13. 3 remaining items

  14. arosiclair commented on Jul 12, 2023

    @arosiclair
    Contributor

    Removed blocker label from #22747. Issue is already on prod.

  15. francoisl commented on Jul 12, 2023

    @francoisl
    Contributor

    The fix for the last blocker is being cherry-picked right now, I'll test it on staging and if all goes well, we'll be good to go.

  16. mvtglobally commented on Jul 12, 2023

    @mvtglobally

    @francoisl keep us posted if you want us to QA or you can Internally validate faster

  17. francoisl commented on Jul 12, 2023

    @francoisl
    Contributor

    Thanks. I'll take care of it, it should be pretty quick.

  18. francoisl commented on Jul 12, 2023

    @francoisl
    Contributor

    QA passes for the last CP, everything is checked, going to close and ship this.

  19. francoisl commented on Jul 12, 2023

    @francoisl
    Contributor

    :shipit:

  20. francoisl commented on Jul 12, 2023

    @francoisl
    Contributor

    The deploy failed due to a protection on the production branch. Looking into it now, but reopening this so that no other PRs get accidentally deployed to staging in the meantime.

  21. OSBotify commented on Jul 13, 2023

    @OSBotify
    ContributorAuthor

    This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
    Reopening!

  22. francoisl commented on Jul 13, 2023

    @francoisl
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions