Repository navigation
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Not sure why melvin didn't request a review from @Julesssss 🤔 The changes looks good, I will try to test it in the morning. |
|
@BhuvaneshPatil, you missed this item. You need to check off all the items, otherwise the test will fail. |
|
@thesahindia , Updated the checklist |
thesahindia
left a comment
There was a problem hiding this comment.
Let's add a display name for this component. Also please resolve the conflicts.
…grate-MoneyRequestAmountPage
|
Friendly bump @Julesssss @thesahindia |
|
@BhuvaneshPatil, the amount changes to 0 when I choose a different currency Screen.Recording.2023-06-23.at.1.57.25.AM.mov |
|
Thank you for pointing out @thesahindia . That occurred while resolving merge conflicts |
|
Taking this one as C+ (reviewer) |
…78-migrate-MoneyRequestAmountPage
|
@BhuvaneshPatil Let me know when this is ready for re-review |
|
Hi @s77rt , I am working on the useEffect refactoring, will let you know once done |
|
@s77rt I have pushed the changes, I think there are still more improvements need to be done for |
s77rt
left a comment
There was a problem hiding this comment.
Let's try prioritise the case stated in updateAmount.
Also found a bug, can't modify amount:
- Start money request
- Type any amount
- Press Next
- Select participants
- Press Next
- Click on Amount
You should be on send/new/amount but instead you are redirected to send/new (starting the request from the beginning)
…78-migrate-MoneyRequestAmountPage
|
@BhuvaneshPatil @s77rt Can we please prioritize getting this one over the finish line? |
|
@BhuvaneshPatil I see the commits now. Seems to cover only two concerns: the |
|
Bug that you have mentioned is resolved. PS - It was happening because I forgot to add |
…78-migrate-MoneyRequestAmountPage
|
@s77rt , updated the code |
|
@BhuvaneshPatil Thanks! Can you please resolve the conflicts? |
|
Yes @s77rt . Working on them. There we have new method - I have wrapped it in the useCallback, and added to dependency array. Tested it - Working as expected. |
|
I don't see the need of useCallback here. Just wrap the function in it's own useEffect |
@s77rt Sorry, but I am afraid that I don't understand what you are implying here Do you meant to say that, create a new useEffect and have this function inside it - |
|
@BhuvaneshPatil Yes, that should do it; but |
|
@s77rt I have updated the code for dismiss modal |
|
@BhuvaneshPatil Awesome! Code looking good. While testing on iOS I noticed some cursor jump behaviour, I think this bug exists in main but the jump behaviour seems to happen more often. Can you please confirm from your side if this is a regression or not? |
Reviewer Checklist
Screenshots/Videos |
|
@mountiny We are probably good to merge, just need a confirmation from @BhuvaneshPatil about the iOS behaviour, it's seems to have a buggy cursor but I'm getting this on main too. So I guess we can move on with that |
|
@s77rt , I checked on master and new implementation. The jumpy behavior is at both places |
|
@BhuvaneshPatil Thanks for the confirmation. |
mountiny
left a comment
There was a problem hiding this comment.
One minor comment otherwise looking good.
All yours @Julesssss!
|
Just waiting for a lint PR fix to avoid errors once merged. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀
|
| start: selectedAmountAsStringForState.length, | ||
| end: selectedAmountAsStringForState.length, | ||
| }); | ||
| }, [props.iou.amount, props.iou.currency]); |
There was a problem hiding this comment.
Hi, this PR caused a regression/bug - Currency changes after refresh although URL has currency params
#23436
more details here - #23436 (comment)
There was a problem hiding this comment.
Interesting! Previously we used the componentDidUpdate method which only occurs after an update while the useEffect is triggered also on the initial render (ignoring dependencies).







Details>
Refactoring
MoneyRequestAmountPageto a functional componentFixed Issues
$ #16278
PROPOSAL: #16278 (comment)
Tests
MoneyRequestAmountPageit's opened when we create a Split Bill or Request Money or Send MoneyOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Google.Desktop.web.-.Made.with.Clipchamp.mp4
Mobile Web - Chrome
Mobile.-.Web.mp4
Mobile Web - Safari
Mobile.web.safari.mp4
Desktop
desktop.-.Made.with.Clipchamp.mp4
iOS
ios.-.Made.with.Clipchamp.mp4
Android
Android.-.Made.with.Clipchamp.mp4