Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open an initial issue - [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918
- Read a proposal - [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918 (comment)
- Read important comments, starts from the next one- [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918 (comment)
Expected Result:
Actually, the Expensify app already uses react-pdf to preview PDF files. However, it does not support the large PDF files. The idea is to create, own and maintain a package. It should support the large PDF files. It is helpful to the community, if the package can be widely used for performance improved PDF viewer. The Expensify application uses the package instead of an internal implementation.
Actual Result:
This is an internal implementation. Recently, we fixed and improved the previewing of large PDF files, directly updating our own codebase - #22760.
Workaround:
The user still can use Expensify without this being fixed.
Area issue was found in:
I was found during the investigating/fixing the next issue - #19918.
Failed WCAG checkpoints
N/A
User impact:
It does not affect the user. It has an impact on the community.
Suggested resolution:
- Create a repository within the Expensify organisation.
- Implement own PDF previewer based on react-pdf and react-window.
- Add and use the previewer in the Expensify app.
- Publish the package.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: Mykhailo Kravchenko - Callstack
Slack conversation: N/A
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f329b3f580153b04
- Upwork Job ID: 1683525690767454208
- Last Price Increase: 2023-07-24
Activity
rezkiy37 commentedon Jul 19, 2023
Hi, @allroundexperts!
In order of our agreement, could you please:
Thank you!
allroundexperts commentedon Jul 19, 2023
Hi @rezkiy37!
My understanding was that the package would be created in my git account. I don't really have access to create a repository inside the Expensify organisation. We might want to confirm this again in the bug report?
AndrewGable commentedon Jul 24, 2023
What is the repository name? I can get one made with correct permissions. Thank you
rezkiy37 commentedon Jul 24, 2023
@AndrewGable, are you able to create a repository within Expensify organisation?
rezkiy37 commentedon Jul 24, 2023
We haven't considered names yet. I believe
react-fast-pdfwould be cool one.allroundexperts commentedon Jul 24, 2023
Agreed!
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to @nathanmetcalf (
ring0), see https://stackoverflow.com/c/expensify/questions/6102 for more details.melvin-bot commentedon Jul 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f329b3f580153b04
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)AndrewGable commentedon Jul 24, 2023
@nathanmetcalf - Please create an public Expensify repository named
react-fast-pdf.We will publish under npm under
@Expensify/react-fast-pdf. Please ping me once it's ready to publish on npm.cc @puneetlath @mountiny
147 remaining items
allroundexperts commentedon Apr 4, 2024
@mountiny Updated!
allroundexperts commentedon Apr 4, 2024
I reviewed the following PRs as part of this ticket:
Expensify/react-fast-pdf#1
Expensify/react-fast-pdf#2
Expensify/react-fast-pdf#8
Expensify/react-fast-pdf#12
Expensify/react-fast-pdf#14
#33434
The first two I think were during the time we were paying 1k per bug / review.
mountiny commentedon Apr 4, 2024
@allroundexperts @rezkiy37 Just to make sure are we all done here in terms of the steps we planned for the library?
if this ready to pay out and close?
allroundexperts commentedon Apr 4, 2024
I think yes, we're done here. @rezkiy37 can confirm though.
rezkiy37 commentedon Apr 5, 2024
Yes. The idea was to share the bugfix with the community. The package inherits the previous app behavior with all fixes and improvements. I would say that the 1st version of
react-fast-pdfis done. All further changes we should consider are the 2nd version of the package.We are done with this issue.
cc @mountiny @allroundexperts
mountiny commentedon Apr 5, 2024
Thank you, the payment summary would be:
Expensify/react-fast-pdf#1 - $1000
Expensify/react-fast-pdf#2 - $1000
Expensify/react-fast-pdf#8 - $500
Expensify/react-fast-pdf#12 - $500
Expensify/react-fast-pdf#14 - $500
#33434 - $500
So $4000 to @allroundexperts for their work on this project with @rezkiy37 its taken a long time and many hours of testing and review so I think this is reasonable.
mountiny commentedon Apr 5, 2024
cc @anmurali
melvin-bot commentedon Apr 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@anmurali)
anmurali commentedon Apr 17, 2024
Per #22998 (comment)
s77rt commentedon Apr 17, 2024
I'm not due payment here. This can be closed
mountiny commentedon Apr 17, 2024
I believe @allroundexperts will be handled in newdot then, so closing, thanks everyone!
JmillsExpensify commentedon Apr 30, 2024
$4,000 approved for @allroundexperts