Skip to content

[HOLD for payment 2024-04-05] Convert internal PDF preview into a public library #22998

Closed

Description

@rezkiy37

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open an initial issue - [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918
  2. Read a proposal - [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918 (comment)
  3. Read important comments, starts from the next one- [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file #19918 (comment)

Expected Result:

Actually, the Expensify app already uses react-pdf to preview PDF files. However, it does not support the large PDF files. The idea is to create, own and maintain a package. It should support the large PDF files. It is helpful to the community, if the package can be widely used for performance improved PDF viewer. The Expensify application uses the package instead of an internal implementation.

Actual Result:

This is an internal implementation. Recently, we fixed and improved the previewing of large PDF files, directly updating our own codebase - #22760.

Workaround:

The user still can use Expensify without this being fixed.

Area issue was found in:

I was found during the investigating/fixing the next issue - #19918.

Failed WCAG checkpoints

N/A

User impact:

It does not affect the user. It has an impact on the community.

Suggested resolution:

  1. Create a repository within the Expensify organisation.
  2. Implement own PDF previewer based on react-pdf and react-window.
  3. Add and use the previewer in the Expensify app.
  4. Publish the package.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: Mykhailo Kravchenko - Callstack
Slack conversation: N/A

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f329b3f580153b04
  • Upwork Job ID: 1683525690767454208
  • Last Price Increase: 2023-07-24
Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. rezkiy37 commented on Jul 19, 2023

    @rezkiy37
    ContributorAuthor

    Hi, @allroundexperts!
    In order of our agreement, could you please:

    1. Create a repository within the Expensify organisation. We will work there.
    2. Describe how we create own package step by step.

    Thank you!

  2. allroundexperts commented on Jul 19, 2023

    @allroundexperts
    Contributor

    Hi @rezkiy37!
    My understanding was that the package would be created in my git account. I don't really have access to create a repository inside the Expensify organisation. We might want to confirm this again in the bug report?

  3. AndrewGable commented on Jul 24, 2023

    @AndrewGable
    Contributor

    What is the repository name? I can get one made with correct permissions. Thank you

  4. rezkiy37 commented on Jul 24, 2023

    @rezkiy37
    ContributorAuthor

    What is the repository name? I can get one made with correct permissions. Thank you

    @AndrewGable, are you able to create a repository within Expensify organisation?

  5. rezkiy37 commented on Jul 24, 2023

    @rezkiy37
    ContributorAuthor

    We haven't considered names yet. I believe react-fast-pdf would be cool one.

  6. allroundexperts commented on Jul 24, 2023

    @allroundexperts
    Contributor

    Agreed!

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jul 24, 2023
  8. melvin-bot commented on Jul 24, 2023

    @melvin-bot

    Triggered auto assignment to @nathanmetcalf (ring0), see https://stackoverflow.com/c/expensify/questions/6102 for more details.

  9. melvin-bot commented on Jul 24, 2023

    @melvin-bot
  10. melvin-bot commented on Jul 24, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

  11. AndrewGable commented on Jul 24, 2023

    @AndrewGable
    Contributor

    @nathanmetcalf - Please create an public Expensify repository named react-fast-pdf.

    We will publish under npm under @Expensify/react-fast-pdf. Please ping me once it's ready to publish on npm.

    cc @puneetlath @mountiny

  12. 147 remaining items

  13. allroundexperts commented on Apr 4, 2024

    @allroundexperts
    Contributor

    @mountiny Updated!

  14. allroundexperts commented on Apr 4, 2024

    @allroundexperts
    Contributor

    I reviewed the following PRs as part of this ticket:

    Expensify/react-fast-pdf#1
    Expensify/react-fast-pdf#2
    Expensify/react-fast-pdf#8
    Expensify/react-fast-pdf#12
    Expensify/react-fast-pdf#14

    #33434

    The first two I think were during the time we were paying 1k per bug / review.

  15. mountiny commented on Apr 4, 2024

    @mountiny
    Contributor

    @allroundexperts @rezkiy37 Just to make sure are we all done here in terms of the steps we planned for the library?

    if this ready to pay out and close?

  16. allroundexperts commented on Apr 4, 2024

    @allroundexperts
    Contributor

    I think yes, we're done here. @rezkiy37 can confirm though.

  17. rezkiy37 commented on Apr 5, 2024

    @rezkiy37
    ContributorAuthor

    Yes. The idea was to share the bugfix with the community. The package inherits the previous app behavior with all fixes and improvements. I would say that the 1st version of react-fast-pdf is done. All further changes we should consider are the 2nd version of the package.

    We are done with this issue.

    cc @mountiny @allroundexperts

  18. mountiny commented on Apr 5, 2024

    @mountiny
    Contributor

    Thank you, the payment summary would be:

    Expensify/react-fast-pdf#1 - $1000
    Expensify/react-fast-pdf#2 - $1000
    Expensify/react-fast-pdf#8 - $500
    Expensify/react-fast-pdf#12 - $500
    Expensify/react-fast-pdf#14 - $500
    #33434 - $500

    So $4000 to @allroundexperts for their work on this project with @rezkiy37 its taken a long time and many hours of testing and review so I think this is reasonable.

  19. mountiny commented on Apr 5, 2024

    @mountiny
    Contributor
  20. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)
    • Reviewer: @allroundexperts owed $250 via NewDot
    • Contributor: @rezkiy37 is from an agency-contributor and not due payment

    BugZero Checklist (@anmurali)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1683525690767454208/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  21. anmurali commented on Apr 17, 2024

    @anmurali
  22. s77rt commented on Apr 17, 2024

    @s77rt
    Member

    I'm not due payment here. This can be closed

  23. mountiny commented on Apr 17, 2024

    @mountiny
    Contributor

    I believe @allroundexperts will be handled in newdot then, so closing, thanks everyone!

  24. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    Contributor

    $4,000 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.WeeklyKSv2ring0

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions