Skip to content

Feature/22998 pdf password handling - #8

Merged
mountiny merged 13 commits into
Expensify:mainfrom
rezkiy37:feature/22998-pdf-password-handling
Dec 11, 2023
Merged

mountiny merged 13 commits into
Expensify:mainfrom
rezkiy37:feature/22998-pdf-password-handling

Conversation

@rezkiy37

@rezkiy37 rezkiy37 commented Nov 28, 2023 •

Copy link
Copy Markdown
Contributor

Details

The PR introduces password handling for protected pdf files. Also, starting from this PR, the example/ starts using react-fast-pdf directly from NPM.

Related Issues

Expensify/App#22998

Manual Tests

For testing locally and running in development mode, you need do a couple steps:

  1. In example/package.json change react-fast-pdf value to "../src".
  2. In example/tsconfig.json change rootDir value to "../".

Linked PRs

N/A

PDF.mov

Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPasswordForm.tsx Resolved
Comment thread src/PDFPreviewer.tsx Resolved
@rezkiy37
rezkiy37 requested a review from fabioh8010 December 6, 2023 13:09
@allroundexperts

Copy link
Copy Markdown

Works good!

Screen.Recording.2023-12-11.at.6.57.47.AM.mov

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mountiny
mountiny merged commit 55f09e3 into Expensify:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants