You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-24] [$1000] Web - Task Detail screen is empty #23296
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.43-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
When following the steps to create a new task, the user fills in the required information such as the Title and clicks on the "Next" button. Upon reaching the "Confirm Task" page and clicking the "Confirm Task" button, a new task should be created and the Detail Screen should be populated with the task details. However, the Detail Screen remains empty, displaying no information about the newly created task.
What is the root cause of that problem?
navigateToDetailsPage ( in ReportUtils.js ) doesn't have any option for task detail page unlike other things like ChatRoom and ChatThread.
What changes do you think we should make in order to solve the problem?
So we should add this option for this function for task detail and also add the necesary details:
function navigateToDetailsPage(report) {
const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []);
if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {
Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID));
return;
}
if (participantAccountIDs.length === 1) {
Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0]));
return;
}
Navigation.navigate(ROUTES.getReportParticipantsRoute(report.reportID));
}
In fact, when the navigate task detail is opened, this function is called, but it is not true in any of the conditions, so the detail will be empty. So the relevant condition should be added.
changed the title [-][$1000] Web - Task Detail screen is empty[/-][+][HOLD for payment 2023-08-24] [$1000] Web - Task Detail screen is empty[/+]on Aug 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 20, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)proshir commentedon Jul 20, 2023
Yeah. I could reproduce this problem too.
So I gonna work on this issue .
proshir commentedon Jul 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When following the steps to create a new task, the user fills in the required information such as the Title and clicks on the "Next" button. Upon reaching the "Confirm Task" page and clicking the "Confirm Task" button, a new task should be created and the Detail Screen should be populated with the task details. However, the Detail Screen remains empty, displaying no information about the newly created task.
What is the root cause of that problem?
navigateToDetailsPage ( in ReportUtils.js ) doesn't have any option for task detail page unlike other things like ChatRoom and ChatThread.
What changes do you think we should make in order to solve the problem?
So we should add this option for this function for task detail and also add the necesary details:
In fact, when the navigate task detail is opened, this function is called, but it is not true in any of the conditions, so the detail will be empty. So the relevant condition should be added.
Nodebrute commentedon Jul 20, 2023
@jasperhuangg This issue was supposed to be handled in this pull request #22498
Santhosh-Sellavel commentedon Jul 20, 2023
Thanks, @Nodebrute, and @Jasper We caught this while reviewing as well. I was told here will be handled in another issue.
Nodebrute commentedon Jul 20, 2023
@tjferriss you can close this issue.
[-]Web - Task Detail screen is empty[/-][+][$1000] Web - Task Detail screen is empty[/+]melvin-bot commentedon Jul 21, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f23789ed29030efc
melvin-bot commentedon Jul 21, 2023
Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.
9 remaining items
[-][$1000] Web - Task Detail screen is empty[/-][+][HOLD for payment 2023-08-24] [$1000] Web - Task Detail screen is empty[/+]melvin-bot commentedon Aug 17, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: