Skip to content

[HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted #24608

Closed

Description

@mountiny

Following on this PR #24590, once we are going to switch from using IOU report actions for the transaction dat to transaction objects which should be done here #24345, we should stop hiding the MoneyRequestView as we do here but we should add transaction as props to the ReportActionItem and re-render when it changes. Deleted transaction is wiped from the onyx.

cc @dukenv0307

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0195265ecd3403c746
  • Upwork Job ID: 1692289426335956992
  • Last Price Increase: 2023-08-17

Activity

  1. self-assigned this
    on Aug 15, 2023
  2. melvin-bot commented on Aug 15, 2023

    @melvin-bot
  3. melvin-bot commented on Aug 15, 2023

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  4. mountiny commented on Aug 15, 2023

    @mountiny
    ContributorAuthor

    No need for design review here. sorry for the ping

  5. mountiny commented on Aug 17, 2023

    @mountiny
    ContributorAuthor

    I will ask in Callstack or SWM channels if anyone wants to take this one

  6. luacmartins commented on Aug 17, 2023

    @luacmartins
    Contributor

    I can work on this one

  7. 13 remaining items

  8. luacmartins commented on Aug 25, 2023

    @luacmartins
    Contributor

    We're currently refactoring this command. I'll check again once those PRs have been deployed

  9. changed the title [-]Re-render the ReportActionItem when transaction is deleted[/-] [+][HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted[/+] on Aug 25, 2023
  10. luacmartins commented on Aug 25, 2023

    @luacmartins
    Contributor

    The App PR was deployed to prod 2 days ago. Updating the title with the payment date.

  11. garrettmknight commented on Aug 31, 2023

    @garrettmknight
    Contributor

    @luacmartins could this be causing #26205 as well?

  12. luacmartins commented on Aug 31, 2023

    @luacmartins
    Contributor

    No, I don't think that issue is related to this.

  13. CortneyOfstad commented on Sep 1, 2023

    @CortneyOfstad
    Contributor

    So according to this SO @eVoloshchak gets paid via eChat. Has payment been received? If not, please let me know and we can get that bumped. TIA!

  14. eVoloshchak commented on Sep 3, 2023

    @eVoloshchak
    Contributor

    @CortneyOfstad, I just requested the payment via NewDot, thanks!

  15. CortneyOfstad commented on Sep 8, 2023

    @CortneyOfstad
    Contributor

    @eVoloshchak just confirming if the payment was successful or not? If so, we can close this out 👍

  16. JmillsExpensify commented on Sep 10, 2023

    @JmillsExpensify
    Contributor

    @CortneyOfstad This is missing a payment summary. I need that before I can pay via NewDot.

  17. CortneyOfstad commented on Sep 11, 2023

    @CortneyOfstad
    Contributor

    From what I can see, Eugene was assigned to the issue on 8/17. It shows that the PR went into production on 8/22, but it shows that a QA delayed the PR going into production, so while they did not qualify for the bonus, they would not receive the penalty.

    Payment due: $1000 to @eVoloshchak

    CC @JmillsExpensify

  18. CortneyOfstad commented on Sep 18, 2023

    @CortneyOfstad
    Contributor

    @JmillsExpensify @eVoloshchak was payment confirmed in NewDot? Just checking to see if this can be closed — thanks!

  19. eVoloshchak commented on Sep 21, 2023

    @eVoloshchak
    Contributor

    @CortneyOfstad, it wasn't confirmed yet, but I requested it, I think the issue can be closed (we can open it back again if needed)

  20. JmillsExpensify commented on Sep 21, 2023

    @JmillsExpensify
    Contributor

    $1,000 payment for @eVoloshchak approved based on BZ summary.

  21. CortneyOfstad commented on Sep 25, 2023

    @CortneyOfstad
    Contributor

    Looks good to close! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions