You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted #24608
Following on this PR #24590, once we are going to switch from using IOU report actions for the transaction dat to transaction objects which should be done here #24345, we should stop hiding the MoneyRequestView as we do here but we should add transaction as props to the ReportActionItem and re-render when it changes. Deleted transaction is wiped from the onyx.
changed the title [-]Re-render the ReportActionItem when transaction is deleted[/-][+][HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted[/+]on Aug 25, 2023
From what I can see, Eugene was assigned to the issue on 8/17. It shows that the PR went into production on 8/22, but it shows that a QA delayed the PR going into production, so while they did not qualify for the bonus, they would not receive the penalty.
Activity
melvin-bot commentedon Aug 15, 2023
Triggered auto assignment to @CortneyOfstad (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Aug 15, 2023
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)mountiny commentedon Aug 15, 2023
No need for design review here. sorry for the ping
mountiny commentedon Aug 17, 2023
I will ask in Callstack or SWM channels if anyone wants to take this one
luacmartins commentedon Aug 17, 2023
I can work on this one
13 remaining items
luacmartins commentedon Aug 25, 2023
We're currently refactoring this command. I'll check again once those PRs have been deployed
[-]Re-render the ReportActionItem when transaction is deleted[/-][+][HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted[/+]luacmartins commentedon Aug 25, 2023
The App PR was deployed to prod 2 days ago. Updating the title with the payment date.
garrettmknight commentedon Aug 31, 2023
@luacmartins could this be causing #26205 as well?
luacmartins commentedon Aug 31, 2023
No, I don't think that issue is related to this.
CortneyOfstad commentedon Sep 1, 2023
So according to this SO @eVoloshchak gets paid via eChat. Has payment been received? If not, please let me know and we can get that bumped. TIA!
eVoloshchak commentedon Sep 3, 2023
@CortneyOfstad, I just requested the payment via NewDot, thanks!
CortneyOfstad commentedon Sep 8, 2023
@eVoloshchak just confirming if the payment was successful or not? If so, we can close this out 👍
JmillsExpensify commentedon Sep 10, 2023
@CortneyOfstad This is missing a payment summary. I need that before I can pay via NewDot.
CortneyOfstad commentedon Sep 11, 2023
From what I can see, Eugene was assigned to the issue on 8/17. It shows that the PR went into production on 8/22, but it shows that a QA delayed the PR going into production, so while they did not qualify for the bonus, they would not receive the penalty.
Payment due: $1000 to @eVoloshchak
CC @JmillsExpensify
CortneyOfstad commentedon Sep 18, 2023
@JmillsExpensify @eVoloshchak was payment confirmed in NewDot? Just checking to see if this can be closed — thanks!
eVoloshchak commentedon Sep 21, 2023
@CortneyOfstad, it wasn't confirmed yet, but I requested it, I think the issue can be closed (we can open it back again if needed)
JmillsExpensify commentedon Sep 21, 2023
$1,000 payment for @eVoloshchak approved based on BZ summary.
CortneyOfstad commentedon Sep 25, 2023
Looks good to close! Thanks everyone!