You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] IOU - IOU report is duplicated in LHN after emptying Merchant field and saving it #26205
But iouReport.report is undefined (this should be a typo), so report_undefined will be merged into Onyx.
Because report_undefined's content is just same with iouReport, so this will be displayed in LHN.
Therefore, IOU report is duplicated.
What changes do you think we should make to solve the problem?
Merchant field should not be empty and this is fixed by #26373.
We only need to change iouReport.report to iouReport.reportID in this line.
What alternative solutions have you investigated? (Optional)
changed the title [-]IOU - IOU report is duplicated in LHN after emptying Merchant field and saving it[/-][+][$500] IOU - IOU report is duplicated in LHN after emptying Merchant field and saving it[/+]on Aug 31, 2023
@StevenKKC / @jjcoffee sorry for the wait on this one, slipped through the cracks with the 'Reviewing' label on it. Since this was such a small change, I'm going to forgo the urgency bonus.
@garrettmknight I am afraid to let you know that My Upwork account is suspended so I couldn't get paid with my account. May I send proposal with my friend's account?
Activity
melvin-bot commentedon Aug 29, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon Aug 29, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
IOU report is duplicated in LHN after emptying Merchant field and saving it.
What is the cause of this issue?
After emptying merchant field and saving it, BE returns error as below.

So the following
failureDatais merged.App/src/libs/actions/IOU.js
Lines 1020 to 1038 in 766dd65
But
iouReport.reportisundefined(this should be a typo), soreport_undefinedwill be merged intoOnyx.Because
report_undefined's content is just same withiouReport, so this will be displayed in LHN.Therefore, IOU report is duplicated.
What changes do you think we should make to solve the problem?
Merchant field should not be empty and this is fixed by #26373.
We only need to change
iouReport.reporttoiouReport.reportIDin this line.What alternative solutions have you investigated? (Optional)
None.
garrettmknight commentedon Aug 31, 2023
Might be related to #24608 (comment)
luacmartins commentedon Aug 31, 2023
I don't think this issue is related to #24608 (comment)
garrettmknight commentedon Aug 31, 2023
Cool, reproduced and I'll open it up!
[-]IOU - IOU report is duplicated in LHN after emptying Merchant field and saving it[/-][+][$500] IOU - IOU report is duplicated in LHN after emptying Merchant field and saving it[/+]melvin-bot commentedon Aug 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a14404ef51543e9e
melvin-bot commentedon Aug 31, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
29 remaining items
garrettmknight commentedon Oct 11, 2023
@StevenKKC / @jjcoffee sorry for the wait on this one, slipped through the cracks with the 'Reviewing' label on it. Since this was such a small change, I'm going to forgo the urgency bonus.
Summarizing payments for this issue:
Upwork job: https://www.upwork.com/en-gb/ab/applicants/1697289310359842816/job-details
garrettmknight commentedon Oct 11, 2023
@StevenKKC Going to move this to monthly while your Upwork account gets sorted out. Ping me when it does and I'll complete payment.
StevenKKC commentedon Oct 12, 2023
@garrettmknight I am afraid to let you know that My Upwork account is suspended so I couldn't get paid with my account. May I send proposal with my friend's account?
melvin-bot commentedon Oct 25, 2023
@puneetlath, @garrettmknight, @jjcoffee, @StevenKKC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
garrettmknight commentedon Oct 25, 2023
Hey @StevenKKC we're only able to pay through your account since it's verified by Upwork. Once you've got your Upwork account working again I'll pay.
melvin-bot commentedon Dec 22, 2023
@puneetlath, @garrettmknight, @jjcoffee, @StevenKKC, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.