You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request #26737
Please re-state the problem that we are trying to solve in this issue.
Distance - Next button hidden and unable to complete distance money request
What is the root cause of that problem?
In our DistanceRequest page, we have difference view with difference minHeight ( 128 for waypoint, 300 for the map), because of that when the screen size is too small, the Next button will be hidden.
What changes do you think we should make in order to solve the problem?
We should wrap the content (except the Next button) inside a View, and wrap the Next button with FixedFooter.
<><Viewstyle={[styles.flex1,styles.overflowHidden]}>{/** All the content */}</View><FixedFooterstyle={[styles.w100,styles.ph4,styles.flexShrink0]}><ButtonsuccessonPress={()=>IOU.navigateToNextPage(iou,iouType,reportID,report)}isDisabled={_.size(validatedWaypoints)<2}text={translate('common.next')}/></FixedFooter>
What alternative solutions did you explore? (Optional)
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/-][+][HOLD for payment 2023-09-15] [HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/+]on Sep 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@alexpensify Just checking in here. My PR for this was initially deployed to production on 2023-09-06 (reference), so it looks like the correct payment date is 2023-09-13, and the bot got a little carried away.
@mountiny Do I need to do anything with the checklist here?
changed the title [-][HOLD for payment 2023-09-15] [HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/-][+][HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/+]on Sep 14, 2023
@akinwale - sorry, I was OOO the past two days and still catching up. I thought the payment date was on September 15, so that's why I didn't reassign. Can you please apply for the job here: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e? Tomorrow, I'll complete the payment process. Thanks!
Activity
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon Sep 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance - Next button hidden and unable to complete distance money request
What is the root cause of that problem?
In our DistanceRequest page, we have difference view with difference
minHeight( 128 for waypoint, 300 for the map), because of that when the screen size is too small, theNextbutton will be hidden.What changes do you think we should make in order to solve the problem?
We should wrap the content (except the
Nextbutton) inside a View, and wrap theNextbutton withFixedFooter.What alternative solutions did you explore? (Optional)
N/A
Result
Screen.Recording.2023-09-05.at.10.32.29.mov
hungvu193 commentedon Sep 5, 2023
oh found out it's dupe of: #26541
OSBotify commentedon Sep 5, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @Gonals (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.55 remaining items
[-][HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/-][+][HOLD for payment 2023-09-15] [HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/+]melvin-bot commentedon Sep 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 8, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
akinwale commentedon Sep 13, 2023
@alexpensify Just checking in here. My PR for this was initially deployed to production on 2023-09-06 (reference), so it looks like the correct payment date is 2023-09-13, and the bot got a little carried away.
@mountiny Do I need to do anything with the checklist here?
mountiny commentedon Sep 14, 2023
I think we dont need the cheklist here as it was a new feature for the conference so not really regressions
[-][HOLD for payment 2023-09-15] [HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/-][+][HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request[/+]alexpensify commentedon Sep 15, 2023
@akinwale - sorry, I was OOO the past two days and still catching up. I thought the payment date was on September 15, so that's why I didn't reassign. Can you please apply for the job here: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e? Tomorrow, I'll complete the payment process. Thanks!
akinwale commentedon Sep 15, 2023
@alexpensify Applied. Thanks!
alexpensify commentedon Sep 15, 2023
Thanks, I've continued the process in Upwork and need you to accept @akinwale.
akinwale commentedon Sep 15, 2023
@alexpensify Accepted, thanks.
alexpensify commentedon Sep 15, 2023
Awesome, I've completed the process in Upwork. Thanks for your help here!
alexpensify commentedon Sep 18, 2023
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: N/A