You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-13] [$500] [Distance] - App does not refocus on address field on delete and cancel #27182
App should focus back on address field on delete and cancel as we do for normal report messages
Actual Result:
App does not focus back on address field on delete and cancel
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.67.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-][Distance] - App does not refocus on address field on delete and cancel[/-][+][$500] [Distance] - App does not refocus on address field on delete and cancel[/+]on Sep 11, 2023
@Beamanator sorry, I totally missed your question the first time. The summary of this GH is that we've introduced no changes to the app and the GH will be closed as expected behavior. I see you've added them both to the tracking issue, thanks! I think that's the best course of action - we can come back to these GHs at a later date and approach more holistically, because honestly it's not efficient trying to address them each separately with a different group of individuals.
External issue reporter – @dhanashree-sawant paid $25 (50%) in Upwork
Contributor that fixed the issue — @Krishna2323 paid $250 (50%) in Upwork
Contributor+ that helped on the issue and/or PR — @mananjadhavto be paid $250 (50%) in NewDot
Additional payment — @tienifr paid $50 in Upwork for helping to find that it was expected behavior, not a bug
Activity
[-][Distance] - App does not refocus on address field on delete and cancel[/-][+][$500] [Distance] - App does not refocus on address field on delete and cancel[/+]melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0115c7c503e332eb0f
melvin-bot commentedon Sep 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to @greg-schroeder (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)Krishna2323 commentedon Sep 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App does not refocus on address field on delete and cancel.
What is the root cause of that problem?
We are not refocusing on input when modal is closed.
What changes do you think we should make in order to solve the problem?
We need to focus on the input using input ref when waypoint delete modal is closed by passing onModalHide prop to
ConfirmModal.App/src/pages/iou/WaypointEditor.js
Lines 183 to 191 in 9d8518a
Result
yh-0218 commentedon Sep 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App does not refocus on address field on delete and cancel.
What is the root cause of that problem?
We are not focusing on input when modal is closed.
What changes do you think we should make in order to solve the problem?
We can call this function when close modal.
App/src/pages/iou/WaypointEditor.js
Lines 183 to 191 in 9d8518a
What alternative solutions did you explore? (Optional)
56 remaining items
Beamanator commentedon Oct 12, 2023
Quick bump, can we fix #28921 as part of this one, or should it be separate?
amyevans commentedon Oct 13, 2023
@Beamanator sorry, I totally missed your question the first time. The summary of this GH is that we've introduced no changes to the app and the GH will be closed as expected behavior. I see you've added them both to the tracking issue, thanks! I think that's the best course of action - we can come back to these GHs at a later date and approach more holistically, because honestly it's not efficient trying to address them each separately with a different group of individuals.
CortneyOfstad commentedon Oct 13, 2023
After an internal discussion with the team, it was decided that this is expected behavior, so this GH will be closed.
However, due to the work by @mananjadhav and @Krishna2323 as C+ and contributor on working on the PR, it was decided to offer a 50% payment.
@dhanashree-sawant also offering you 50% for the reporting — this has been paid in Upwork 👍
@mananjadhav if you would like to request that in NewDot, I will get a payment summary posted below.
@Krishna2323 I've paid you via Upwork, so you are all set 👍
Once all payments are completed (just waiting on NewDot), we will close this 👍
mananjadhav commentedon Oct 13, 2023
Thanks @CortneyOfstad, yes would need payment summary.
tienifr commentedon Oct 13, 2023
@CortneyOfstad I was the one who spotted the expected behavior and raised here: #27182 (comment). Would love to get compensated for that as well.
CortneyOfstad commentedon Oct 16, 2023
@amyevans Does that sound fair to you for compensating @tienifr as well? Just want a second pair of eyes — thanks!
amyevans commentedon Oct 17, 2023
👍
CortneyOfstad commentedon Oct 17, 2023
Alright @tienifr, after an internal discussion it was decided to offer $50 as a "bug reporter" for this issue in regards to expected behavior.
If possible, can you send over your Upwork profile so I can make sure that I am sending the proposal to the correct individual? Thanks!
tienifr commentedon Oct 17, 2023
@CortneyOfstad Here you are https://www.upwork.com/freelancers/~01991fd5e5c11ef3ba
CortneyOfstad commentedon Oct 17, 2023
Perfect! Just sent the proposal @tienifr 👍
CortneyOfstad commentedon Oct 17, 2023
@tienifr you have been paid 👍
Payment Summary
External issue reporter – @dhanashree-sawant paid $25 (50%) in Upwork
Contributor that fixed the issue — @Krishna2323 paid $250 (50%) in Upwork
Contributor+ that helped on the issue and/or PR — @mananjadhav to be paid $250 (50%) in NewDot
Additional payment — @tienifr paid $50 in Upwork for helping to find that it was expected behavior, not a bug
JmillsExpensify commentedon Oct 17, 2023
@250 payment approved for @mananjadhav based on summary above.