Skip to content

[$500] Distance IOU - Address field is focused after tapping Cancel on Delete confirmation #28921

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #28677

Action Performed:

  1. Launch New Expensify app
  2. Go to + > Request money > Distance
  3. Enter Start and Finish address
  4. Tap Add stop and add another address
  5. Tap on the newly created Stop > three-dot menu > Delete
  6. Tap Cancel

Expected Result:

The address field is not focused

Actual Result:

The address field is focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6225925_1696512767925.Screen_Recording_20231005_191547_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efd9ab51a81deed3
  • Upwork Job ID: 1711418091040071680
  • Last Price Increase: 2023-10-09

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 5, 2023
  2. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. mountiny commented on Oct 5, 2023

    @mountiny
    Contributor

    cc @0xmiroslav is this worth fixing regarding your autofocus discussion?

  5. 0xmiroslav commented on Oct 5, 2023

    @0xmiroslav
    Contributor

    I don't see any pattern of refocus after close modal except composer.
    Should all inputs resemble composer?

  6. Beamanator commented on Oct 6, 2023

    @Beamanator
    Contributor

    Hoping we can fix this at the same time as #27182

    Also adding to this main focus tracker issue: #15992

  7. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 9, 2023
  9. changed the title [-]Distance IOU - Address field is focused after tapping Cancel on Delete confirmation[/-] [+][$500] Distance IOU - Address field is focused after tapping Cancel on Delete confirmation[/+] on Oct 9, 2023
  10. melvin-bot commented on Oct 9, 2023

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 9, 2023
  12. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  13. chira37 commented on Oct 9, 2023

    @chira37

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Address field is focused after tapping Cancel on Delete confirmation

    What is the root cause of that problem?

    AddressSearch input is not blurring when clicking the three dot menu

    What changes do you think we should make in order to solve the problem?

    we can call input blur function when user click on three dot menu
    there is prop called onThreeDotsButtonPress in HeaderWithBackButton component

    onThreeDotsButtonPress={() => textInput.current && textInput.current.blur()}

    <HeaderWithBackButton
    title={translate(wayPointDescriptionKey)}
    shouldShowBackButton
    onBackButtonPress={() => {
    Navigation.goBack(ROUTES.MONEY_REQUEST_DISTANCE_TAB.getRoute(iouType));
    }}
    shouldShowThreeDotsButton={shouldShowThreeDotsButton}
    threeDotsAnchorPosition={styles.threeDotsPopoverOffset(windowWidth)}
    threeDotsMenuItems={[

    result

    Screen.Recording.2023-10-10.at.00.53.05.mov
  14. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    📣 @chira37! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  15. chira37 commented on Oct 9, 2023

    @chira37

    Contributor details
    Your Expensify account email: chirancjr@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/chiran

  16. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  17. abdulrahuman5196 commented on Oct 10, 2023

    @abdulrahuman5196
    Contributor

    Hoping we can fix this at the same time as #27182

    Also adding to this main focus tracker issue: #15992

    @Beamanator Can I review the proposals and handle this issue separately or is it expected to be fixed part of the tracking issue?

  18. Beamanator commented on Oct 12, 2023

    @Beamanator
    Contributor

    @abdulrahuman5196 I think this should be fixed either in #27182 or #15992 so I say let's close this one out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions