You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Distance - Scrolling doesn't work when the number of waypoints increases #27382
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Can't scroll the waypoints list on Android only.
What is the root cause of that problem?
In the distance page, we have a nested ScrollView. One for the whole page, and one for the waypoint list. On Android, we are unable to scroll the nested ScrollView. This can be reproduced in a fresh new react native project.
This nested scrolling issue doesn't happen on iOS as nested scrolling is supported by default.
@bernhardoj's root cause is correct. It's scrolling limit in android. nestedScrollEnabled=true also seems the only solution unless we prevent scrolling in parent view.
Ah cool, thank you for the investigation and determining that it's a regression of #26728.
@hayata-suenaga tagging you since you're the internal eng/ for that PR, do you want to handle this as a regression or shall we handle this as a separate issue and start looking at proposals?
Activity
OSBotify commentedon Sep 13, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.NikkiWines commentedon Sep 13, 2023
Yeah looks like it's almost certainly tied to #27076 since that modified scrolling for multiple waypoints.
cc: @jjcoffee @arosiclair
NikkiWines commentedon Sep 13, 2023
@arosiclair was able to reproduce this on v1.3.68-17 (yesterday's deploy) so this isn't actually a blocker and #27076 isn't the root cause.
This isn't a blocker, but will continue to look into to see if we can find the root cause for it.
bernhardoj commentedon Sep 14, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't scroll the waypoints list on Android only.
What is the root cause of that problem?
In the distance page, we have a nested ScrollView. One for the whole page, and one for the waypoint list. On Android, we are unable to scroll the nested ScrollView. This can be reproduced in a fresh new react native project.
This nested scrolling issue doesn't happen on iOS as nested scrolling is supported by default.
This issue starts to happen after we wrap the whole page with a ScrollView
What changes do you think we should make in order to solve the problem?
To support nested scrolling on Android too, set
nestedScrollEnabled(Android only prop) to true to the waypoints ScrollView.App/src/components/DistanceRequest.js
Lines 172 to 181 in b11bddc
situchan commentedon Sep 14, 2023
@bernhardoj's root cause is correct. It's scrolling limit in android.
nestedScrollEnabled=truealso seems the only solution unless we prevent scrolling in parent view.NikkiWines commentedon Sep 15, 2023
Ah cool, thank you for the investigation and determining that it's a regression of #26728.
@hayata-suenaga tagging you since you're the internal eng/ for that PR, do you want to handle this as a regression or shall we handle this as a separate issue and start looking at proposals?
hayata-suenaga commentedon Sep 15, 2023
thank you for letting me know about this issue Nikki
We can actually close this issue as we're making an UI change here and making the waypoint list not scrollable