Skip to content

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

Description

@OSBotify

Release Version: 1.3.68-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. mvtglobally commented on Sep 12, 2023

    @mvtglobally
  2. OSBotify commented on Sep 12, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.68-11 🚀

  3. melvin-bot commented on Sep 12, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. dangrous commented on Sep 12, 2023

    @dangrous
    Contributor

    Checking off #27250 - it's still open but should not be a Deploy Blocker

  5. francoisl commented on Sep 12, 2023

    @francoisl
    Contributor

    Fix for blockers 27238 and 27239 were CP'ed and tested on staging, checking those off.

  6. kavimuru commented on Sep 12, 2023

    @kavimuru

    @AndrewGable Regression TR 75% completed
    Team retesting these PRs #26225 #26983 #27006 which were blocked by #27234
    #26638 is still failing in mweb and native apps #26121
    #26964 still failing #26702 in android
    #26841 still failing #25704 in web

  7. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    Checking off #27300 which is a revert PR of #26638 -- which I also checked off

  8. mvtglobally commented on Sep 13, 2023

    @mvtglobally

    Main regression is completed. We are just left with 3 IOS 17 BETA slots. Same steps were tested on non Beta IOS

    Current open PRs

    #26964 still failing #26702 in android
    #27256 iOS validation pending, rest platforms pass
    #27245 iOS validation pending, rest platforms pass

  9. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    Checking off #27301 which is a revert of #26964 -- which I also checked off

  10. mvtglobally commented on Sep 13, 2023

    @mvtglobally

    And this one #26225 (comment)

  11. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    #26964 still failing #26702 in android

    ✅

    #27256 iOS validation pending, rest platforms pass

    Verified iOS manually

    #27245 iOS validation pending, rest platforms pass

    verified iOS manually

    And this one #26225 (comment)

    Checking off as it's not a blocker and a follow up is already in progress

  12. self-assigned this
    on Sep 13, 2023
  13. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    App performance Timing had a spike, but this was deemed an outlier ✅

  14. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    While checking Firebase there were two new tricky-to-decipher native crashes:

  15. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    Firebase issues cleared. Pre-existing

  16. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    Github status ✅

  17. Julesssss commented on Sep 13, 2023

    @Julesssss
    Contributor

    :shipit:

  18. deleted a comment from melvin-bot on Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions