Repository navigation
Revert "Fix: Keyboard shouldn't be active/enabled automatically for request details" - #27301
Conversation
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Revert "Fix: Keyboard shouldn't be active/enabled automatically for request details" (cherry picked from commit 7be4a0b)
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.3.68-17 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
Details
Straight revert of #26964 as the QA is still failing as mentioned here
Fixed Issues
N/A
Tests
N/A - Straight revert
Offline tests
N/A - Straight revert
QA Steps
N/A - Straight revert
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
N/A - Straight revert
Mobile Web - Chrome
N/A - Straight revert
Mobile Web - Safari
N/A - Straight revert
Desktop
N/A - Straight revert
iOS
N/A - Straight revert
Android
N/A - Straight revert