Repository navigation
fix(task-pages): Force task page editions only for task reports - #26924
Conversation
Reviewer Checklist
Screenshots/VideosWeb26924.Web.mp4Mobile Web - Chrome26924.mWeb-Chrome.mp4Mobile Web - Safari26924.mWeb-Safari.mp4Desktop26924.Desktop.mp4iOS26924.iOS.mp4Android26924.Android.mp4 |
|
Sorry @daordonez11, I'm running out of time. I'll complete the test in the morning. |
|
No worries thanks for the heads-up @mollfpr |
|
Hey @mollfpr friendly bump! Trying still to reach that 72h limit 🫡 |
mollfpr
left a comment
There was a problem hiding this comment.
LGTM and tests well 👍
@daordonez11 The QA test step is not clear to me. We need to test the task title and task assignee page.
In your test, steps 6 and 7 are not necessarily included. We don't need to click on the fields after a click on the IOU message; we can say to change the URL by adding /description, /title, and /assignee and verify that the IOU report is displayed or the user navigates to the IOU report, or the URL consists only of the reportID.
We also need to clarify the test for the native since we can't change the URL. We can test it using the URL deep link. The QA team needs to send the 3 URLs of the IOU reportID and press to navigate to the page https://staging.new.expensify.com/r/{reportID}/{description/title/assignee}
|
@daordonez11 can you edit the QA steps based on @mollfpr's comment here please? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
For sure! @mollfpr I have updated the test description #26924 (comment) do you agree with it or any update? cc @francoisl |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.68-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
Details
Only allow edition of task report attributes for task reports.
Fixed Issues
$ #25950
PROPOSAL: #25950 (comment)
Tests
All
https://staging.new.expensify.com/r/{requestReportID}https://staging.new.expensify.com/r/{requestReportID}/edit/descriptionand for a task report it ishttps://staging.new.expensify.com/r/{taskReportID}/descriptionsince you have a request report the second should not workWeb-mWeb
https://staging.new.expensify.com/r/{requestReportID}/descriptionyou should be sent tohttps://staging.new.expensify.com/r/{requestReportID}since this URL only applies for task reports.Native (iOS/Android)
https://staging.new.expensify.com/r/{requestReportID}/{description/title/assignee}Offline tests
same as tests
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Web.Desc.-.9_7_2023.8_04_53.PM.webm
Mobile Web - Chrome
mWeb.Chrome.Desc-.9_7_2023.8_06_46.PM.webm
Mobile Web - Safari
RPReplay_Final1694135432.MP4
Desktop
Desktop.desc.-.9_7_2023.8_13_23.PM.webm
iOS
iOS.Desc.-.9_7_2023.8_30_19.PM.webm
Android
Android.desc.-.9_7_2023.9_02_21.PM.webm