Repository navigation
fix: pressing enter doesn't open the selected option page - #26743
Merged
Merged
Conversation
dukenv0307
marked this pull request as ready for review
September 6, 2023 02:54
melvin-bot
Bot
requested review from
jjcoffee
and removed request for
a team
September 6, 2023 02:55
Contributor
Reviewer Checklist
Screenshots/VideosWebchrome-desktop-2023-09-07_13.49.26.mp4Mobile Web - Chromeandroid-chrome.mp4Mobile Web - Safariios-safari-2023-09-07_14.02.35.mp4Desktopmac-desktop.mp4iOSios-native-2023-09-07_13.53.20.mp4Androidandroid-native.mp4 |
Beamanator
approved these changes
Sep 9, 2023
Beamanator
left a comment
Contributor
There was a problem hiding this comment.
LGTM! (waiting for Monday to confirm feature freeze is over)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.68-0 🚀
|
1 of 6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Pressing Enter doesn't open the selected option page
Fixed Issues
$ #26228
PROPOSAL: #26228 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.4.mp4
Mobile Web - Chrome
chrome.mov
Mobile Web - Safari
safari.mov
Desktop
desktop.2.mp4
iOS
ios.mov
Android
android.mov