Repository navigation
Conversation
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24729 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Hi! This is the first one of these I've looked at so it might take some time; we're on the merge freeze anyway so it doesn't seem like there's a huge rush. I will probably ask a number of basic questions, so apologies in advance! |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-08-30.at.20.49.22.movScreen.Recording.2023-08-30.at.20.49.54.movMobile Web - ChromeScreen.Recording.2023-08-30.at.20.46.20.movMobile Web - SafariScreen.Recording.2023-08-30.at.20.46.57.movDesktopScreen.Recording.2023-08-30.at.20.50.23.moviOSScreen.Recording.2023-08-30.at.20.48.29.movAndroidScreen.Recording.2023-08-30.at.20.47.45.mov |
|
okay first question - most of this makes sense, but in a couple of the functions we moved around the order of the |
|
Also just to be double careful, before merging let's make sure this branch is in sync with the newest main @dangrous (we should check that parameters are in the correct order in all function usages) |
|
ah okay cool, thank you for explaining! That makes sense |
dangrous
left a comment
There was a problem hiding this comment.
Just one minor change, otherwise this looks good assuming we double check that we've adjusted all usages of these functions to be in the right order!
| * @param {Number} tooltipTargetWidth - The width of the tooltip's target | ||
| * @param {Number} tooltipTargetHeight - The height of the tooltip's target | ||
| * @returns {Boolean} | ||
| * @param [tooltip] - The reference to the tooltip's root element |
There was a problem hiding this comment.
move this one to the top of the param list
dangrous
left a comment
There was a problem hiding this comment.
This works for me! Just one final question - do we have an automated TS checker set up yet, or are we relying on us to make sure we catch all the places we need types?
|
Sweet! Two more things now:
|
|
@dangrous Done! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.68-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|

Details
Migration of src/styles/getTooltipStyles.js to Typescript.
Fixed Issues
$ #24729
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
+buttonPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Desktop
desktop.mov
iOS
ios.mov