Repository navigation
Display not found page with invalid field edit - #26269
Merged
Merged
Conversation
dukenv0307
marked this pull request as ready for review
August 30, 2023 03:15
melvin-bot
Bot
requested review from
thesahindia
and removed request for
a team
August 30, 2023 03:15
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@thesahindia Friendly bump. |
Member
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeScreen.Recording.2023-08-31.at.3.27.45.PM.movMobile Web - SafariScreen.Recording.2023-08-31.at.3.33.16.PM.movDesktopiOSAndroid |
Contributor
Author
|
@bondydaa Friendly bump |
bondydaa
approved these changes
Sep 6, 2023
Contributor
|
not merging since we are in a feature freeze right now. |
1 of 6 tasks
Contributor
Author
|
@bondydaa The PR is ready to merge since the freeze is over. |
Contributor
Author
|
Sorry I mistakenly clicked close with comment. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.68-0 🚀
|
1 of 6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
We should display not found page in
EditRequestPagewhenfieldToEditis invalidFixed Issues
$ #26014
PROPOSAL: #26014 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screencast.from.30-08-2023.09.33.43.webm
Mobile Web - Chrome
Record_2023-08-30-09-39-57.mp4
Mobile Web - Safari
Screen.Recording.2023-08-30.at.10.11.08.mov
Desktop
Screen.Recording.2023-08-30.at.10.05.28.mov
iOS
Screen.Recording.2023-08-30.at.10.00.55.mp4
Android
26014.webm