Repository navigation
Fix mark as unread in LHN - #27245
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mananjadhav Please ignore this issue. The linked issue hasn't already any C+. |
Reviewer Checklist
Screenshots/VideosWebregression-fix-chrome-desktop-2023-09-12_15.07.01.mp4Mobile Web - Chromeregression-fix-android-chrome.mp4Mobile Web - Safariregression-fix-ios-safari-2023-09-12_15.14.03.mp4Desktopregression-fix-mac-desktop-2023-09-12_15.16.44.mp4iOSregression-fix-ios-native-2023-09-12_15.19.05.mp4Androidregression-fix-android-native.mp4 |
|
All yours @cristipaval - I think we can CP this to staging too. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit bf7ff06)
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.68-14 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Verified iOS manually |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
Details
We missed the param when calling
showContextMenuin LHN that makes the app crashesFixed Issues
$ #27238
PROPOSAL: #25538 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screencast.from.12-09-2023.19.10.41.webm
Mobile Web - Chrome
Record_2023-09-12-19-19-25.mp4
Mobile Web - Safari
Screen.Recording.2023-09-12.at.19.20.06.mov
Desktop
Screen.Recording.2023-09-12.at.19.23.01.mov
iOS
Screen.Recording.2023-09-12.at.19.18.45.mov
Android
27238.webm